From: Thibault Saunier <thibault.saunier@osg.samsung.com> To: linux-kernel@vger.kernel.org Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com>, Kukjin Kim <kgene@kernel.org>, Mauro Carvalho Chehab <mchehab@s-opensource.com>, Nicolas Dufresne <nicolas.dufresne@collabora.com>, Andi Shyti <andi.shyti@samsung.com>, linux-media@vger.kernel.org, Shuah Khan <shuahkh@osg.samsung.com>, Javier Martinez Canillas <javier@osg.samsung.com>, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>, Inki Dae <inki.dae@samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Thibault Saunier <thibault.saunier@osg.samsung.com>, linux-arm-kernel@lists.infradead.org, Ulf Hansson <ulf.hansson@linaro.org> Subject: [PATCH v4 1/4] [media] exynos-gsc: Use 576p instead 720p as a threshold for colorspaces Date: Mon, 13 Feb 2017 16:08:33 -0300 [thread overview] Message-ID: <20170213190836.26972-2-thibault.saunier@osg.samsung.com> (raw) In-Reply-To: <20170213190836.26972-1-thibault.saunier@osg.samsung.com> From: Javier Martinez Canillas <javier@osg.samsung.com> The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers don't agree on the display resolution that should be used as a threshold. >From EIA CEA 861B about colorimetry for various resolutions: - 5.1 480p, 480i, 576p, 576i, 240p, and 288p The color space used by the 480-line, 576-line, 240-line, and 288-line formats will likely be based on SMPTE 170M [1]. - 5.2 1080i, 1080p, and 720p The color space used by the high definition formats will likely be based on ITU-R BT.709-4 This indicates that in the case that userspace does not specify what colorspace should be used, we should use 576p as a threshold to set V4L2_COLORSPACE_REC709 instead of V4L2_COLORSPACE_REC709. Even if it is only 'likely' and not a requirement it is the best guess we can make. The stream should have been encoded with the information and userspace has to pass it to the driver if it is not the case, otherwise we won't be able to handle it properly anyhow. Also, check for the resolution in G_FMT instead unconditionally setting the V4L2_COLORSPACE_REC709 colorspace. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Thibault Saunier <thibault.saunier@osg.samsung.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> --- Changes in v4: - Reword commit message to better back our assumptions on specifications Changes in v3: - Do not check values in the g_fmt functions as Andrzej explained in previous review - Added 'Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>' Changes in v2: None drivers/media/platform/exynos-gsc/gsc-core.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index 59a634201830..db7d9883861b 100644 --- a/drivers/media/platform/exynos-gsc/gsc-core.c +++ b/drivers/media/platform/exynos-gsc/gsc-core.c @@ -472,7 +472,7 @@ int gsc_try_fmt_mplane(struct gsc_ctx *ctx, struct v4l2_format *f) pix_mp->num_planes = fmt->num_planes; - if (pix_mp->width >= 1280) /* HD */ + if (pix_mp->width > 720 && pix_mp->height > 576) /* HD */ pix_mp->colorspace = V4L2_COLORSPACE_REC709; else /* SD */ pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; @@ -519,9 +519,13 @@ int gsc_g_fmt_mplane(struct gsc_ctx *ctx, struct v4l2_format *f) pix_mp->height = frame->f_height; pix_mp->field = V4L2_FIELD_NONE; pix_mp->pixelformat = frame->fmt->pixelformat; - pix_mp->colorspace = V4L2_COLORSPACE_REC709; pix_mp->num_planes = frame->fmt->num_planes; + if (pix_mp->width > 720 && pix_mp->height > 576) /* HD */ + pix_mp->colorspace = V4L2_COLORSPACE_REC709; + else /* SD */ + pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; + for (i = 0; i < pix_mp->num_planes; ++i) { pix_mp->plane_fmt[i].bytesperline = (frame->f_width * frame->fmt->depth[i]) / 8; -- 2.11.1
WARNING: multiple messages have this Message-ID (diff)
From: thibault.saunier@osg.samsung.com (Thibault Saunier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 1/4] [media] exynos-gsc: Use 576p instead 720p as a threshold for colorspaces Date: Mon, 13 Feb 2017 16:08:33 -0300 [thread overview] Message-ID: <20170213190836.26972-2-thibault.saunier@osg.samsung.com> (raw) In-Reply-To: <20170213190836.26972-1-thibault.saunier@osg.samsung.com> From: Javier Martinez Canillas <javier@osg.samsung.com> The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers don't agree on the display resolution that should be used as a threshold. >From EIA CEA 861B about colorimetry for various resolutions: - 5.1 480p, 480i, 576p, 576i, 240p, and 288p The color space used by the 480-line, 576-line, 240-line, and 288-line formats will likely be based on SMPTE 170M [1]. - 5.2 1080i, 1080p, and 720p The color space used by the high definition formats will likely be based on ITU-R BT.709-4 This indicates that in the case that userspace does not specify what colorspace should be used, we should use 576p as a threshold to set V4L2_COLORSPACE_REC709 instead of V4L2_COLORSPACE_REC709. Even if it is only 'likely' and not a requirement it is the best guess we can make. The stream should have been encoded with the information and userspace has to pass it to the driver if it is not the case, otherwise we won't be able to handle it properly anyhow. Also, check for the resolution in G_FMT instead unconditionally setting the V4L2_COLORSPACE_REC709 colorspace. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Thibault Saunier <thibault.saunier@osg.samsung.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> --- Changes in v4: - Reword commit message to better back our assumptions on specifications Changes in v3: - Do not check values in the g_fmt functions as Andrzej explained in previous review - Added 'Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>' Changes in v2: None drivers/media/platform/exynos-gsc/gsc-core.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index 59a634201830..db7d9883861b 100644 --- a/drivers/media/platform/exynos-gsc/gsc-core.c +++ b/drivers/media/platform/exynos-gsc/gsc-core.c @@ -472,7 +472,7 @@ int gsc_try_fmt_mplane(struct gsc_ctx *ctx, struct v4l2_format *f) pix_mp->num_planes = fmt->num_planes; - if (pix_mp->width >= 1280) /* HD */ + if (pix_mp->width > 720 && pix_mp->height > 576) /* HD */ pix_mp->colorspace = V4L2_COLORSPACE_REC709; else /* SD */ pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; @@ -519,9 +519,13 @@ int gsc_g_fmt_mplane(struct gsc_ctx *ctx, struct v4l2_format *f) pix_mp->height = frame->f_height; pix_mp->field = V4L2_FIELD_NONE; pix_mp->pixelformat = frame->fmt->pixelformat; - pix_mp->colorspace = V4L2_COLORSPACE_REC709; pix_mp->num_planes = frame->fmt->num_planes; + if (pix_mp->width > 720 && pix_mp->height > 576) /* HD */ + pix_mp->colorspace = V4L2_COLORSPACE_REC709; + else /* SD */ + pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; + for (i = 0; i < pix_mp->num_planes; ++i) { pix_mp->plane_fmt[i].bytesperline = (frame->f_width * frame->fmt->depth[i]) / 8; -- 2.11.1
next prev parent reply other threads:[~2017-02-13 19:09 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-13 19:08 [PATCH v4 0/4] Fixes for colorspace logic in exynos-gsc and s5p-mfc drivers Thibault Saunier 2017-02-13 19:08 ` Thibault Saunier 2017-02-13 19:08 ` Thibault Saunier 2017-02-13 19:08 ` Thibault Saunier [this message] 2017-02-13 19:08 ` [PATCH v4 1/4] [media] exynos-gsc: Use 576p instead 720p as a threshold for colorspaces Thibault Saunier 2017-02-14 15:19 ` Fabien DESSENNE 2017-02-14 15:19 ` Fabien DESSENNE 2017-02-14 15:19 ` Fabien DESSENNE 2017-02-21 9:56 ` Andrzej Hajda 2017-02-21 9:56 ` Andrzej Hajda 2017-02-21 18:04 ` Thibault Saunier 2017-02-21 18:04 ` Thibault Saunier 2017-02-21 18:04 ` Thibault Saunier 2017-02-13 19:08 ` [PATCH v4 2/4] [media] exynos-gsc: Respect userspace colorspace setting in try_fmt Thibault Saunier 2017-02-13 19:08 ` Thibault Saunier 2017-02-21 10:15 ` Andrzej Hajda 2017-02-21 10:15 ` Andrzej Hajda 2017-02-13 19:08 ` [PATCH v4 3/4] [media] s5p-mfc: Set colorspace in VIDIO_{G,TRY}_FMT if DEFAULT provided Thibault Saunier 2017-02-13 19:08 ` [PATCH v4 3/4] [media] s5p-mfc: Set colorspace in VIDIO_{G, TRY}_FMT " Thibault Saunier 2017-02-13 19:08 ` Thibault Saunier 2017-02-13 19:08 ` [PATCH v4 4/4] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt Thibault Saunier 2017-02-13 19:08 ` Thibault Saunier 2017-02-13 19:08 ` Thibault Saunier 2017-02-21 10:19 ` Andrzej Hajda 2017-02-21 10:19 ` Andrzej Hajda
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170213190836.26972-2-thibault.saunier@osg.samsung.com \ --to=thibault.saunier@osg.samsung.com \ --cc=andi.shyti@samsung.com \ --cc=inki.dae@samsung.com \ --cc=javier@osg.samsung.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mchehab@kernel.org \ --cc=mchehab@s-opensource.com \ --cc=nicolas.dufresne@collabora.com \ --cc=s.nawrocki@samsung.com \ --cc=shuahkh@osg.samsung.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.