All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhijit Naik <abhijitnaik27@gmail.com>
To: gregkh@linuxfoundation.org
Cc: rjui@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Abhijit Naik <abhijitnaik27@gmail.com>
Subject: [PATCH 1/2] staging: bcm2835-audio: Removed error due to trailing statement
Date: Tue, 14 Feb 2017 00:42:16 +0530	[thread overview]
Message-ID: <20170213191217.5201-1-abhijitnaik27@gmail.com> (raw)

bcm2835-vchiq.c:
fixing ERROR: trailing statements should be on next line

Print statement that was on the same line as else statement has been enclosed
within braces and moved to the next line.

Signed-off-by: Abhijit Naik <abhijitnaik27@gmail.com>
---
 drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index c52ac2753898..d11f2cdd1014 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
@@ -563,7 +563,9 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
 			} else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) {
 				LOG_ERR("Couldn't set the controls for stream %d\n", i);
 				ret = -1;
-			} else LOG_DBG(" Controls set for stream %d\n", i);
+			} else {
+				LOG_DBG(" Controls set for stream %d\n", i);
+			}
 		}
 	}
 	LOG_DBG(" .. OUT ret=%d\n", ret);
--
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: abhijitnaik27@gmail.com (Abhijit Naik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] staging: bcm2835-audio: Removed error due to trailing statement
Date: Tue, 14 Feb 2017 00:42:16 +0530	[thread overview]
Message-ID: <20170213191217.5201-1-abhijitnaik27@gmail.com> (raw)

bcm2835-vchiq.c:
fixing ERROR: trailing statements should be on next line

Print statement that was on the same line as else statement has been enclosed
within braces and moved to the next line.

Signed-off-by: Abhijit Naik <abhijitnaik27@gmail.com>
---
 drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index c52ac2753898..d11f2cdd1014 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
@@ -563,7 +563,9 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
 			} else if (bcm2835_audio_set_ctls_chan(chip->alsa_stream[i], chip) != 0) {
 				LOG_ERR("Couldn't set the controls for stream %d\n", i);
 				ret = -1;
-			} else LOG_DBG(" Controls set for stream %d\n", i);
+			} else {
+				LOG_DBG(" Controls set for stream %d\n", i);
+			}
 		}
 	}
 	LOG_DBG(" .. OUT ret=%d\n", ret);
--
2.11.0

             reply	other threads:[~2017-02-13 19:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 19:12 Abhijit Naik [this message]
2017-02-13 19:12 ` [PATCH 1/2] staging: bcm2835-audio: Removed error due to trailing statement Abhijit Naik
2017-02-13 19:12 ` [PATCH 2/2] staging: bcm2835-audio: Fixed checkpatch warning due to line spacing Abhijit Naik
2017-02-13 19:12   ` Abhijit Naik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170213191217.5201-1-abhijitnaik27@gmail.com \
    --to=abhijitnaik27@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.