All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [CI 18/23] drm/i915: Remove defunct GTT tracepoints
Date: Wed, 15 Feb 2017 08:43:52 +0000	[thread overview]
Message-ID: <20170215084357.19977-18-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20170215084357.19977-1-chris@chris-wilson.co.uk>

The tracepoints are now entirely synonymous with binding and unbinding the
VMA (and the tracepoints there).

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c |  4 --
 drivers/gpu/drm/i915/i915_trace.h   | 97 -------------------------------------
 2 files changed, 101 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 9db033c8e7c5..0748c4406f27 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -193,7 +193,6 @@ static int ppgtt_bind_vma(struct i915_vma *vma,
 	u32 pte_flags;
 	int ret;
 
-	trace_i915_va_alloc(vma);
 	ret = vma->vm->allocate_va_range(vma->vm, vma->node.start, vma->size);
 	if (ret)
 		return ret;
@@ -1321,9 +1320,6 @@ static int gen8_ppgtt_init(struct i915_hw_ppgtt *ppgtt)
 
 		ppgtt->base.total = 1ULL << 32;
 		ppgtt->switch_mm = gen8_legacy_mm_switch;
-		trace_i915_page_directory_pointer_entry_alloc(&ppgtt->base,
-							      0, 0,
-							      GEN8_PML4E_SHIFT);
 
 		if (intel_vgpu_active(dev_priv)) {
 			ret = gen8_preallocate_top_level_pdp(ppgtt);
diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
index de31c49781d3..7a547cdfc381 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -175,103 +175,6 @@ TRACE_EVENT(i915_vma_unbind,
 		      __entry->obj, __entry->offset, __entry->size, __entry->vm)
 );
 
-TRACE_EVENT(i915_va_alloc,
-	TP_PROTO(struct i915_vma *vma),
-	TP_ARGS(vma),
-
-	TP_STRUCT__entry(
-		__field(struct i915_address_space *, vm)
-		__field(u64, start)
-		__field(u64, end)
-	),
-
-	TP_fast_assign(
-		__entry->vm = vma->vm;
-		__entry->start = vma->node.start;
-		__entry->end = vma->node.start + vma->node.size - 1;
-	),
-
-	TP_printk("vm=%p (%c), 0x%llx-0x%llx",
-		  __entry->vm, i915_is_ggtt(__entry->vm) ? 'G' : 'P',  __entry->start, __entry->end)
-);
-
-DECLARE_EVENT_CLASS(i915_px_entry,
-	TP_PROTO(struct i915_address_space *vm, u32 px, u64 start, u64 px_shift),
-	TP_ARGS(vm, px, start, px_shift),
-
-	TP_STRUCT__entry(
-		__field(struct i915_address_space *, vm)
-		__field(u32, px)
-		__field(u64, start)
-		__field(u64, end)
-	),
-
-	TP_fast_assign(
-		__entry->vm = vm;
-		__entry->px = px;
-		__entry->start = start;
-		__entry->end = ((start + (1ULL << px_shift)) & ~((1ULL << px_shift)-1)) - 1;
-	),
-
-	TP_printk("vm=%p, pde=%d (0x%llx-0x%llx)",
-		  __entry->vm, __entry->px, __entry->start, __entry->end)
-);
-
-DEFINE_EVENT(i915_px_entry, i915_page_table_entry_alloc,
-	     TP_PROTO(struct i915_address_space *vm, u32 pde, u64 start, u64 pde_shift),
-	     TP_ARGS(vm, pde, start, pde_shift)
-);
-
-DEFINE_EVENT_PRINT(i915_px_entry, i915_page_directory_entry_alloc,
-		   TP_PROTO(struct i915_address_space *vm, u32 pdpe, u64 start, u64 pdpe_shift),
-		   TP_ARGS(vm, pdpe, start, pdpe_shift),
-
-		   TP_printk("vm=%p, pdpe=%d (0x%llx-0x%llx)",
-			     __entry->vm, __entry->px, __entry->start, __entry->end)
-);
-
-DEFINE_EVENT_PRINT(i915_px_entry, i915_page_directory_pointer_entry_alloc,
-		   TP_PROTO(struct i915_address_space *vm, u32 pml4e, u64 start, u64 pml4e_shift),
-		   TP_ARGS(vm, pml4e, start, pml4e_shift),
-
-		   TP_printk("vm=%p, pml4e=%d (0x%llx-0x%llx)",
-			     __entry->vm, __entry->px, __entry->start, __entry->end)
-);
-
-/* Avoid extra math because we only support two sizes. The format is defined by
- * bitmap_scnprintf. Each 32 bits is 8 HEX digits followed by comma */
-#define TRACE_PT_SIZE(bits) \
-	((((bits) == 1024) ? 288 : 144) + 1)
-
-DECLARE_EVENT_CLASS(i915_page_table_entry_update,
-	TP_PROTO(struct i915_address_space *vm, u32 pde,
-		 struct i915_page_table *pt, u32 first, u32 count),
-	TP_ARGS(vm, pde, pt, first, count),
-
-	TP_STRUCT__entry(
-		__field(struct i915_address_space *, vm)
-		__field(u32, pde)
-		__field(u32, first)
-		__field(u32, last)
-	),
-
-	TP_fast_assign(
-		__entry->vm = vm;
-		__entry->pde = pde;
-		__entry->first = first;
-		__entry->last = first + count - 1;
-	),
-
-	TP_printk("vm=%p, pde=%d, updating %u:%u",
-		  __entry->vm, __entry->pde, __entry->last, __entry->first)
-);
-
-DEFINE_EVENT(i915_page_table_entry_update, i915_page_table_entry_map,
-	TP_PROTO(struct i915_address_space *vm, u32 pde,
-		 struct i915_page_table *pt, u32 first, u32 count),
-	TP_ARGS(vm, pde, pt, first, count)
-);
-
 TRACE_EVENT(i915_gem_object_change_domain,
 	    TP_PROTO(struct drm_i915_gem_object *obj, u32 old_read, u32 old_write),
 	    TP_ARGS(obj, old_read, old_write),
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-02-15  8:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15  8:43 [CI 01/23] drm/i915: Micro-optimise i915_get_ggtt_vma_pages() Chris Wilson
2017-02-15  8:43 ` [CI 02/23] drm/i915: Micro-optimise gen6_ppgtt_insert_entries() Chris Wilson
2017-02-15  8:43 ` [CI 03/23] drm/i915: Micro-optimise gen8_ppgtt_insert_entries() Chris Wilson
2017-02-15  8:43 ` [CI 04/23] drm/i915: Don't special case teardown of aliasing_ppgtt Chris Wilson
2017-02-15  8:43 ` [CI 05/23] drm/i915: Split ggtt/alasing_gtt unbind_vma Chris Wilson
2017-02-15  8:43 ` [CI 06/23] drm/i915: Convert clflushed pagetables over to WC maps Chris Wilson
2017-02-15  8:43 ` [CI 07/23] drm/i915: Remove kmap/kunmap wrappers Chris Wilson
2017-02-15  8:43 ` [CI 08/23] drm/i915: Move allocate_va_range to GTT Chris Wilson
2017-02-15  8:43 ` [CI 09/23] drm/i915: Always preallocate gen6/7 ppgtt Chris Wilson
2017-02-15  8:43 ` [CI 10/23] drm/i915: Remove redundant clear of appgtt Chris Wilson
2017-02-15  8:43 ` [CI 11/23] drm/i915: Tidy gen6_write_pde() Chris Wilson
2017-02-15  8:43 ` [CI 12/23] drm/i915: Remove bitmap tracking for used-ptes Chris Wilson
2017-02-15  8:43 ` [CI 13/23] drm/i915: Remove bitmap tracking for used-pdes Chris Wilson
2017-02-15  8:43 ` [CI 14/23] drm/i915: Remove bitmap tracking for used-pdpes Chris Wilson
2017-02-15  8:43 ` [CI 15/23] drm/i915: Remove bitmap tracking for used-pml4 Chris Wilson
2017-02-15  8:43 ` [CI 16/23] drm/i915: Remove superfluous posting reads after clear GGTT Chris Wilson
2017-02-15  8:43 ` [CI 17/23] drm/i915: Always mark the PDP as dirty when altered Chris Wilson
2017-02-15  8:43 ` Chris Wilson [this message]
2017-02-15  8:43 ` [CI 19/23] drm/i915: Remove unused ppgtt->enable() Chris Wilson
2017-02-15  8:43 ` [CI 20/23] drm/i915: Remove i915_address_space.start Chris Wilson
2017-02-15  8:43 ` [CI 21/23] drm/i915: Only preallocate the aliasing GTT to the extents of the global GTT Chris Wilson
2017-02-15  8:43 ` [CI 22/23] drm/i915: Differentiate the aliasing_ppgtt with an invalid filp Chris Wilson
2017-02-15  8:43 ` [CI 23/23] drm/i915: Use preferred kernel types in i915_gem_gtt.c Chris Wilson
2017-02-15  9:52 ` ✓ Fi.CI.BAT: success for series starting with [CI,01/23] drm/i915: Micro-optimise i915_get_ggtt_vma_pages() Patchwork
2017-02-15 10:11   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215084357.19977-18-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.