All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Zegan" <webczat@webczatnet.pl>
To: Kevin Hilman <khilman@baylibre.com>, Carlo Caione <carlo@caione.org>
Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-mmc@vger.kernel.org, "Ulf Hansson" <ulf.hansson@linaro.org>,
	"Michał Zegan" <webczat@webczatnet.pl>
Subject: [PATCH v2] mmc: meson-gx: remove mmc host on device removal
Date: Sat, 18 Feb 2017 18:06:47 +0100	[thread overview]
Message-ID: <20170218170647.5860-2-webczat@webczatnet.pl> (raw)
In-Reply-To: <20170218170647.5860-1-webczat@webczatnet.pl>

The mmc host was added in meson_mmc_probe, but never removed in
meson_mmc_remove.
Fix that by removing the host before deallocating other resources.

Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
Tested-by: Michał Zegan <webczat@webczatnet.pl>
---
changes since v1:
rebased on top of patchset at
https://patchwork.kernel.org/patch/9581057/
This is in turn based on patchset at
https://patchwork.kernel.org/patch/9561215/

 drivers/mmc/host/meson-gx-mmc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index e759e4c2e4a0..336b6a2e94c6 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
 {
 	struct meson_host *host = dev_get_drvdata(&pdev->dev);
 
+	mmc_remove_host(host->mmc);
+
 	/* disable interrupts */
 	writel(0, host->regs + SD_EMMC_IRQ_EN);
 
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: webczat@webczatnet.pl (Michał Zegan)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2] mmc: meson-gx: remove mmc host on device removal
Date: Sat, 18 Feb 2017 18:06:47 +0100	[thread overview]
Message-ID: <20170218170647.5860-2-webczat@webczatnet.pl> (raw)
In-Reply-To: <20170218170647.5860-1-webczat@webczatnet.pl>

The mmc host was added in meson_mmc_probe, but never removed in
meson_mmc_remove.
Fix that by removing the host before deallocating other resources.

Signed-off-by: Micha? Zegan <webczat@webczatnet.pl>
Tested-by: Micha? Zegan <webczat@webczatnet.pl>
---
changes since v1:
rebased on top of patchset at
https://patchwork.kernel.org/patch/9581057/
This is in turn based on patchset at
https://patchwork.kernel.org/patch/9561215/

 drivers/mmc/host/meson-gx-mmc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index e759e4c2e4a0..336b6a2e94c6 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
 {
 	struct meson_host *host = dev_get_drvdata(&pdev->dev);
 
+	mmc_remove_host(host->mmc);
+
 	/* disable interrupts */
 	writel(0, host->regs + SD_EMMC_IRQ_EN);
 
-- 
2.11.0

  reply	other threads:[~2017-02-18 17:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18 17:06 [PATCH] mmc: meson-gx: fix error path when driver initialization fails before enabling clocks Michał Zegan
2017-02-18 17:06 ` Michał Zegan
2017-02-18 17:06 ` Michał Zegan [this message]
2017-02-18 17:06   ` [PATCH v2] mmc: meson-gx: remove mmc host on device removal Michał Zegan
2017-02-28  3:09   ` Kevin Hilman
2017-02-28  3:09     ` Kevin Hilman
2017-03-14 16:21   ` Ulf Hansson
2017-03-14 16:21     ` Ulf Hansson
2017-02-28  3:08 ` [PATCH] mmc: meson-gx: fix error path when driver initialization fails before enabling clocks Kevin Hilman
2017-02-28  3:08   ` Kevin Hilman
2017-03-14 16:21 ` Ulf Hansson
2017-03-14 16:21   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170218170647.5860-2-webczat@webczatnet.pl \
    --to=webczat@webczatnet.pl \
    --cc=carlo@caione.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.