All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Jerome Anand <jerome.anand@intel.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: x86: hdmi: select CONFIG_SND_PCM
Date: Tue, 21 Feb 2017 23:02:37 +0100	[thread overview]
Message-ID: <20170221220255.242105-1-arnd@arndb.de> (raw)

The newly added driver uses the PCM helpers and fails to link if they are disabled:

sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend':
intel_hdmi_audio.c:(.text+0x15906): undefined reference to `snd_pcm_suspend'
sound/built-in.o: In function `had_pcm_hw_params':
intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to `snd_pcm_lib_malloc_pages'
sound/built-in.o: In function `had_pcm_open':
intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer'

This uses a Kconfig 'select' statement to make sure they are enabled.

Fixes: 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/x86/Kconfig b/sound/x86/Kconfig
index 30d066e4885e..84c8f8fc597c 100644
--- a/sound/x86/Kconfig
+++ b/sound/x86/Kconfig
@@ -9,6 +9,7 @@ if SND_X86
 config HDMI_LPE_AUDIO
 	tristate "HDMI audio without HDaudio on Intel Atom platforms"
 	depends on DRM_I915
+	select SND_PCM
 	help
 	 Choose this option to support HDMI LPE Audio mode
 
-- 
2.9.0

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Jerome Anand <jerome.anand@intel.com>
Subject: [PATCH] ALSA: x86: hdmi: select CONFIG_SND_PCM
Date: Tue, 21 Feb 2017 23:02:37 +0100	[thread overview]
Message-ID: <20170221220255.242105-1-arnd@arndb.de> (raw)

The newly added driver uses the PCM helpers and fails to link if they are disabled:

sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend':
intel_hdmi_audio.c:(.text+0x15906): undefined reference to `snd_pcm_suspend'
sound/built-in.o: In function `had_pcm_hw_params':
intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to `snd_pcm_lib_malloc_pages'
sound/built-in.o: In function `had_pcm_open':
intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer'

This uses a Kconfig 'select' statement to make sure they are enabled.

Fixes: 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/x86/Kconfig b/sound/x86/Kconfig
index 30d066e4885e..84c8f8fc597c 100644
--- a/sound/x86/Kconfig
+++ b/sound/x86/Kconfig
@@ -9,6 +9,7 @@ if SND_X86
 config HDMI_LPE_AUDIO
 	tristate "HDMI audio without HDaudio on Intel Atom platforms"
 	depends on DRM_I915
+	select SND_PCM
 	help
 	 Choose this option to support HDMI LPE Audio mode
 
-- 
2.9.0

             reply	other threads:[~2017-02-21 22:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 22:02 Arnd Bergmann [this message]
2017-02-21 22:02 ` [PATCH] ALSA: x86: hdmi: select CONFIG_SND_PCM Arnd Bergmann
2017-02-21 22:40 ` Takashi Iwai
2017-02-21 22:40   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170221220255.242105-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jerome.anand@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.