From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, kchamart@redhat.com, John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v2] qmp-shell: add persistent command history
Date: Fri, 3 Mar 2017 13:54:27 -0500 [thread overview]
Message-ID: <20170303185427.32681-1-jsnow@redhat.com> (raw)
Use the existing readline history function we are utilizing
to provide persistent command history across instances of qmp-shell.
This assists entering debug commands across sessions that may be
interrupted by QEMU sessions terminating, where the qmp-shell has
to be relaunched.
Signed-off-by: John Snow <jsnow@redhat.com>
---
v2: Adjusted the errors to whine about non-ENOENT errors, but still
intercept all errors as non-fatal.
Save history atexit() to match bash standard behavior
scripts/qmp/qmp-shell | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
index 0373b24..55a8285 100755
--- a/scripts/qmp/qmp-shell
+++ b/scripts/qmp/qmp-shell
@@ -70,6 +70,9 @@ import json
import ast
import readline
import sys
+import os
+import errno
+import atexit
class QMPCompleter(list):
def complete(self, text, state):
@@ -109,6 +112,7 @@ class QMPShell(qmp.QEMUMonitorProtocol):
self._pretty = pretty
self._transmode = False
self._actions = list()
+ self._histfile = os.path.join(os.path.expanduser('~'), '.qmp_history')
def __get_address(self, arg):
"""
@@ -137,6 +141,21 @@ class QMPShell(qmp.QEMUMonitorProtocol):
# XXX: default delimiters conflict with some command names (eg. query-),
# clearing everything as it doesn't seem to matter
readline.set_completer_delims('')
+ try:
+ readline.read_history_file(self._histfile)
+ except Exception as e:
+ if isinstance(e, IOError) and e.errno == errno.ENOENT:
+ # File not found. No problem.
+ pass
+ else:
+ print "Failed to read history '%s'; %s" % (self._histfile, e)
+ atexit.register(self.__save_history)
+
+ def __save_history(self):
+ try:
+ readline.write_history_file(self._histfile)
+ except Exception as e:
+ print "Failed to save history file '%s'; %s" % (self._histfile, e)
def __parse_value(self, val):
try:
--
2.9.3
next reply other threads:[~2017-03-03 18:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 18:54 John Snow [this message]
2017-03-03 19:26 ` [Qemu-devel] [PATCH v2] qmp-shell: add persistent command history Nir Soffer
2017-03-03 19:29 ` John Snow
2017-03-04 19:47 ` Nir Soffer
2017-03-06 8:18 ` Markus Armbruster
2017-03-06 11:22 ` Kashyap Chamarthy
2017-03-06 17:56 ` John Snow
2017-03-07 8:16 ` Markus Armbruster
2017-03-07 17:46 ` John Snow
2017-03-07 19:39 ` John Snow
2017-03-08 6:29 ` Markus Armbruster
2017-03-08 16:13 ` Nir Soffer
2017-03-13 6:04 ` Markus Armbruster
2017-03-19 22:54 ` Nir Soffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303185427.32681-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=kchamart@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.