From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
wei.liu2@citrix.com, ian.jackson@eu.citrix.com
Subject: [PATCH 01/16] tools: fix typo in tools/Rules.mk
Date: Wed, 8 Mar 2017 15:49:30 +0100 [thread overview]
Message-ID: <20170308144945.8934-2-jgross@suse.com> (raw)
In-Reply-To: <20170308144945.8934-1-jgross@suse.com>
Commit 78fb69ad9 ("tools/Rules.mk: Properly handle libraries with
recursive dependencies.") introduced a copy and paste error in
tools/Rules.mk:
LDLIBS_libxenstore and SHLIB_libxenstore don't use SHDEPS_libxenstore
but SHDEPS_libxenguest. This will add a superfluous dependency of
libxenstore on libxenevtchn.
Correct this bug.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/Rules.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/Rules.mk b/tools/Rules.mk
index e676c6b..835525a 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -139,8 +139,8 @@ SHLIB_libxenguest = $(SHDEPS_libxenguest) -Wl,-rpath-link=$(XEN_LIBXC)
CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude)
SHDEPS_libxenstore =
-LDLIBS_libxenstore = $(SHDEPS_libxenguest) $(XEN_XENSTORE)/libxenstore$(libextension)
-SHLIB_libxenstore = $(SHDEPS_libxenguest) -Wl,-rpath-link=$(XEN_XENSTORE)
+LDLIBS_libxenstore = $(SHDEPS_libxenstore) $(XEN_XENSTORE)/libxenstore$(libextension)
+SHLIB_libxenstore = $(SHDEPS_libxenstore) -Wl,-rpath-link=$(XEN_XENSTORE)
CFLAGS_libxenstat = -I$(XEN_LIBXENSTAT)
SHDEPS_libxenstat = $(SHLIB_libxenctrl) $(SHLIB_libxenstore)
--
2.10.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-08 14:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 14:49 [PATCH 00/16] tools: provide pkg-config files for all libs Juergen Gross
2017-03-08 14:49 ` Juergen Gross [this message]
2017-03-13 16:58 ` [PATCH 01/16] tools: fix typo in tools/Rules.mk Wei Liu
2017-03-08 14:49 ` [PATCH 02/16] tools: add missing library flag definitions Juergen Gross
2017-03-08 14:49 ` [PATCH 03/16] tools, stubdom: set PKG_CONFIG_DIR in main Makefiles Juergen Gross
2017-03-08 14:49 ` [PATCH 04/16] tools: add support for additional items in .pc files for local builds Juergen Gross
2017-03-08 14:49 ` [PATCH 05/16] tools: provide pkg-config file for libxentoollog Juergen Gross
2017-03-08 14:49 ` [PATCH 06/16] tools: provide pkg-config file for libxenevtchn Juergen Gross
2017-03-08 14:49 ` [PATCH 07/16] tools: provide pkg-config file for libxengnttab Juergen Gross
2017-03-08 14:49 ` [PATCH 08/16] tools: provide pkg-config file for libxencall Juergen Gross
2017-03-08 14:49 ` [PATCH 09/16] tools: provide pkg-config file for libxenforeignmemory Juergen Gross
2017-03-08 14:49 ` [PATCH 10/16] tools: provide pkg-config file for libxendevicemodel Juergen Gross
2017-03-08 14:49 ` [PATCH 11/16] tools: provide pkg-config file for libxenguest, update the one for libxenctrl Juergen Gross
2017-03-08 14:49 ` [PATCH 12/16] tools: provide pkg-config file for libxenstore Juergen Gross
2017-03-08 14:49 ` [PATCH 13/16] tools: provide pkg-config file for libxenstat Juergen Gross
2017-03-14 12:08 ` Wei Liu
2017-03-08 14:49 ` [PATCH 14/16] tools: provide pkg-config file for libxenvchan Juergen Gross
2017-03-08 14:49 ` [PATCH 15/16] tools: provide pkg-config file for libxenblktapctl Juergen Gross
2017-03-08 14:49 ` [PATCH 16/16] tools: adapt xenlight.pc and xlutil.pc to new pkg-config scheme Juergen Gross
2017-03-14 12:09 ` [PATCH 00/16] tools: provide pkg-config files for all libs Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308144945.8934-2-jgross@suse.com \
--to=jgross@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.