All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <takashi.sakamoto@miraclelinux.com>
To: broonie@kernel.org, kuninori.morimoto.gx@renesas.com,
	arnaud.pouliquen@st.com, weiyongjun1@huawei.com
Cc: ichiro.suzuki@miraclelinux.com, alsa-devel@alsa-project.org,
	Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	yukie.kato@miraclelinux.com
Subject: [PATCH v2] ASoC: hdmi-codec: fix non static symbol warnings
Date: Mon, 13 Mar 2017 11:26:18 +0900	[thread overview]
Message-ID: <20170313022618.21103-1-takashi.sakamoto@miraclelinux.com> (raw)

Fixes the following sparse warnings:

$ make C=2 sound/soc/codecs/hdmi-codec.o
sound/soc/codecs/hdmi-codec.c:34:1: warning:
 symbol 'hdmi_device_list' was not declared. Should it be static?
sound/soc/codecs/hdmi-codec.c:80:33: warning:
 symbol 'hdmi_codec_stereo_chmaps' was not declared. Should it be static?
sound/soc/codecs/hdmi-codec.c:87:33: warning:
 symbol 'hdmi_codec_8ch_chmaps' was not declared. Should it be static?
sound/soc/codecs/hdmi-codec.c:354:6: warning:
 symbol 'hdmi_codec_eld_chmap' was not declared. Should it be static?

Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Takashi Sakamoto <takashi.sakamoto@miraclelinux.com>
---
 sound/soc/codecs/hdmi-codec.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index 8c5ae1f..6ba6aa5 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -31,7 +31,7 @@ struct hdmi_device {
 	int cnt;
 };
 #define pos_to_hdmi_device(pos)	container_of((pos), struct hdmi_device, list)
-LIST_HEAD(hdmi_device_list);
+static LIST_HEAD(hdmi_device_list);
 static DEFINE_MUTEX(hdmi_mutex);
 
 #define DAI_NAME_SIZE 16
@@ -78,14 +78,14 @@ struct hdmi_codec_cea_spk_alloc {
 };
 
 /* Channel maps  stereo HDMI */
-const struct snd_pcm_chmap_elem hdmi_codec_stereo_chmaps[] = {
+static const struct snd_pcm_chmap_elem hdmi_codec_stereo_chmaps[] = {
 	{ .channels = 2,
 	  .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR } },
 	{ }
 };
 
 /* Channel maps for multi-channel playbacks, up to 8 n_ch */
-const struct snd_pcm_chmap_elem hdmi_codec_8ch_chmaps[] = {
+static const struct snd_pcm_chmap_elem hdmi_codec_8ch_chmaps[] = {
 	{ .channels = 2, /* CA_ID 0x00 */
 	  .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR } },
 	{ .channels = 4, /* CA_ID 0x01 */
@@ -352,7 +352,7 @@ static unsigned long hdmi_codec_spk_mask_from_alloc(int spk_alloc)
 	return spk_mask;
 }
 
-void hdmi_codec_eld_chmap(struct hdmi_codec_priv *hcp)
+static void hdmi_codec_eld_chmap(struct hdmi_codec_priv *hcp)
 {
 	u8 spk_alloc;
 	unsigned long spk_mask;
-- 
2.9.3

             reply	other threads:[~2017-03-13  2:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13  2:26 Takashi Sakamoto [this message]
2017-03-13 16:50 ` [PATCH v2] ASoC: hdmi-codec: fix non static symbol warnings Mark Brown
2017-03-14  4:01   ` Takashi Sakamoto
2017-03-14 19:46     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170313022618.21103-1-takashi.sakamoto@miraclelinux.com \
    --to=takashi.sakamoto@miraclelinux.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=broonie@kernel.org \
    --cc=ichiro.suzuki@miraclelinux.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=weiyongjun1@huawei.com \
    --cc=yukie.kato@miraclelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.