All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v2 01/13] xprtrdma: Cancel refresh worker during buffer shutdown
Date: Mon, 27 Mar 2017 10:05:43 -0400	[thread overview]
Message-ID: <20170327140543.20813.66981.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20170327134847.20813.52412.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>

Trying to create MRs while the transport is being torn down can
cause a crash.

Fixes: e2ac236c0b65 ("xprtrdma: Allocate MRs on demand")
Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 net/sunrpc/xprtrdma/verbs.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index 3b332b3..2e4fc1e 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -1037,6 +1037,7 @@ struct rpcrdma_rep *
 rpcrdma_buffer_destroy(struct rpcrdma_buffer *buf)
 {
 	cancel_delayed_work_sync(&buf->rb_recovery_worker);
+	cancel_delayed_work_sync(&buf->rb_refresh_worker);
 
 	while (!list_empty(&buf->rb_recv_bufs)) {
 		struct rpcrdma_rep *rep;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever <chuck.lever@oracle.com>
To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v2 01/13] xprtrdma: Cancel refresh worker during buffer shutdown
Date: Mon, 27 Mar 2017 10:05:43 -0400	[thread overview]
Message-ID: <20170327140543.20813.66981.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20170327134847.20813.52412.stgit@manet.1015granger.net>

Trying to create MRs while the transport is being torn down can
cause a crash.

Fixes: e2ac236c0b65 ("xprtrdma: Allocate MRs on demand")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 net/sunrpc/xprtrdma/verbs.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index 3b332b3..2e4fc1e 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -1037,6 +1037,7 @@ struct rpcrdma_rep *
 rpcrdma_buffer_destroy(struct rpcrdma_buffer *buf)
 {
 	cancel_delayed_work_sync(&buf->rb_recovery_worker);
+	cancel_delayed_work_sync(&buf->rb_refresh_worker);
 
 	while (!list_empty(&buf->rb_recv_bufs)) {
 		struct rpcrdma_rep *rep;


  parent reply	other threads:[~2017-03-27 14:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 14:05 [PATCH v2 00/13] NFS/RDMA client-side patches proposed for 4.12 Chuck Lever
2017-03-27 14:05 ` Chuck Lever
     [not found] ` <20170327134847.20813.52412.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-03-27 14:05   ` Chuck Lever [this message]
2017-03-27 14:05     ` [PATCH v2 01/13] xprtrdma: Cancel refresh worker during buffer shutdown Chuck Lever
2017-03-27 14:05   ` [PATCH v2 02/13] sunrpc: Export xprt_force_disconnect() Chuck Lever
2017-03-27 14:05     ` Chuck Lever
2017-03-27 14:05   ` [PATCH v2 03/13] xprtrdma: Detect unreachable NFS/RDMA servers more reliably Chuck Lever
2017-03-27 14:05     ` Chuck Lever
2017-03-27 14:06   ` [PATCH v2 04/13] xprtrdma: Refactor rpcrdma_ia_open() Chuck Lever
2017-03-27 14:06     ` Chuck Lever
2017-03-27 14:06   ` [PATCH v2 05/13] xprtrdma: Use same device when mapping or syncing DMA buffers Chuck Lever
2017-03-27 14:06     ` Chuck Lever
2017-03-27 14:06   ` [PATCH v2 06/13] xprtrdma: Support unplugging an HCA from under an NFS mount Chuck Lever
2017-03-27 14:06     ` Chuck Lever
2017-03-27 14:06   ` [PATCH v2 07/13] xprtrdma: Refactor rpcrdma_ep_connect Chuck Lever
2017-03-27 14:06     ` Chuck Lever
2017-03-27 14:06   ` [PATCH v2 08/13] xprtrdma: Restore transport after device removal Chuck Lever
2017-03-27 14:06     ` Chuck Lever
2017-03-27 14:06   ` [PATCH v2 09/13] xprtrdma: Revert commit d0f36c46deea Chuck Lever
2017-03-27 14:06     ` Chuck Lever
2017-03-27 14:06   ` [PATCH v2 10/13] xprtrdma: Annotate receive workqueue Chuck Lever
2017-03-27 14:06     ` Chuck Lever
2017-03-27 14:07   ` [PATCH v2 11/13] xprtrdma: Squelch ENOBUFS warnings Chuck Lever
2017-03-27 14:07     ` Chuck Lever
2017-03-27 14:07   ` [PATCH v2 12/13] sunrpc: Fix xdr_init_decode_pages() documenting comment Chuck Lever
2017-03-27 14:07     ` Chuck Lever
2017-03-27 14:07   ` [PATCH v2 13/13] xprtrdma: Remove rpcrdma_buffer::rb_pool Chuck Lever
2017-03-27 14:07     ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327140543.20813.66981.stgit@manet.1015granger.net \
    --to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.