From: Dan Carpenter <dan.carpenter@oracle.com> To: Daniel Vetter <daniel.vetter@intel.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com>, David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/i915: uninitialized value on error path Date: Thu, 13 Apr 2017 19:53:11 +0000 [thread overview] Message-ID: <20170413195311.GB26108@mwanda> (raw) "ret" isn't initialized on this error path. It doesn't really cause any problems unless it's randomly set to -EDEADLK which is not likely. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 48a546210d8b..d0e9578952d5 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9563,6 +9563,7 @@ int intel_get_load_detect_pipe(struct drm_connector *connector, */ if (!crtc) { DRM_DEBUG_KMS("no pipe available for load-detect\n"); + ret = -ENODEV; goto fail; }
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Daniel Vetter <daniel.vetter@intel.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com>, David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/i915: uninitialized value on error path Date: Thu, 13 Apr 2017 22:53:11 +0300 [thread overview] Message-ID: <20170413195311.GB26108@mwanda> (raw) "ret" isn't initialized on this error path. It doesn't really cause any problems unless it's randomly set to -EDEADLK which is not likely. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 48a546210d8b..d0e9578952d5 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9563,6 +9563,7 @@ int intel_get_load_detect_pipe(struct drm_connector *connector, */ if (!crtc) { DRM_DEBUG_KMS("no pipe available for load-detect\n"); + ret = -ENODEV; goto fail; }
next reply other threads:[~2017-04-13 19:53 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-13 19:53 Dan Carpenter [this message] 2017-04-13 19:53 ` [PATCH] drm/i915: uninitialized value on error path Dan Carpenter 2017-04-13 20:29 ` Chris Wilson 2017-04-13 20:29 ` Chris Wilson 2017-04-13 21:13 ` Dan Carpenter 2017-04-13 21:13 ` Dan Carpenter 2017-04-14 19:54 ` [PATCH v2] drm/i915: set "ret" correctly on error paths Dan Carpenter 2017-04-14 19:54 ` Dan Carpenter 2017-04-15 9:32 ` Chris Wilson 2017-04-15 9:32 ` Chris Wilson 2017-04-13 20:44 ` ✓ Fi.CI.BAT: success for drm/i915: uninitialized value on error path Patchwork 2017-04-14 20:13 ` ✓ Fi.CI.BAT: success for drm/i915: uninitialized value on error path (rev3) Patchwork 2017-04-17 10:53 ` Dan Carpenter 2017-04-18 7:58 ` Jani Nikula 2017-04-18 9:14 ` Dan Carpenter 2017-04-18 9:38 ` Jani Nikula 2017-04-18 10:35 ` Martin Peres
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170413195311.GB26108@mwanda \ --to=dan.carpenter@oracle.com \ --cc=airlied@linux.ie \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.