From: Bart Van Assche <bart.vanassche@sandisk.com> To: Jens Axboe <axboe@kernel.dk> Cc: <linux-block@vger.kernel.org>, Bart Van Assche <bart.vanassche@sandisk.com>, "Martin K . Petersen" <martin.petersen@oracle.com>, James Bottomley <James.Bottomley@HansenPartnership.com>, Omar Sandoval <osandov@fb.com>, Hannes Reinecke <hare@suse.com>, <linux-scsi@vger.kernel.org> Subject: [PATCH v2 8/8] scsi: Implement blk_mq_ops.show_rq() Date: Mon, 17 Apr 2017 09:56:51 -0700 [thread overview] Message-ID: <20170417165651.12693-9-bart.vanassche@sandisk.com> (raw) In-Reply-To: <20170417165651.12693-1-bart.vanassche@sandisk.com> Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Martin K. Petersen <martin.petersen@oracle.com> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: Omar Sandoval <osandov@fb.com> Cc: Hannes Reinecke <hare@suse.com> Cc: <linux-scsi@vger.kernel.org> --- drivers/scsi/scsi_lib.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 7bc4513bf4e4..52604573e4b6 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -2126,6 +2126,31 @@ static void scsi_exit_rq(struct request_queue *q, struct request *rq) scsi_free_sense_buffer(shost, cmd->sense_buffer); } +static const char *const ehflag_name[] = { + [ilog2(SCSI_EH_CANCEL_CMD)] = "CANCEL_CMD", + [ilog2(SCSI_EH_ABORT_SCHEDULED)] = "ABORT_SCHEDULED", +}; + +static void scsi_show_rq(struct seq_file *m, struct request *rq) +{ + struct scsi_cmnd *cmd = container_of(scsi_req(rq), typeof(*cmd), req); + unsigned int i; + + seq_puts(m, ", .cmd ="); + for (i = 0; i < cmd->cmd_len; i++) + seq_printf(m, " %02x", cmd->cmnd[i]); + seq_puts(m, ", .eh_eflags ="); + for (i = 0; i < sizeof(cmd->eh_eflags) * BITS_PER_BYTE; i++) { + if (!(cmd->eh_eflags & BIT(i))) + continue; + if (i < ARRAY_SIZE(ehflag_name) && ehflag_name[i]) + seq_printf(m, " %s", ehflag_name[i]); + else + seq_printf(m, " %d", i); + } + seq_printf(m, ", .result = %#06x", cmd->result); +} + struct request_queue *scsi_alloc_queue(struct scsi_device *sdev) { struct Scsi_Host *shost = sdev->host; @@ -2158,6 +2183,7 @@ static const struct blk_mq_ops scsi_mq_ops = { .queue_rq = scsi_queue_rq, .complete = scsi_softirq_done, .timeout = scsi_timeout, + .show_rq = scsi_show_rq, .init_request = scsi_init_request, .exit_request = scsi_exit_request, .map_queues = scsi_map_queues, -- 2.12.2
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche@sandisk.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Bart Van Assche <bart.vanassche@sandisk.com>, "Martin K . Petersen" <martin.petersen@oracle.com>, James Bottomley <James.Bottomley@HansenPartnership.com>, Omar Sandoval <osandov@fb.com>, Hannes Reinecke <hare@suse.com>, linux-scsi@vger.kernel.org Subject: [PATCH v2 8/8] scsi: Implement blk_mq_ops.show_rq() Date: Mon, 17 Apr 2017 09:56:51 -0700 [thread overview] Message-ID: <20170417165651.12693-9-bart.vanassche@sandisk.com> (raw) In-Reply-To: <20170417165651.12693-1-bart.vanassche@sandisk.com> Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Martin K. Petersen <martin.petersen@oracle.com> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: Omar Sandoval <osandov@fb.com> Cc: Hannes Reinecke <hare@suse.com> Cc: <linux-scsi@vger.kernel.org> --- drivers/scsi/scsi_lib.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 7bc4513bf4e4..52604573e4b6 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -2126,6 +2126,31 @@ static void scsi_exit_rq(struct request_queue *q, struct request *rq) scsi_free_sense_buffer(shost, cmd->sense_buffer); } +static const char *const ehflag_name[] = { + [ilog2(SCSI_EH_CANCEL_CMD)] = "CANCEL_CMD", + [ilog2(SCSI_EH_ABORT_SCHEDULED)] = "ABORT_SCHEDULED", +}; + +static void scsi_show_rq(struct seq_file *m, struct request *rq) +{ + struct scsi_cmnd *cmd = container_of(scsi_req(rq), typeof(*cmd), req); + unsigned int i; + + seq_puts(m, ", .cmd ="); + for (i = 0; i < cmd->cmd_len; i++) + seq_printf(m, " %02x", cmd->cmnd[i]); + seq_puts(m, ", .eh_eflags ="); + for (i = 0; i < sizeof(cmd->eh_eflags) * BITS_PER_BYTE; i++) { + if (!(cmd->eh_eflags & BIT(i))) + continue; + if (i < ARRAY_SIZE(ehflag_name) && ehflag_name[i]) + seq_printf(m, " %s", ehflag_name[i]); + else + seq_printf(m, " %d", i); + } + seq_printf(m, ", .result = %#06x", cmd->result); +} + struct request_queue *scsi_alloc_queue(struct scsi_device *sdev) { struct Scsi_Host *shost = sdev->host; @@ -2158,6 +2183,7 @@ static const struct blk_mq_ops scsi_mq_ops = { .queue_rq = scsi_queue_rq, .complete = scsi_softirq_done, .timeout = scsi_timeout, + .show_rq = scsi_show_rq, .init_request = scsi_init_request, .exit_request = scsi_exit_request, .map_queues = scsi_map_queues, -- 2.12.2
next prev parent reply other threads:[~2017-04-17 16:56 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-17 16:56 [PATCH v2 0/8] blk-mq debugfs patches for kernel v4.12 Bart Van Assche 2017-04-17 16:56 ` [PATCH v2 1/8] blk-mq: Register <dev>/queue/mq after having registered <dev>/queue Bart Van Assche 2017-04-17 16:56 ` [PATCH v2 2/8] blk-mq: Let blk_mq_debugfs_register() look up the queue name Bart Van Assche 2017-04-17 16:56 ` [PATCH v2 3/8] blk-mq: Unregister debugfs attributes earlier Bart Van Assche 2017-04-17 16:56 ` [PATCH v2 4/8] blk-mq: Move the "state" debugfs attribute one level down Bart Van Assche 2017-04-17 16:56 ` [PATCH v2 5/8] blk-mq: Make blk_flags_show() callers append a newline character Bart Van Assche 2017-04-17 16:56 ` [PATCH v2 6/8] blk-mq: Show operation, cmd_flags and rq_flags names Bart Van Assche 2017-04-17 16:56 ` [PATCH v2 7/8] blk-mq: Add blk_mq_ops.show_rq() Bart Van Assche 2017-04-17 16:56 ` Bart Van Assche [this message] 2017-04-17 16:56 ` [PATCH v2 8/8] scsi: Implement blk_mq_ops.show_rq() Bart Van Assche
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170417165651.12693-9-bart.vanassche@sandisk.com \ --to=bart.vanassche@sandisk.com \ --cc=James.Bottomley@HansenPartnership.com \ --cc=axboe@kernel.dk \ --cc=hare@suse.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=osandov@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.