From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Mika Westerberg <mika.westerberg@linux.intel.com>, alsa-devel@alsa-project.org, linux-input@vger.kernel.org, kvm@vger.kernel.org, devel@linuxdriverproject.org, linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org Cc: Tomas Winkler <tomas.winkler@intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v1 6/8] mei: Use recently introduced uuid_le_cmp_p{p}() helpers Date: Fri, 21 Apr 2017 17:46:43 +0300 [thread overview] Message-ID: <20170421144645.45189-6-andriy.shevchenko@linux.intel.com> (raw) In-Reply-To: <20170421144645.45189-1-andriy.shevchenko@linux.intel.com> Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/misc/mei/bus-fixup.c | 2 +- drivers/misc/mei/bus.c | 2 +- drivers/misc/mei/client.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index 0208c4b027c5..de0fcd98d162 100644 --- a/drivers/misc/mei/bus-fixup.c +++ b/drivers/misc/mei/bus-fixup.c @@ -416,7 +416,7 @@ void mei_cl_bus_dev_fixup(struct mei_cl_device *cldev) f = &mei_fixups[i]; if (uuid_le_cmp(f->uuid, MEI_UUID_ANY) == 0 || - uuid_le_cmp(f->uuid, *uuid) == 0) + uuid_le_cmp_p(uuid, f->uuid) == 0) f->hook(cldev); } } diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index d1928fdd0f43..e15549f71891 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -615,7 +615,7 @@ struct mei_cl_device_id *mei_cl_device_find(struct mei_cl_device *cldev, id = cldrv->id_table; while (uuid_le_cmp(NULL_UUID_LE, id->uuid)) { - if (!uuid_le_cmp(*uuid, id->uuid)) { + if (!uuid_le_cmp_p(uuid, id->uuid)) { match = true; if (cldev->name[0]) diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index be64969d986a..590accb369bd 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -148,7 +148,7 @@ static struct mei_me_client *__mei_me_cl_by_uuid(struct mei_device *dev, list_for_each_entry(me_cl, &dev->me_clients, list) { pn = &me_cl->props.protocol_name; - if (uuid_le_cmp(*uuid, *pn) == 0) + if (uuid_le_cmp_pp(uuid, pn) == 0) return mei_me_cl_get(me_cl); } @@ -228,7 +228,7 @@ static struct mei_me_client *__mei_me_cl_by_uuid_id(struct mei_device *dev, list_for_each_entry(me_cl, &dev->me_clients, list) { pn = &me_cl->props.protocol_name; - if (uuid_le_cmp(*uuid, *pn) == 0 && + if (uuid_le_cmp_pp(uuid, pn) == 0 && me_cl->client_id == client_id) return mei_me_cl_get(me_cl); } -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Mika Westerberg <mika.westerberg@linux.intel.com>, alsa-devel@alsa-project.org, linux-input@vger.kernel.org, kvm@vger.kernel.org, devel@linuxdriverproject.org, linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Tomas Winkler <tomas.winkler@intel.com> Subject: [PATCH v1 6/8] mei: Use recently introduced uuid_le_cmp_p{p}() helpers Date: Fri, 21 Apr 2017 17:46:43 +0300 [thread overview] Message-ID: <20170421144645.45189-6-andriy.shevchenko@linux.intel.com> (raw) In-Reply-To: <20170421144645.45189-1-andriy.shevchenko@linux.intel.com> Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/misc/mei/bus-fixup.c | 2 +- drivers/misc/mei/bus.c | 2 +- drivers/misc/mei/client.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index 0208c4b027c5..de0fcd98d162 100644 --- a/drivers/misc/mei/bus-fixup.c +++ b/drivers/misc/mei/bus-fixup.c @@ -416,7 +416,7 @@ void mei_cl_bus_dev_fixup(struct mei_cl_device *cldev) f = &mei_fixups[i]; if (uuid_le_cmp(f->uuid, MEI_UUID_ANY) == 0 || - uuid_le_cmp(f->uuid, *uuid) == 0) + uuid_le_cmp_p(uuid, f->uuid) == 0) f->hook(cldev); } } diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index d1928fdd0f43..e15549f71891 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -615,7 +615,7 @@ struct mei_cl_device_id *mei_cl_device_find(struct mei_cl_device *cldev, id = cldrv->id_table; while (uuid_le_cmp(NULL_UUID_LE, id->uuid)) { - if (!uuid_le_cmp(*uuid, id->uuid)) { + if (!uuid_le_cmp_p(uuid, id->uuid)) { match = true; if (cldev->name[0]) diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index be64969d986a..590accb369bd 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -148,7 +148,7 @@ static struct mei_me_client *__mei_me_cl_by_uuid(struct mei_device *dev, list_for_each_entry(me_cl, &dev->me_clients, list) { pn = &me_cl->props.protocol_name; - if (uuid_le_cmp(*uuid, *pn) == 0) + if (uuid_le_cmp_pp(uuid, pn) == 0) return mei_me_cl_get(me_cl); } @@ -228,7 +228,7 @@ static struct mei_me_client *__mei_me_cl_by_uuid_id(struct mei_device *dev, list_for_each_entry(me_cl, &dev->me_clients, list) { pn = &me_cl->props.protocol_name; - if (uuid_le_cmp(*uuid, *pn) == 0 && + if (uuid_le_cmp_pp(uuid, pn) == 0 && me_cl->client_id == client_id) return mei_me_cl_get(me_cl); } -- 2.11.0
next prev parent reply other threads:[~2017-04-21 14:46 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-21 14:46 [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers Andy Shevchenko 2017-04-21 14:46 ` Andy Shevchenko 2017-04-21 14:46 ` [PATCH v1 2/8] ASoC: Intel: Skylake: Use recently introduced uuid_le_cmp_p{p}() Andy Shevchenko 2017-04-21 14:46 ` Andy Shevchenko 2017-04-24 4:51 ` Vinod Koul 2017-04-24 8:50 ` Andy Shevchenko 2017-04-24 8:50 ` Andy Shevchenko 2017-04-21 14:46 ` [PATCH v1 3/8] HID: intel_ish-hid: " Andy Shevchenko 2017-04-21 14:46 ` Andy Shevchenko 2017-04-21 14:46 ` [PATCH v1 4/8] vfio-mdev: " Andy Shevchenko 2017-04-21 14:46 ` Andy Shevchenko 2017-04-21 14:46 ` [PATCH v1 5/8] vmbus: Use recently introduced uuid_le_cmp_p{p}() helpers Andy Shevchenko 2017-04-21 14:46 ` Andy Shevchenko 2017-04-21 14:46 ` Andy Shevchenko [this message] 2017-04-21 14:46 ` [PATCH v1 6/8] mei: " Andy Shevchenko 2017-04-21 14:46 ` [PATCH v1 7/8] efi: " Andy Shevchenko 2017-04-21 14:46 ` Andy Shevchenko 2017-04-21 14:46 ` [PATCH v1 8/8] ACPI: " Andy Shevchenko 2017-04-21 21:22 ` Rafael J. Wysocki [not found] ` <7721821.2dV0yqi2RQ-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org> 2017-04-27 12:46 ` Borislav Petkov 2017-04-27 12:46 ` Borislav Petkov [not found] ` <20170427124631.3fycg2jbs4ffhi45-fF5Pk5pvG8Y@public.gmane.org> 2017-04-27 13:09 ` Andy Shevchenko 2017-04-27 13:09 ` Andy Shevchenko 2017-04-27 15:00 ` Borislav Petkov 2017-04-23 10:29 ` [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers Winkler, Tomas 2017-04-23 12:42 ` Andy Shevchenko 2017-04-23 12:42 ` Andy Shevchenko 2017-04-23 12:42 ` Andy Shevchenko [not found] ` <CAHp75VeTgdE=OiRNS6JrH3M-rF+jpPVgmd4G+n321=vhVE4XiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-23 20:20 ` Winkler, Tomas 2017-04-23 20:20 ` Winkler, Tomas 2017-04-23 20:20 ` Winkler, Tomas [not found] ` <1492975128.3570.2.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2017-04-24 8:53 ` Andy Shevchenko 2017-04-24 8:53 ` Andy Shevchenko 2017-04-24 8:53 ` Andy Shevchenko [not found] ` <5B8DA87D05A7694D9FA63FD143655C1B543E8399-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> 2017-04-24 10:44 ` Lukas Wunner 2017-04-24 10:44 ` Lukas Wunner 2017-04-24 10:44 ` Lukas Wunner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170421144645.45189-6-andriy.shevchenko@linux.intel.com \ --to=andriy.shevchenko@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=alsa-devel@alsa-project.org \ --cc=arnd@arndb.de \ --cc=devel@linuxdriverproject.org \ --cc=kvm@vger.kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-efi@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mika.westerberg@linux.intel.com \ --cc=tomas.winkler@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.