All of lore.kernel.org
 help / color / mirror / Atom feed
From: damien.lemoal@wdc.com
To: linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Bart Van Assche <Bart.VanAssche@sandisk.com>,
	Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
	Bart Van Assche <bart.vanassche@sandisk.com>,
	Damien Le Moal <damien.lemoal@wdc.com>
Subject: [PATCH v2 6/7] sd_zbc: Remove superfluous assignments
Date: Mon, 24 Apr 2017 16:51:14 +0900	[thread overview]
Message-ID: <20170424075115.30337-7-damien.lemoal@wdc.com> (raw)
In-Reply-To: <20170424075115.30337-1-damien.lemoal@wdc.com>

From: Bart Van Assche <bart.vanassche@sandisk.com>

A value is assigned to the variable 'capacity' in sd_zbc_read_zones()
but that value is never used. Hence remove the variable 'capacity'.

[Damien: There is no need to initialize to 0 the variable 'ret'
in sd_zbc_read_zones()]

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
 drivers/scsi/sd_zbc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/sd_zbc.c b/drivers/scsi/sd_zbc.c
index a792682..29ba1d7 100644
--- a/drivers/scsi/sd_zbc.c
+++ b/drivers/scsi/sd_zbc.c
@@ -560,8 +560,7 @@ static int sd_zbc_setup(struct scsi_disk *sdkp)
 int sd_zbc_read_zones(struct scsi_disk *sdkp,
 		      unsigned char *buf)
 {
-	sector_t capacity;
-	int ret = 0;
+	int ret;
 
 	if (!sd_is_zoned(sdkp))
 		/*
@@ -593,7 +592,6 @@ int sd_zbc_read_zones(struct scsi_disk *sdkp,
 	ret = sd_zbc_check_capacity(sdkp, buf);
 	if (ret)
 		goto err;
-	capacity = logical_to_sectors(sdkp->device, sdkp->capacity);
 
 	/*
 	 * Check zone size: only devices with a constant zone size (except
-- 
2.9.3

  parent reply	other threads:[~2017-04-24  7:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  7:51 [PATCH v2 0/7] scsi: sd/sd_zbc cleanup and improvements damien.lemoal
2017-04-24  7:51 ` [PATCH v2 1/7] sd: Fix functions description damien.lemoal
2017-04-24 15:30   ` Christoph Hellwig
2017-04-24  7:51 ` [PATCH v2 2/7] sd: Improve sd_completed_bytes damien.lemoal
2017-04-24 15:31   ` Christoph Hellwig
2017-04-24  7:51 ` [PATCH v2 3/7] sd: Cleanup sd_done sense data handling damien.lemoal
2017-04-24 15:35   ` Christoph Hellwig
2017-04-24 23:11     ` Martin K. Petersen
2017-04-25  1:54       ` Damien Le Moal
2017-04-25 17:03         ` Martin K. Petersen
2017-04-24  7:51 ` [PATCH v2 4/7] scsi: Improve scsi_get_sense_info_fld damien.lemoal
2017-04-24 15:36   ` Christoph Hellwig
2017-04-24  7:51 ` [PATCH v2 5/7] sd_zbc: Rename sd_zbc_setup_write_cmnd damien.lemoal
2017-04-24 15:36   ` Christoph Hellwig
2017-04-24  7:51 ` damien.lemoal [this message]
2017-04-24 15:37   ` [PATCH v2 6/7] sd_zbc: Remove superfluous assignments Christoph Hellwig
2017-04-24  7:51 ` [PATCH v2 7/7] sd_zbc: Do not write lock zones for reset damien.lemoal
2017-04-24 15:38   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424075115.30337-7-damien.lemoal@wdc.com \
    --to=damien.lemoal@wdc.com \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.