From: Alan Jenkins <alan.christopher.jenkins@gmail.com>
To: selinux@tycho.nsa.gov
Cc: Alan Jenkins <alan.christopher.jenkins@gmail.com>
Subject: [PATCH 03/10] policycoreutils: fixfiles: syntax error
Date: Sun, 7 May 2017 12:05:49 +0100 [thread overview]
Message-ID: <20170507110556.7740-3-alan.christopher.jenkins@gmail.com> (raw)
In-Reply-To: <20170507110556.7740-1-alan.christopher.jenkins@gmail.com>
$ shellcheck fixfiles
...
In fixfiles line 94:
[[ "${i}" =~ "^[[:blank:]]*#" ]] && continue
^-- SC2076: Don't quote rhs of =~, it'll match
literally rather than as a regex.
---
policycoreutils/scripts/fixfiles | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/policycoreutils/scripts/fixfiles b/policycoreutils/scripts/fixfiles
index da79f47..29982e2 100755
--- a/policycoreutils/scripts/fixfiles
+++ b/policycoreutils/scripts/fixfiles
@@ -91,7 +91,7 @@ exclude_dirs_from_relabelling() {
# skip not absolute path
# skip not directory
[ -z "${i}" ] && continue
- [[ "${i}" =~ "^[[:blank:]]*#" ]] && continue
+ [[ "${i}" =~ ^[[:blank:]]*# ]] && continue
[[ ! "${i}" =~ ^/.* ]] && continue
[[ ! -d "${i}" ]] && continue
exclude_from_relabelling="$exclude_from_relabelling -e $i"
--
2.9.3
next prev parent reply other threads:[~2017-05-07 11:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 11:05 [PATCH 01/10] policycoreutils: fixfiles: tidy up usage(), manpage synopsis Alan Jenkins
2017-05-07 11:05 ` [PATCH 02/10] policycoreutils: fixfiles: remove two unused variables Alan Jenkins
2017-05-07 11:05 ` Alan Jenkins [this message]
2017-05-07 11:05 ` [PATCH 04/10] policycoreutils: fixfiles: usage errors are fatal Alan Jenkins
2017-05-07 11:05 ` [PATCH 05/10] policycoreutils: fixfiles: if restorecon aborts, we should too Alan Jenkins
2017-05-07 11:05 ` [PATCH 06/10] policycoreutils: fixfiles: refactor into the `set -u` dialect Alan Jenkins
2017-05-07 11:05 ` [PATCH 07/10] policycoreutils: fixfiles: un-document `-R -a` option Alan Jenkins
2017-05-07 11:05 ` [PATCH 08/10] policycoreutils: fixfiles: remove bad modes of "relabel" command Alan Jenkins
2017-05-07 11:05 ` [PATCH 09/10] policycoreutils: fixfiles: don't ignore `-F` when run in `-C` mode Alan Jenkins
2017-05-07 11:05 ` [PATCH 10/10] policycoreutils: fixfiles: use a consistent order for options to restorecon Alan Jenkins
2017-05-09 18:28 ` [PATCH 01/10] policycoreutils: fixfiles: tidy up usage(), manpage synopsis James Carter
2017-05-09 18:38 ` Alan Jenkins
2017-05-09 19:00 ` James Carter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170507110556.7740-3-alan.christopher.jenkins@gmail.com \
--to=alan.christopher.jenkins@gmail.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.