All of lore.kernel.org
 help / color / mirror / Atom feed
From: Puthikorn Voravootivat <puthik@chromium.org>
To: intel-gfx@lists.freedesktop.org,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH v7 1/9] drm/i915: Fix cap check for intel_dp_aux_backlight driver
Date: Thu, 11 May 2017 16:02:17 -0700	[thread overview]
Message-ID: <20170511230225.142870-2-puthik@chromium.org> (raw)
In-Reply-To: <20170511230225.142870-1-puthik@chromium.org>

intel_dp_aux_backlight driver should check for the
DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP before enable the driver.

Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
index 6532e226db29..341bf2cb0c25 100644
--- a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
@@ -144,6 +144,7 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)
 	 */
 	if (intel_dp->edp_dpcd[1] & DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP &&
 	    (intel_dp->edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_CAP) &&
+	    (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP) &&
 	    !((intel_dp->edp_dpcd[1] & DP_EDP_BACKLIGHT_PIN_ENABLE_CAP) ||
 	      (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_PWM_PIN_CAP))) {
 		DRM_DEBUG_KMS("AUX Backlight Control Supported!\n");
-- 
2.13.0.rc2.291.g57267f2277-goog

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-05-11 23:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11 23:02 [PATCH v7 0/9] Enhancement to intel_dp_aux_backlight driver Puthikorn Voravootivat
2017-05-11 23:02 ` Puthikorn Voravootivat [this message]
2017-05-11 23:02 ` [PATCH v7 2/9] drm/i915: Correctly enable backlight brightness adjustment via DPCD Puthikorn Voravootivat
2017-05-11 23:02 ` [PATCH v7 3/9] drm/i915: Drop AUX backlight enable check for backlight control Puthikorn Voravootivat
2017-05-12  5:00   ` Pandiyan, Dhinakaran
2017-05-12 13:14     ` Jani Nikula
2017-05-12 18:10       ` Puthikorn Voravootivat
2017-05-12 20:19         ` Pandiyan, Dhinakaran
2017-05-11 23:02 ` [PATCH v7 4/9] drm/i915: Allow choosing how to adjust brightness if both supported Puthikorn Voravootivat
2017-05-11 23:02 ` [PATCH v7 5/9] drm/i915: Set backlight mode before enable backlight Puthikorn Voravootivat
2017-05-11 23:02 ` [PATCH v7 6/9] drm/i915: Add option to support dynamic backlight via DPCD Puthikorn Voravootivat
2017-05-12  4:02   ` Pandiyan, Dhinakaran
2017-05-11 23:02 ` [PATCH v7 7/9] drm/i915: Restore brightness level in aux backlight driver Puthikorn Voravootivat
2017-05-11 23:02 ` [PATCH v7 8/9] drm: Add definition for eDP backlight frequency Puthikorn Voravootivat
2017-05-11 23:02 ` [PATCH v7 9/9] drm/i915: Set PWM divider to match desired frequency in vbt Puthikorn Voravootivat
2017-05-13  0:12   ` Pandiyan, Dhinakaran
2017-05-13  0:31     ` Puthikorn Voravootivat
2017-05-15 23:07       ` Pandiyan, Dhinakaran
2017-05-16  0:43         ` Puthikorn Voravootivat
2017-05-16  6:21           ` Pandiyan, Dhinakaran
2017-05-16 18:07             ` Puthikorn Voravootivat
2017-05-16 20:29               ` Pandiyan, Dhinakaran
2017-05-16 20:56                 ` Puthikorn Voravootivat
2017-05-16 21:21                   ` Pandiyan, Dhinakaran
2017-05-17  0:39                     ` Puthikorn Voravootivat
2017-05-17 18:31                       ` Pandiyan, Dhinakaran
2017-05-11 23:21 ` ✓ Fi.CI.BAT: success for Enhancement to intel_dp_aux_backlight driver (rev6) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170511230225.142870-2-puthik@chromium.org \
    --to=puthik@chromium.org \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.