All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>, dm-devel@redhat.com
Subject: [PATCH 5/7] Move the declaration of mpath_mx_alloc_len to a header file
Date: Wed, 17 May 2017 08:43:07 -0700	[thread overview]
Message-ID: <20170517154309.17787-6-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170517154309.17787-1-bart.vanassche@sandisk.com>

This allows the compiler to verify consistency of declaration and
definition.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
---
 libmpathpersist/mpath_persist.h | 3 +++
 mpathpersist/main.c             | 1 -
 multipathd/main.c               | 2 --
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/libmpathpersist/mpath_persist.h b/libmpathpersist/mpath_persist.h
index 79de5b5b..3faa8c9e 100644
--- a/libmpathpersist/mpath_persist.h
+++ b/libmpathpersist/mpath_persist.h
@@ -81,6 +81,9 @@ extern "C" {
 
 
 
+extern unsigned int mpath_mx_alloc_len;
+
+
 
 struct prin_readdescr
 {
diff --git a/mpathpersist/main.c b/mpathpersist/main.c
index 2e0aba3c..9de52b98 100644
--- a/mpathpersist/main.c
+++ b/mpathpersist/main.c
@@ -40,7 +40,6 @@ void mpath_print_transport_id(struct prin_fulldescr *fdesc);
 int construct_transportid(const char * inp, struct transportid transid[], int num_transportids);
 
 int logsink;
-unsigned int mpath_mx_alloc_len;
 struct config *multipath_conf;
 
 struct config *get_multipath_config(void)
diff --git a/multipathd/main.c b/multipathd/main.c
index b167cb4c..81c76cab 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -104,8 +104,6 @@ struct mpath_event_param
 	struct multipath *mpp;
 };
 
-unsigned int mpath_mx_alloc_len;
-
 int logsink;
 int verbosity;
 int bindings_read_only;
-- 
2.12.2

  parent reply	other threads:[~2017-05-17 15:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 15:43 [PATCH 0/7] Seven small multipath-tools patches Bart Van Assche
2017-05-17 15:43 ` [PATCH 1/7] Makefile: Remove assignments to unused variables Bart Van Assche
2017-05-17 15:43 ` [PATCH 2/7] libmultipath/configure.h: Add a forward declaration Bart Van Assche
2017-05-17 15:43 ` [PATCH 3/7] libmpathpersist: Add two missing #include directives Bart Van Assche
2017-05-17 15:43 ` [PATCH 4/7] Remove mpath_reverse_8bytes_order() Bart Van Assche
2017-05-17 15:43 ` Bart Van Assche [this message]
2017-05-18 20:06   ` [PATCH 5/7] Move the declaration of mpath_mx_alloc_len to a header file Benjamin Marzinski
2017-05-18 20:36     ` Bart Van Assche
2017-05-18 21:00       ` Benjamin Marzinski
2017-05-19 18:39         ` Bart Van Assche
2017-05-17 15:43 ` [PATCH 6/7] kpartx: Fix a compiler warning Bart Van Assche
2017-05-17 22:24   ` Christophe Varoqui
2017-05-17 15:43 ` [PATCH 7/7] Remove a superfluous "extern" keyword Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170517154309.17787-6-bart.vanassche@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.