All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	Mark Brown <broonie@kernel.org>,
	Bluecherry Maintainers <maintainers@bluecherrydvr.com>,
	linux-media@vger.kernel.org
Subject: [PATCH 04/16] ALSA: es1938: Convert to copy_silence ops
Date: Sun, 21 May 2017 22:09:38 +0200	[thread overview]
Message-ID: <20170521200950.4592-5-tiwai@suse.de> (raw)
In-Reply-To: <20170521200950.4592-1-tiwai@suse.de>

Replace the copy and the silence ops with the new merged ops.
It's used only for a capture stream (for some hardware workaround),
thus we need no silence operation but only to add the in_kernel
memcpy() handling.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/es1938.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/sound/pci/es1938.c b/sound/pci/es1938.c
index e8d943071a8c..d79ac13d6f70 100644
--- a/sound/pci/es1938.c
+++ b/sound/pci/es1938.c
@@ -842,7 +842,8 @@ static int snd_es1938_capture_copy(struct snd_pcm_substream *substream,
 				   int channel,
 				   snd_pcm_uframes_t pos,
 				   void __user *dst,
-				   snd_pcm_uframes_t count)
+				   snd_pcm_uframes_t count,
+				   bool in_kernel)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	struct es1938 *chip = snd_pcm_substream_chip(substream);
@@ -850,8 +851,10 @@ static int snd_es1938_capture_copy(struct snd_pcm_substream *substream,
 	count <<= chip->dma1_shift;
 	if (snd_BUG_ON(pos + count > chip->dma1_size))
 		return -EINVAL;
-	if (pos + count < chip->dma1_size) {
-		if (copy_to_user(dst, runtime->dma_area + pos + 1, count))
+	if (in_kernel || pos + count < chip->dma1_size) {
+		if (in_kernel)
+			memcpy((void *)dst, runtime->dma_area + pos + 1, count);
+		else if (copy_to_user(dst, runtime->dma_area + pos + 1, count))
 			return -EFAULT;
 	} else {
 		if (copy_to_user(dst, runtime->dma_area + pos + 1, count - 1))
@@ -1012,7 +1015,7 @@ static const struct snd_pcm_ops snd_es1938_capture_ops = {
 	.prepare =	snd_es1938_capture_prepare,
 	.trigger =	snd_es1938_capture_trigger,
 	.pointer =	snd_es1938_capture_pointer,
-	.copy =		snd_es1938_capture_copy,
+	.copy_silence =	snd_es1938_capture_copy,
 };
 
 static int snd_es1938_new_pcm(struct es1938 *chip, int device)
-- 
2.13.0

  parent reply	other threads:[~2017-05-21 20:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-21 20:09 [PATCH 00/16] ALSA: Convert to new copy_silence PCM ops Takashi Iwai
2017-05-21 20:09 ` [PATCH 01/16] ALSA: pcm: Introduce " Takashi Iwai
2017-05-21 20:09   ` Takashi Iwai
2017-05-21 20:09 ` [PATCH 02/16] ALSA: Update document about " Takashi Iwai
2017-05-21 20:09 ` [PATCH 03/16] ALSA: dummy: Convert to copy_silence ops Takashi Iwai
2017-05-21 20:09 ` Takashi Iwai [this message]
2017-05-21 20:09 ` [PATCH 05/16] ALSA: korg1212: " Takashi Iwai
2017-05-21 20:09 ` [PATCH 06/16] ALSA: nm256: " Takashi Iwai
2017-05-21 20:09 ` [PATCH 07/16] ALSA: rme32: " Takashi Iwai
2017-05-21 20:09 ` [PATCH 08/16] ALSA: rme96: " Takashi Iwai
2017-05-21 20:09 ` [PATCH 09/16] ALSA: rme9652: " Takashi Iwai
2017-05-21 20:09 ` [PATCH 10/16] ALSA: hdsp: " Takashi Iwai
2017-05-21 20:09 ` [PATCH 11/16] ALSA: gus: " Takashi Iwai
2017-05-21 20:09 ` [PATCH 12/16] ALSA: sb: " Takashi Iwai
2017-05-21 20:09 ` [PATCH 13/16] ALSA: sh: " Takashi Iwai
2017-05-21 20:09 ` [PATCH 14/16] ASoC: blackfin: " Takashi Iwai
2017-05-22  9:27   ` Mark Brown
2017-05-22  9:27     ` Mark Brown
2017-05-21 20:09 ` [PATCH 15/16] [media] solo6x10: " Takashi Iwai
2017-05-22  7:21   ` Hans Verkuil
2017-05-21 20:09 ` [PATCH 16/16] ALSA: pcm: Drop the old copy and silence ops Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170521200950.4592-5-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maintainers@bluecherrydvr.com \
    --cc=o-takashi@sakamocchi.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.