All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>, Christoph Hellwig <hch@lst.de>,
	"Bart Van Assche" <bart.vanassche@sandisk.com>,
	Jens Axboe <axboe@fb.com>, Omar Sandoval <osandov@fb.com>
Subject: [PATCH 02/19] block: Introduce queue flag QUEUE_FLAG_SCSI_PDU
Date: Thu, 25 May 2017 11:43:10 -0700	[thread overview]
Message-ID: <20170525184327.23570-3-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170525184327.23570-1-bart.vanassche@sandisk.com>

>From the context where a SCSI command is submitted it is not always
possible to figure out whether or not the queue the command is
submitted to has struct scsi_request as the first member of its
private data. Hence introduce the flag QUEUE_FLAG_SCSI_PDU.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cc: Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Omar Sandoval <osandov@fb.com>
---
 block/bsg-lib.c                   | 1 +
 drivers/block/cciss.c             | 1 +
 drivers/ide/ide-probe.c           | 1 +
 drivers/scsi/scsi_lib.c           | 2 ++
 drivers/scsi/scsi_transport_sas.c | 1 +
 include/linux/blkdev.h            | 2 ++
 6 files changed, 8 insertions(+)

diff --git a/block/bsg-lib.c b/block/bsg-lib.c
index 0a23dbba2d30..298710aa65a3 100644
--- a/block/bsg-lib.c
+++ b/block/bsg-lib.c
@@ -246,6 +246,7 @@ struct request_queue *bsg_setup_queue(struct device *dev, char *name,
 	q->bsg_job_size = dd_job_size;
 	q->bsg_job_fn = job_fn;
 	queue_flag_set_unlocked(QUEUE_FLAG_BIDI, q);
+	queue_flag_set_unlocked(QUEUE_FLAG_SCSI_PDU, q);
 	blk_queue_softirq_done(q, bsg_softirq_done);
 	blk_queue_rq_timeout(q, BLK_DEFAULT_SG_TIMEOUT);
 
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index cd375503f7b0..453d420a96dd 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1956,6 +1956,7 @@ static int cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
 	disk->queue->cmd_size = sizeof(struct scsi_request);
 	disk->queue->request_fn = do_cciss_request;
 	disk->queue->queue_lock = &h->lock;
+	queue_flag_set_unlocked(QUEUE_FLAG_SCSI_PDU, disk->queue);
 	if (blk_init_allocated_queue(disk->queue) < 0)
 		goto cleanup_queue;
 
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 023562565d11..a7cead2fd9ff 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -773,6 +773,7 @@ static int ide_init_queue(ide_drive_t *drive)
 	q->request_fn = do_ide_request;
 	q->init_rq_fn = ide_init_rq;
 	q->cmd_size = sizeof(struct ide_request);
+	queue_flag_set_unlocked(QUEUE_FLAG_SCSI_PDU, q);
 	if (blk_init_allocated_queue(q) < 0) {
 		blk_cleanup_queue(q);
 		return 1;
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 814a4bd8405d..48dd47e6bdf4 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -2056,6 +2056,8 @@ void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q)
 {
 	struct device *dev = shost->dma_dev;
 
+	queue_flag_set_unlocked(QUEUE_FLAG_SCSI_PDU, q);
+
 	/*
 	 * this limit is imposed by hardware restrictions
 	 */
diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
index 0ebe2f1bb908..f903004f3cad 100644
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
@@ -264,6 +264,7 @@ static int sas_bsg_initialize(struct Scsi_Host *shost, struct sas_rphy *rphy)
 		q->queuedata = shost;
 
 	queue_flag_set_unlocked(QUEUE_FLAG_BIDI, q);
+	queue_flag_set_unlocked(QUEUE_FLAG_SCSI_PDU, q);
 	return 0;
 
 out_cleanup_queue:
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index b5d1e27631ee..94fd2600584d 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -618,6 +618,7 @@ struct request_queue {
 #define QUEUE_FLAG_STATS       27	/* track rq completion times */
 #define QUEUE_FLAG_POLL_STATS  28	/* collecting stats for hybrid polling */
 #define QUEUE_FLAG_REGISTERED  29	/* queue has been registered to a disk */
+#define QUEUE_FLAG_SCSI_PDU    30	/* queue supports SCSI commands */
 
 #define QUEUE_FLAG_DEFAULT	((1 << QUEUE_FLAG_IO_STAT) |		\
 				 (1 << QUEUE_FLAG_STACKABLE)	|	\
@@ -708,6 +709,7 @@ static inline void queue_flag_clear(unsigned int flag, struct request_queue *q)
 #define blk_queue_secure_erase(q) \
 	(test_bit(QUEUE_FLAG_SECERASE, &(q)->queue_flags))
 #define blk_queue_dax(q)	test_bit(QUEUE_FLAG_DAX, &(q)->queue_flags)
+#define blk_queue_scsi_pdu(q)	test_bit(QUEUE_FLAG_SCSI_PDU, &(q)->queue_flags)
 
 #define blk_noretry_request(rq) \
 	((rq)->cmd_flags & (REQ_FAILFAST_DEV|REQ_FAILFAST_TRANSPORT| \
-- 
2.12.2

  parent reply	other threads:[~2017-05-25 18:43 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 18:43 [PATCH 00/19] Block layer patches for kernel v4.13 Bart Van Assche
2017-05-25 18:43 ` [PATCH 01/19] block: Avoid that blk_exit_rl() triggers a use-after-free Bart Van Assche
2017-05-26  6:01   ` Christoph Hellwig
2017-05-25 18:43 ` Bart Van Assche [this message]
2017-05-26  6:02   ` [PATCH 02/19] block: Introduce queue flag QUEUE_FLAG_SCSI_PDU Christoph Hellwig
2017-05-25 18:43 ` [PATCH 03/19] bsg: Check queue type before attaching to a queue Bart Van Assche
2017-05-26  6:02   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 04/19] pktcdvd: " Bart Van Assche
2017-05-26  6:03   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 05/19] cdrom: Check private request size " Bart Van Assche
2017-05-26  6:08   ` Christoph Hellwig
2017-05-26 15:50     ` Bart Van Assche
2017-05-28  8:32       ` hch
2017-05-25 18:43 ` [PATCH 06/19] nfsd: Check private request size before submitting a SCSI request Bart Van Assche
2017-05-25 18:48   ` J . Bruce Fields
2017-05-25 20:19     ` Bart Van Assche
2017-05-26  6:10       ` hch
2017-05-26 15:47         ` bfields
2017-05-26  6:10   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 07/19] scsi: Make scsi_ioctl_reset() pass the request queue pointer to blk_rq_init() Bart Van Assche
2017-05-25 18:43 ` [PATCH 08/19] block: Introduce request_queue.initialize_rq_fn() Bart Van Assche
2017-05-26  6:34   ` Christoph Hellwig
2017-05-26 23:56     ` Bart Van Assche
2017-05-28  8:34       ` hch
2017-05-28 16:12         ` Bart Van Assche
2017-05-28  8:37   ` Christoph Hellwig
2017-05-30 17:54     ` Bart Van Assche
2017-05-25 18:43 ` [PATCH 09/19] block: Make scsi_req_init() calls implicit Bart Van Assche
2017-05-28  8:38   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 10/19] blk-mq: Change blk_mq_hw_ctx.queue_rq_srcu into an array Bart Van Assche
2017-05-28  8:39   ` Christoph Hellwig
2017-05-28 16:36     ` Bart Van Assche
2017-05-25 18:43 ` [PATCH 11/19] blk-mq: Reduce blk_mq_hw_ctx size Bart Van Assche
2017-05-28  8:40   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 12/19] blk-mq: Initialize a request before assigning a tag Bart Van Assche
2017-05-28  8:42   ` Christoph Hellwig
2017-05-28 16:17     ` Bart Van Assche
2017-05-25 18:43 ` [PATCH 13/19] blk-mq: Fix the comment above blk_mq_quiesce_queue() Bart Van Assche
2017-05-28  8:42   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 14/19] block: Add a comment above queue_lockdep_assert_held() Bart Van Assche
2017-05-28  8:42   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 15/19] block: Check locking assumptions at runtime Bart Van Assche
2017-05-25 18:43 ` [PATCH 16/19] block: Document what queue type each function is intended for Bart Van Assche
2017-05-25 18:43 ` [PATCH 17/19] blk-mq: Document locking assumptions Bart Van Assche
2017-05-25 18:43 ` [PATCH 18/19] block: Constify disk_type Bart Van Assche
2017-05-28  8:43   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 19/19] block: Make request operation type argument declarations consistent Bart Van Assche
2017-05-28  8:43   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170525184327.23570-3-bart.vanassche@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.