All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: "Emilio G. Cota" <cota@braap.org>
Subject: [Qemu-devel] [PATCH v7 08/26] target/i386: introduce gen_jr helper to generate lookup_and_goto_ptr
Date: Fri, 26 May 2017 14:16:20 -0700	[thread overview]
Message-ID: <20170526211638.32301-9-rth@twiddle.net> (raw)
In-Reply-To: <20170526211638.32301-1-rth@twiddle.net>

From: "Emilio G. Cota" <cota@braap.org>

This helper will be used by subsequent changes.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Message-Id: <1493263764-18657-9-git-send-email-cota@braap.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target/i386/translate.c | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/target/i386/translate.c b/target/i386/translate.c
index 1d1372f..f0e48dc 100644
--- a/target/i386/translate.c
+++ b/target/i386/translate.c
@@ -141,6 +141,7 @@ typedef struct DisasContext {
 } DisasContext;
 
 static void gen_eob(DisasContext *s);
+static void gen_jr(DisasContext *s, TCGv dest);
 static void gen_jmp(DisasContext *s, target_ulong eip);
 static void gen_jmp_tb(DisasContext *s, target_ulong eip, int tb_num);
 static void gen_op(DisasContext *s1, int op, TCGMemOp ot, int d);
@@ -2509,7 +2510,8 @@ static void gen_bnd_jmp(DisasContext *s)
    If INHIBIT, set HF_INHIBIT_IRQ_MASK if it isn't already set.
    If RECHECK_TF, emit a rechecking helper for #DB, ignoring the state of
    S->TF.  This is used by the syscall/sysret insns.  */
-static void gen_eob_worker(DisasContext *s, bool inhibit, bool recheck_tf)
+static void
+do_gen_eob_worker(DisasContext *s, bool inhibit, bool recheck_tf, TCGv jr)
 {
     gen_update_cc_op(s);
 
@@ -2530,12 +2532,27 @@ static void gen_eob_worker(DisasContext *s, bool inhibit, bool recheck_tf)
         tcg_gen_exit_tb(0);
     } else if (s->tf) {
         gen_helper_single_step(cpu_env);
+    } else if (!TCGV_IS_UNUSED(jr)) {
+        TCGv vaddr = tcg_temp_new();
+
+        tcg_gen_add_tl(vaddr, jr, cpu_seg_base[R_CS]);
+        tcg_gen_lookup_and_goto_ptr(vaddr);
+        tcg_temp_free(vaddr);
     } else {
         tcg_gen_exit_tb(0);
     }
     s->is_jmp = DISAS_TB_JUMP;
 }
 
+static inline void
+gen_eob_worker(DisasContext *s, bool inhibit, bool recheck_tf)
+{
+    TCGv unused;
+
+    TCGV_UNUSED(unused);
+    do_gen_eob_worker(s, inhibit, recheck_tf, unused);
+}
+
 /* End of block.
    If INHIBIT, set HF_INHIBIT_IRQ_MASK if it isn't already set.  */
 static void gen_eob_inhibit_irq(DisasContext *s, bool inhibit)
@@ -2549,6 +2566,12 @@ static void gen_eob(DisasContext *s)
     gen_eob_worker(s, false, false);
 }
 
+/* Jump to register */
+static void gen_jr(DisasContext *s, TCGv dest)
+{
+    do_gen_eob_worker(s, false, false, dest);
+}
+
 /* generate a jump to eip. No segment change must happen before as a
    direct call to the next block may occur */
 static void gen_jmp_tb(DisasContext *s, target_ulong eip, int tb_num)
-- 
2.9.4

  parent reply	other threads:[~2017-05-26 21:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 21:16 [Qemu-devel] [PATCH v7 00/26] tcg cross-tb optimizations Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 01/26] target/nios2: Fix 64-bit ilp32 compilation Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 02/26] tcg/sparc: Use the proper compilation flags for 32-bit Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 03/26] qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 04/26] tcg: Introduce goto_ptr opcode and tcg_gen_lookup_and_goto_ptr Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 05/26] tcg/i386: implement goto_ptr Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 06/26] target/arm: optimize cross-page direct jumps in softmmu Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 07/26] target/arm: optimize indirect branches Richard Henderson
2017-05-26 21:16 ` Richard Henderson [this message]
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 09/26] target/i386: optimize cross-page direct jumps in softmmu Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 10/26] target/i386: optimize indirect branches Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 11/26] tb-hash: improve tb_jmp_cache hash function in user mode Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 12/26] tcg/ppc: Implement goto_ptr Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 13/26] tcg/aarch64: " Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 14/26] tcg/sparc: " Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 15/26] tcg/s390: " Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 16/26] tcg/arm: Clarify tcg_out_bx for arm4 host Richard Henderson
2017-05-27 16:41   ` Philippe Mathieu-Daudé
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 17/26] tcg/arm: Implement goto_ptr Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 19/26] target/s390: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 20/26] target/hppa: " Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 21/26] target/aarch64: optimize cross-page direct jumps in softmmu Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 22/26] target/aarch64: optimize indirect branches Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 23/26] target/mips: optimize cross-page direct jumps in softmmu Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 24/26] target/mips: optimize indirect branches Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 25/26] target/alpha: Implement WTINT inline Richard Henderson
2017-05-26 21:16 ` [Qemu-devel] [PATCH v7 26/26] target/alpha: Use goto_tb for fallthru between TBs Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170526211638.32301-9-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=cota@braap.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.