All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dupuis, Chad" <chad.dupuis@cavium.com>
To: martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com,
	QLogic-Storage-Upstream@cavium.com
Subject: [PATCH V2 11/15] qedf: Fixup unnecessary parantheses around test_bit operations.
Date: Wed, 31 May 2017 06:33:58 -0700	[thread overview]
Message-ID: <20170531133402.16629-12-chad.dupuis@cavium.com> (raw)
In-Reply-To: <20170531133402.16629-1-chad.dupuis@cavium.com>

Signed-off-by: Chad Dupuis <chad.dupuis@cavium.com>
---
 drivers/scsi/qedf/qedf_els.c | 6 +++---
 drivers/scsi/qedf/qedf_io.c  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c
index e197fd6..78d9f1c 100644
--- a/drivers/scsi/qedf/qedf_els.c
+++ b/drivers/scsi/qedf/qedf_els.c
@@ -44,7 +44,7 @@ static int qedf_initiate_els(struct qedf_rport *fcport, unsigned int op,
 		goto els_err;
 	}
 
-	if (!(test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags))) {
+	if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) {
 		QEDF_ERR(&(qedf->dbg_ctx), "els 0x%x: fcport not ready\n", op);
 		rc = -EINVAL;
 		goto els_err;
@@ -225,7 +225,7 @@ int qedf_send_rrq(struct qedf_ioreq *aborted_io_req)
 	fcport = aborted_io_req->fcport;
 
 	/* Check that fcport is still offloaded */
-	if (!(test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags))) {
+	if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) {
 		QEDF_ERR(NULL, "fcport is no longer offloaded.\n");
 		return -EINVAL;
 	}
@@ -550,7 +550,7 @@ static int qedf_send_srr(struct qedf_ioreq *orig_io_req, u32 offset, u8 r_ctl)
 	fcport = orig_io_req->fcport;
 
 	/* Check that fcport is still offloaded */
-	if (!(test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags))) {
+	if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) {
 		QEDF_ERR(NULL, "fcport is no longer offloaded.\n");
 		return -EINVAL;
 	}
diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
index db16004..ea37c78 100644
--- a/drivers/scsi/qedf/qedf_io.c
+++ b/drivers/scsi/qedf/qedf_io.c
@@ -1847,7 +1847,7 @@ static int qedf_execute_tmf(struct qedf_rport *fcport, struct scsi_cmnd *sc_cmd,
 		return FAILED;
 	}
 
-	if (!(test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags))) {
+	if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) {
 		QEDF_ERR(&(qedf->dbg_ctx), "fcport not offloaded\n");
 		rc = FAILED;
 		return FAILED;
-- 
1.8.5.6

  parent reply	other threads:[~2017-05-31 13:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 13:33 [PATCH V2 00/15] qedf: Update driver to version 8.18.22.0 Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 01/15] qedf: Enable basic FDMI information Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 02/15] qedf: Update copyright to 2017 Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 03/15] qedf: Honor qed_ops->common->set_fp_int() return code Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 04/15] qedf: Look at all descriptors when processing a clear virtual link Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 05/15] qedf: Check that fcport is offloaded before dereferencing pointers in initiate_abts|cleanup Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 06/15] qedf: Add fka_period SCSI host attribute to show fip keep alive period Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 07/15] qedf: Set qed logging level to QED_LEVEL_NOTICE Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 08/15] qedf: Use same logic for SCSI host reset and FC lip_reset Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 09/15] qedf: Add bus_reset No-op Dupuis, Chad
2017-05-31 13:33 ` [PATCH V2 10/15] qedf: Add non-offload receive filters Dupuis, Chad
2017-05-31 13:33 ` Dupuis, Chad [this message]
2017-05-31 13:33 ` [PATCH V2 12/15] qedf: Move some prints to a debug level so they do not print when no debugging is enabled Dupuis, Chad
2017-05-31 13:34 ` [PATCH V2 13/15] qedf: Change cmd_per_lun in scsi_host_template to 32 to increase performance Dupuis, Chad
2017-05-31 13:34 ` [PATCH V2 14/15] qedf: Add change_queue_depth member to scsi_host_template() Dupuis, Chad
2017-05-31 13:34 ` [PATCH V2 15/15] qedf: Update version number to 8.18.22.0 Dupuis, Chad
2017-06-03  0:37 ` [PATCH V2 00/15] qedf: Update driver to version 8.18.22.0 Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531133402.16629-12-chad.dupuis@cavium.com \
    --to=chad.dupuis@cavium.com \
    --cc=QLogic-Storage-Upstream@cavium.com \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.