From: Andi Shyti <andi.shyti@samsung.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jaechul Lee <jcsing.lee@samsung.com>,
Beomho Seo <beomho.seo@samsung.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi.shyti@samsung.com>,
Andi Shyti <andi@etezian.org>
Subject: [PATCH v2] Input: tm2-touchkey - use LEN_ON as boolean value instead of LED_FULL
Date: Thu, 01 Jun 2017 10:47:36 +0900 [thread overview]
Message-ID: <20170601014736.17808-1-andi.shyti@samsung.com> (raw)
In-Reply-To: CGME20170601014820epcas1p24563493660adc23d437c55453aa7a655@epcas1p2.samsung.com
Commit 4e552c8cb5bc ("leds: add LED_ON brightness as boolean value")
has introduced the LED_ON enumeration value that can be used
instead of LED_FULL which has more of a linear value.
Because the tm2-touchscreen doesn't have brightness levels, but
it's a simple on/off led, use LED_ON instead of LED_FULL.
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Reviewed-by: Jaechul Lee <jcsing.lee@samsung.com>
Tested-by: Jaechul Lee <jcsing.lee@samsung.com>
---
Hi Dmitry,
this is the second version of this simple patch sent here:
https://marc.info/?l=linux-kernel&m=149062143701658&w=2
no changes, just added Jaechul's review and test.
Andi
drivers/input/keyboard/tm2-touchkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c
index 485900f953e0..abc266e40e17 100644
--- a/drivers/input/keyboard/tm2-touchkey.c
+++ b/drivers/input/keyboard/tm2-touchkey.c
@@ -213,7 +213,7 @@ static int tm2_touchkey_probe(struct i2c_client *client,
/* led device */
touchkey->led_dev.name = TM2_TOUCHKEY_DEV_NAME;
touchkey->led_dev.brightness = LED_FULL;
- touchkey->led_dev.max_brightness = LED_FULL;
+ touchkey->led_dev.max_brightness = LED_ON;
touchkey->led_dev.brightness_set = tm2_touchkey_led_brightness_set;
error = devm_led_classdev_register(&client->dev, &touchkey->led_dev);
--
2.11.0
next parent reply other threads:[~2017-06-01 1:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170601014820epcas1p24563493660adc23d437c55453aa7a655@epcas1p2.samsung.com>
2017-06-01 1:47 ` Andi Shyti [this message]
2017-06-02 5:07 ` [PATCH v2] Input: tm2-touchkey - use LEN_ON as boolean value instead of LED_FULL Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601014736.17808-1-andi.shyti@samsung.com \
--to=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=beomho.seo@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jcsing.lee@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.