From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 04/10] tcg/aarch64: Use ADR in tcg_out_movi
Date: Tue, 13 Jun 2017 22:23:05 -0700 [thread overview]
Message-ID: <20170614052311.13785-5-rth@twiddle.net> (raw)
In-Reply-To: <20170614052311.13785-1-rth@twiddle.net>
The new placement of the TB means that we can use one insn
to load the return value for exit_tb returning the TB pointer.
Tested-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
tcg/aarch64/tcg-target.inc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c
index 5f18545..1fa3bcc 100644
--- a/tcg/aarch64/tcg-target.inc.c
+++ b/tcg/aarch64/tcg-target.inc.c
@@ -616,7 +616,12 @@ static void tcg_out_movi(TCGContext *s, TCGType type, TCGReg rd,
/* Look for host pointer values within 4G of the PC. This happens
often when loading pointers to QEMU's own data structures. */
if (type == TCG_TYPE_I64) {
- tcg_target_long disp = (value >> 12) - ((intptr_t)s->code_ptr >> 12);
+ tcg_target_long disp = value - (intptr_t)s->code_ptr;
+ if (disp == sextract64(disp, 0, 21)) {
+ tcg_out_insn(s, 3406, ADR, rd, disp);
+ return;
+ }
+ disp = (value >> 12) - ((intptr_t)s->code_ptr >> 12);
if (disp == sextract64(disp, 0, 21)) {
tcg_out_insn(s, 3406, ADRP, rd, disp);
if (value & 0xfff) {
--
2.9.4
next prev parent reply other threads:[~2017-06-14 5:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 5:23 [Qemu-devel] [PULL 00/10] TCG queued patches Richard Henderson
2017-06-14 5:23 ` [Qemu-devel] [PULL 01/10] util: add cacheinfo Richard Henderson
2017-06-14 5:23 ` [Qemu-devel] [PULL 02/10] tcg: allocate TB structs before the corresponding translated code Richard Henderson
2017-06-14 5:23 ` [Qemu-devel] [PULL 03/10] translate-all: consolidate tb init in tb_gen_code Richard Henderson
2017-06-14 5:23 ` Richard Henderson [this message]
2017-06-14 5:23 ` [Qemu-devel] [PULL 05/10] tcg/arm: Use indirect branch for goto_tb Richard Henderson
2017-06-14 5:23 ` [Qemu-devel] [PULL 06/10] tcg/arm: Remove limit on code buffer size Richard Henderson
2017-06-14 5:23 ` [Qemu-devel] [PULL 07/10] tcg/arm: Try pc-relative addresses for movi Richard Henderson
2017-06-14 5:23 ` [Qemu-devel] [PULL 08/10] tcg/arm: Use ldr (literal) for goto_tb Richard Henderson
2017-06-14 5:23 ` [Qemu-devel] [PULL 09/10] Revert "target/aarch64: optimize indirect branches" Richard Henderson
2017-06-14 14:27 ` Philippe Mathieu-Daudé
2017-06-14 5:23 ` [Qemu-devel] [PULL 10/10] tcg: Remove tb_htable_lookup from helper_lookup_tb_ptr Richard Henderson
2017-06-14 5:42 ` [Qemu-devel] [PULL 00/10] TCG queued patches no-reply
2017-06-14 5:43 ` no-reply
2017-06-14 15:23 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614052311.13785-5-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.