From: Jeff Layton <jlayton@redhat.com> To: Andrew Morton <akpm@linux-foundation.org>, Al Viro <viro@ZenIV.linux.org.uk>, Jan Kara <jack@suse.cz>, tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>, David Sterba <dsterba@suse.com>, "Darrick J . Wong" <darrick.wong@oracle.com> Cc: Carlos Maiolino <cmaiolino@redhat.com>, Eryu Guan <eguan@redhat.com>, David Howells <dhowells@redhat.com>, Christoph Hellwig <hch@infradead.org>, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org Subject: [xfstests PATCH v5 1/5] ext4: allow ext4 to use $SCRATCH_LOGDEV Date: Fri, 16 Jun 2017 15:36:15 -0400 [thread overview] Message-ID: <20170616193619.14576-2-jlayton@redhat.com> (raw) In-Reply-To: <20170616193619.14576-1-jlayton@redhat.com> The writeback error handling test requires that you put the journal on a separate device. This allows us to use dmerror to simulate data writeback failure, without affecting the journal. xfs already has infrastructure for this (a'la $SCRATCH_LOGDEV), so wire up the ext4 code so that it can do the same thing when _scratch_mkfs is called. Signed-off-by: Jeff Layton <jlayton@redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --- common/rc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/rc b/common/rc index ff1b75c9cd25..57001b47a8b7 100644 --- a/common/rc +++ b/common/rc @@ -679,6 +679,9 @@ _scratch_mkfs_ext4() local tmp=`mktemp` local mkfs_status + [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \ + $mkfs_cmd -O journal_dev $MKFS_OPTIONS $SCRATCH_LOGDEV && \ + mkfs_cmd="$mkfs_cmd -J device=$SCRATCH_LOGDEV" _scratch_do_mkfs "$mkfs_cmd" "$mkfs_filter" $* 2>$tmp.mkfserr 1>$tmp.mkfsstd mkfs_status=$? -- 2.13.0
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@redhat.com> To: Andrew Morton <akpm@linux-foundation.org>, Al Viro <viro@ZenIV.linux.org.uk>, Jan Kara <jack@suse.cz>, tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>, David Sterba <dsterba@suse.com>, "Darrick J . Wong" <darrick.wong@oracle.com> Cc: Carlos Maiolino <cmaiolino@redhat.com>, Eryu Guan <eguan@redhat.com>, David Howells <dhowells@redhat.com>, Christoph Hellwig <hch@infradead.org>, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org Subject: [xfstests PATCH v5 1/5] ext4: allow ext4 to use $SCRATCH_LOGDEV Date: Fri, 16 Jun 2017 15:36:15 -0400 [thread overview] Message-ID: <20170616193619.14576-2-jlayton@redhat.com> (raw) In-Reply-To: <20170616193619.14576-1-jlayton@redhat.com> The writeback error handling test requires that you put the journal on a separate device. This allows us to use dmerror to simulate data writeback failure, without affecting the journal. xfs already has infrastructure for this (a'la $SCRATCH_LOGDEV), so wire up the ext4 code so that it can do the same thing when _scratch_mkfs is called. Signed-off-by: Jeff Layton <jlayton@redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --- common/rc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/rc b/common/rc index ff1b75c9cd25..57001b47a8b7 100644 --- a/common/rc +++ b/common/rc @@ -679,6 +679,9 @@ _scratch_mkfs_ext4() local tmp=`mktemp` local mkfs_status + [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \ + $mkfs_cmd -O journal_dev $MKFS_OPTIONS $SCRATCH_LOGDEV && \ + mkfs_cmd="$mkfs_cmd -J device=$SCRATCH_LOGDEV" _scratch_do_mkfs "$mkfs_cmd" "$mkfs_filter" $* 2>$tmp.mkfserr 1>$tmp.mkfsstd mkfs_status=$? -- 2.13.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-16 19:36 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-16 19:36 [xfstests PATCH v5 0/5] new tests for writeback error reporting behavior Jeff Layton 2017-06-16 19:36 ` Jeff Layton 2017-06-16 19:36 ` Jeff Layton [this message] 2017-06-16 19:36 ` [xfstests PATCH v5 1/5] ext4: allow ext4 to use $SCRATCH_LOGDEV Jeff Layton 2017-06-16 19:36 ` [xfstests PATCH v5 2/5] ext3: allow it to put journal on a separate device when doing scratch_mkfs Jeff Layton 2017-06-16 19:36 ` Jeff Layton 2017-06-16 19:36 ` [xfstests PATCH v5 3/5] generic: add a writeback error handling test Jeff Layton 2017-06-16 19:36 ` Jeff Layton 2017-06-16 19:36 ` [xfstests PATCH v5 4/5] generic: test writeback error handling on dmerror devices Jeff Layton 2017-06-16 19:36 ` Jeff Layton 2017-06-16 19:36 ` [xfstests PATCH v5 5/5] btrfs: make a btrfs version of writeback error reporting test Jeff Layton 2017-06-16 19:36 ` Jeff Layton 2017-06-16 19:40 [xfstests PATCH v5 0/5] new tests for writeback error reporting behavior Jeff Layton 2017-06-16 19:40 ` [xfstests PATCH v5 1/5] ext4: allow ext4 to use $SCRATCH_LOGDEV Jeff Layton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170616193619.14576-2-jlayton@redhat.com \ --to=jlayton@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=axboe@kernel.dk \ --cc=clm@fb.com \ --cc=cmaiolino@redhat.com \ --cc=corbet@lwn.net \ --cc=darrick.wong@oracle.com \ --cc=dhowells@redhat.com \ --cc=dsterba@suse.com \ --cc=eguan@redhat.com \ --cc=hch@infradead.org \ --cc=jack@suse.cz \ --cc=jbacik@fb.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-xfs@vger.kernel.org \ --cc=mawilcox@microsoft.com \ --cc=ross.zwisler@linux.intel.com \ --cc=tytso@mit.edu \ --cc=viro@ZenIV.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.