All of lore.kernel.org
 help / color / mirror / Atom feed
From: Praveen Kumar <kpraveen.lkml@gmail.com>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
	George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
	tim@xen.org, kpraveen.lkml@gmail.com, jbeulich@suse.com
Subject: [PATCH 20/20] lib/rbtree.c: fix typo in comment of __rb_insert()
Date: Sat, 17 Jun 2017 15:02:53 +0530	[thread overview]
Message-ID: <20170617093253.3990-21-kpraveen.lkml@gmail.com> (raw)
In-Reply-To: <20170617093253.3990-1-kpraveen.lkml@gmail.com>

In case 1, it passes down the BLACK color from G to p and u, and maintains
the color of n.  By doing so, it maintains the black height of the sub-tree.

While in the comment, it marks the color of n to BLACK.  This is a typo
and not consistents with the code.

This patch fixs this typo in comment.

Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
Acked-by: Michel Lespinasse <walken@google.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[Linux commit 1b9c53e849aa65776d4f611d99aa09f856518dad]

Ported to Xen for rb_insert_color API.

Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
---
 xen/common/rbtree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/rbtree.c b/xen/common/rbtree.c
index 68e505bede..4fe5354785 100644
--- a/xen/common/rbtree.c
+++ b/xen/common/rbtree.c
@@ -138,7 +138,7 @@ void rb_insert_color(struct rb_node *node, struct rb_root *root)
                  *      / \          / \
                  *     p   u  -->   P   U
                  *    /            /
-                 *   n            N
+                 *   n            n
                  *
                  * However, since g's parent might be red, and
                  * 4) does not allow this, we need to recurse
-- 
2.12.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      parent reply	other threads:[~2017-06-17  9:32 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-17  9:32 [PATCH v3] xen: common: rbtree: ported updates from Praveen Kumar
2017-06-17  9:32 ` [PATCH 01/20] rbtree: add const qualifier to some functions Praveen Kumar
2017-06-19 13:49   ` Jan Beulich
2017-06-19 14:09     ` Praveen Kumar
2017-06-19 14:47       ` Jan Beulich
2017-06-19 16:39   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH 02/20] lib/rbtree.c: optimize rb_erase() Praveen Kumar
2017-06-19 16:41   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 03/20] rb_tree: reorganize code in rb_erase() for additional changes Praveen Kumar
2017-06-19 16:45   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 04/20] rb_tree: make clear distinction between two different cases in rb_erase() Praveen Kumar
2017-06-19 16:47   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 05/20] rb_tree: remove redundant if()-condition " Praveen Kumar
2017-06-19 16:53   ` Dario Faggioli
2017-06-20  7:23     ` Jan Beulich
2017-06-17  9:32 ` [PATCH v2 06/20] rbtree: empty nodes have no color Praveen Kumar
2017-06-19 17:00   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 07/20] rbtree: move some implementation details from rbtree.h to rbtree.c Praveen Kumar
2017-06-19 17:05   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 08/20] rbtree: break out of rb_insert_color loop after tree rotation Praveen Kumar
2017-06-19 17:10   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 09/20] rbtree: adjust root color in rb_insert_color() only when necessary Praveen Kumar
2017-06-19 17:13   ` Dario Faggioli
2017-06-20  7:26     ` Jan Beulich
2017-06-20 13:54       ` Dario Faggioli
2017-06-27 15:35         ` Praveen Kumar
2017-06-27 15:48           ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 10/20] rbtree: low level optimizations in rb_insert_color() Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 11/20] rbtree: adjust node color in __rb_erase_color() only when necessary Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 12/20] rbtree: optimize case selection logic in __rb_erase_color() Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 13/20] rbtree: low level optimizations " Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 14/20] rbtree: coding style adjustments Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 15/20] rbtree: optimize fetching of sibling node Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 16/20] rbtree: add __rb_change_child() helper function Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 17/20] rbtree: place easiest case first in rb_erase() Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 18/20] rbtree: handle 1-child recoloring in rb_erase() instead of rb_erase_color() Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 19/20] rbtree: low level optimizations in rb_erase() Praveen Kumar
2017-06-17  9:32 ` Praveen Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170617093253.3990-21-kpraveen.lkml@gmail.com \
    --to=kpraveen.lkml@gmail.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.