From: Colin King <colin.king@canonical.com> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Julia Lawall <Julia.Lawall@lip6.fr>, alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] ASoC: rsnd: make main_rate signed to check for -ve error return codes Date: Mon, 19 Jun 2017 17:35:23 +0100 [thread overview] Message-ID: <20170619163523.2208-1-colin.king@canonical.com> (raw) From: Colin Ian King <colin.king@canonical.com> The comparison of main_rate < 0 has no effect because main_rate is an unsigned int. Make it signed so that any -ve error returns from the call to rsnd_clk_query can be detected. Detected by CoverityScan, CID#1446152 ("Unsigned compared against 0") Fixes: ef4cf5d6a143e0 ("ASoC: rsnd: add rsnd_ssi_clk_query()") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- sound/soc/sh/rcar/ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index c8956c3484dd..d220512918f9 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -258,7 +258,7 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod, struct rsnd_mod *ssi_parent_mod = rsnd_io_to_mod_ssip(io); int chan = rsnd_runtime_channel_for_ssi(io); int idx, ret; - unsigned int main_rate; + int main_rate; unsigned int rate = rsnd_io_is_play(io) ? rsnd_src_get_out_rate(priv, io) : rsnd_src_get_in_rate(priv, io); -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Colin King <colin.king@canonical.com> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Julia Lawall <Julia.Lawall@lip6.fr>, alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] ASoC: rsnd: make main_rate signed to check for -ve error return codes Date: Mon, 19 Jun 2017 16:35:23 +0000 [thread overview] Message-ID: <20170619163523.2208-1-colin.king@canonical.com> (raw) From: Colin Ian King <colin.king@canonical.com> The comparison of main_rate < 0 has no effect because main_rate is an unsigned int. Make it signed so that any -ve error returns from the call to rsnd_clk_query can be detected. Detected by CoverityScan, CID#1446152 ("Unsigned compared against 0") Fixes: ef4cf5d6a143e0 ("ASoC: rsnd: add rsnd_ssi_clk_query()") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- sound/soc/sh/rcar/ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index c8956c3484dd..d220512918f9 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -258,7 +258,7 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod, struct rsnd_mod *ssi_parent_mod = rsnd_io_to_mod_ssip(io); int chan = rsnd_runtime_channel_for_ssi(io); int idx, ret; - unsigned int main_rate; + int main_rate; unsigned int rate = rsnd_io_is_play(io) ? rsnd_src_get_out_rate(priv, io) : rsnd_src_get_in_rate(priv, io); -- 2.11.0
next reply other threads:[~2017-06-19 16:36 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-19 16:35 Colin King [this message] 2017-06-19 16:35 ` [PATCH][next] ASoC: rsnd: make main_rate signed to check for -ve error return codes Colin King 2017-06-20 0:01 ` Kuninori Morimoto 2017-06-20 0:01 ` Kuninori Morimoto
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170619163523.2208-1-colin.king@canonical.com \ --to=colin.king@canonical.com \ --cc=Julia.Lawall@lip6.fr \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.