All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Xinliang Liu <z.liuxinliang@hisilicon.com>,
	Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	Chen Feng <puck.chen@hisilicon.com>,
	Rongrong Zou <zourongrong@gmail.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 02/13] drm/hibmc: Drop drm_vblank_cleanup
Date: Wed, 21 Jun 2017 10:28:39 +0200	[thread overview]
Message-ID: <20170621082850.13224-3-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20170621082850.13224-1-daniel.vetter@ffwll.ch>

So this seems to be the first driver that does it the right way round,
so fix it up by calling drm_atomic_helper_shutdown instead. We need to
do that before the last kms user is gone (fbdev emulation), but before
we start shutting down hw stuff like interrupts.

Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index 2ffdbf9801bd..4d018ca98581 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -276,11 +276,12 @@ static int hibmc_unload(struct drm_device *dev)
 
 	hibmc_fbdev_fini(priv);
 
+	drm_atomic_helper_shutdown(dev);
+
 	if (dev->irq_enabled)
 		drm_irq_uninstall(dev);
 	if (priv->msi_enabled)
 		pci_disable_msi(dev->pdev);
-	drm_vblank_cleanup(dev);
 
 	hibmc_kms_fini(priv);
 	hibmc_mm_fini(priv);
-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-06-21  8:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  8:28 [PATCH 00/13] RESEND: remove drm_vblank_cleanup from drivers Daniel Vetter
2017-06-21  8:28 ` [PATCH 01/13] drm/amd|radeon: Drop drm_vblank_cleanup Daniel Vetter
2017-06-22 12:54   ` Alex Deucher
2017-06-23  8:41     ` Daniel Vetter
2017-06-21  8:28 ` Daniel Vetter [this message]
2017-06-21  8:28 ` [PATCH 03/13] drm/kirin: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 04/13] drm/i915: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 05/13] drm/mtk: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 06/13] drm/mxsfb: " Daniel Vetter
2017-06-22 10:48   ` Marek Vasut
2017-06-21  8:28 ` [PATCH 07/13] drm/nouveau: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 08/13] drm/rockchip: " Daniel Vetter
2017-06-23 14:06   ` Sean Paul
2017-06-21  8:28 ` [PATCH 09/13] drm/shmob: " Daniel Vetter
2017-06-21  9:12   ` Laurent Pinchart
2017-06-22  6:40     ` Daniel Vetter
2017-06-21  8:28 ` [PATCH 10/13] drm/udl: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 11/13] drm/vmwgfx: " Daniel Vetter
2017-06-23 14:10   ` Sean Paul
2017-06-26 12:22     ` Thomas Hellstrom
2017-06-21  8:28 ` [PATCH 12/13] drm/zte: " Daniel Vetter
2017-06-21 11:59   ` Shawn Guo
2017-06-21  8:28 ` [PATCH 13/13] drm/vblank: Unexport drm_vblank_cleanup Daniel Vetter
2017-06-22 12:56   ` Alex Deucher
2017-06-21  8:52 ` ✗ Fi.CI.BAT: warning for RESEND: remove drm_vblank_cleanup from drivers Patchwork
2017-06-23 14:58 ` [PATCH 00/13] " Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170621082850.13224-3-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=puck.chen@hisilicon.com \
    --cc=z.liuxinliang@hisilicon.com \
    --cc=zourongrong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.