All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: [PATCH 08/13] drm/rockchip: Drop drm_vblank_cleanup
Date: Wed, 21 Jun 2017 10:28:45 +0200	[thread overview]
Message-ID: <20170621082850.13224-9-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20170621082850.13224-1-daniel.vetter@ffwll.ch>

Either not relevant (in the load error paths) or done better already
(in the unload code, by calling drm_atomic_helper_shutdown). Drop it.

Cc: Mark Yao <mark.yao@rock-chips.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index c6b1b7f3a2a3..b9fbf4b1e8f0 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -177,7 +177,6 @@ static int rockchip_drm_bind(struct device *dev)
 	rockchip_drm_fbdev_fini(drm_dev);
 err_kms_helper_poll_fini:
 	drm_kms_helper_poll_fini(drm_dev);
-	drm_vblank_cleanup(drm_dev);
 err_unbind_all:
 	component_unbind_all(dev, drm_dev);
 err_mode_config_cleanup:
@@ -200,7 +199,6 @@ static void rockchip_drm_unbind(struct device *dev)
 	drm_kms_helper_poll_fini(drm_dev);
 
 	drm_atomic_helper_shutdown(drm_dev);
-	drm_vblank_cleanup(drm_dev);
 	component_unbind_all(dev, drm_dev);
 	drm_mode_config_cleanup(drm_dev);
 	rockchip_iommu_cleanup(drm_dev);
-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-06-21  8:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  8:28 [PATCH 00/13] RESEND: remove drm_vblank_cleanup from drivers Daniel Vetter
2017-06-21  8:28 ` [PATCH 01/13] drm/amd|radeon: Drop drm_vblank_cleanup Daniel Vetter
2017-06-22 12:54   ` Alex Deucher
2017-06-23  8:41     ` Daniel Vetter
2017-06-21  8:28 ` [PATCH 02/13] drm/hibmc: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 03/13] drm/kirin: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 04/13] drm/i915: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 05/13] drm/mtk: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 06/13] drm/mxsfb: " Daniel Vetter
2017-06-22 10:48   ` Marek Vasut
2017-06-21  8:28 ` [PATCH 07/13] drm/nouveau: " Daniel Vetter
2017-06-21  8:28 ` Daniel Vetter [this message]
2017-06-23 14:06   ` [PATCH 08/13] drm/rockchip: " Sean Paul
2017-06-21  8:28 ` [PATCH 09/13] drm/shmob: " Daniel Vetter
2017-06-21  9:12   ` Laurent Pinchart
2017-06-22  6:40     ` Daniel Vetter
2017-06-21  8:28 ` [PATCH 10/13] drm/udl: " Daniel Vetter
2017-06-21  8:28 ` [PATCH 11/13] drm/vmwgfx: " Daniel Vetter
2017-06-23 14:10   ` Sean Paul
2017-06-26 12:22     ` Thomas Hellstrom
2017-06-21  8:28 ` [PATCH 12/13] drm/zte: " Daniel Vetter
2017-06-21 11:59   ` Shawn Guo
2017-06-21  8:28 ` [PATCH 13/13] drm/vblank: Unexport drm_vblank_cleanup Daniel Vetter
2017-06-22 12:56   ` Alex Deucher
2017-06-21  8:52 ` ✗ Fi.CI.BAT: warning for RESEND: remove drm_vblank_cleanup from drivers Patchwork
2017-06-23 14:58 ` [PATCH 00/13] " Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170621082850.13224-9-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.