From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH 5/9] serial: omap-serial: Use common rs485 device tree parsing function Date: Wed, 21 Jun 2017 12:21:26 +0200 [thread overview] Message-ID: <20170621102130.21024-6-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20170621102130.21024-1-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> We just got a common helper for parsing the rs485 specific device tree properties. Use it and drop the open coded parser. Note that the common helper is more strict and only evaluates the optional properties if the required rs485-rts-delay is present. Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Signed-off-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> --- Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org drivers/tty/serial/omap-serial.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 1ea05ac57aa7..6e4728d3a24c 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1638,17 +1638,7 @@ static int serial_omap_probe_rs485(struct uart_omap_port *up, up->rts_gpio = -EINVAL; } - if (of_property_read_u32_array(np, "rs485-rts-delay", - rs485_delay, 2) == 0) { - rs485conf->delay_rts_before_send = rs485_delay[0]; - rs485conf->delay_rts_after_send = rs485_delay[1]; - } - - if (of_property_read_bool(np, "rs485-rx-during-tx")) - rs485conf->flags |= SER_RS485_RX_DURING_TX; - - if (of_property_read_bool(np, "linux,rs485-enabled-at-boot-time")) - rs485conf->flags |= SER_RS485_ENABLED; + of_get_rs485_mode(np, rs485conf); return 0; } -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/9] serial: omap-serial: Use common rs485 device tree parsing function Date: Wed, 21 Jun 2017 12:21:26 +0200 [thread overview] Message-ID: <20170621102130.21024-6-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20170621102130.21024-1-u.kleine-koenig@pengutronix.de> From: Sascha Hauer <s.hauer@pengutronix.de> We just got a common helper for parsing the rs485 specific device tree properties. Use it and drop the open coded parser. Note that the common helper is more strict and only evaluates the optional properties if the required rs485-rts-delay is present. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> --- Cc: Tony Lindgren <tony@atomide.com> Cc: linux-omap at vger.kernel.org drivers/tty/serial/omap-serial.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 1ea05ac57aa7..6e4728d3a24c 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1638,17 +1638,7 @@ static int serial_omap_probe_rs485(struct uart_omap_port *up, up->rts_gpio = -EINVAL; } - if (of_property_read_u32_array(np, "rs485-rts-delay", - rs485_delay, 2) == 0) { - rs485conf->delay_rts_before_send = rs485_delay[0]; - rs485conf->delay_rts_after_send = rs485_delay[1]; - } - - if (of_property_read_bool(np, "rs485-rx-during-tx")) - rs485conf->flags |= SER_RS485_RX_DURING_TX; - - if (of_property_read_bool(np, "linux,rs485-enabled-at-boot-time")) - rs485conf->flags |= SER_RS485_ENABLED; + of_get_rs485_mode(np, rs485conf); return 0; } -- 2.11.0
next prev parent reply other threads:[~2017-06-21 10:21 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-21 10:21 [PATCH 0/9] Add and make use of a common rs485 device tree parsing function Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König [not found] ` <20170621102130.21024-1-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2017-06-21 10:21 ` [PATCH 1/9] serial: Add " Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König [not found] ` <20170621102130.21024-2-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2017-06-22 6:10 ` Sascha Hauer 2017-06-22 6:10 ` Sascha Hauer [not found] ` <20170622061007.h76gk3hixp4ipyvr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2017-06-22 8:01 ` Uwe Kleine-König 2017-06-22 8:01 ` Uwe Kleine-König 2017-06-22 6:31 ` Sascha Hauer 2017-06-22 6:31 ` Sascha Hauer [not found] ` <20170622063157.qih2mriprczpj7zn-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2017-06-22 8:22 ` Uwe Kleine-König 2017-06-22 8:22 ` Uwe Kleine-König [not found] ` <20170622082221.v4jf2u5bdw6oyjxw-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2017-06-22 9:56 ` Nicolas Ferre 2017-06-22 9:56 ` Nicolas Ferre 2017-06-21 10:21 ` [PATCH 2/9] ARM: dts/at91: ensure UARTs used for rs485 specify rs485-rts-delay Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König 2017-06-21 10:21 ` [PATCH 3/9] serial: atmel: Use common rs485 device tree parsing function Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König [not found] ` <20170621102130.21024-4-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2017-06-23 9:49 ` Richard Genoud 2017-06-23 9:49 ` Richard Genoud 2017-06-23 11:13 ` Uwe Kleine-König 2017-06-23 11:13 ` Uwe Kleine-König 2017-06-21 10:21 ` [PATCH 4/9] serial: fsl_lpuart: " Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König [this message] 2017-06-21 10:21 ` [PATCH 5/9] serial: omap-serial: " Uwe Kleine-König 2017-06-21 10:21 ` [PATCH 6/9] serial: imx: default to half duplex rs485 Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König 2017-06-21 10:21 ` [PATCH 7/9] ARM: dts/imx: ensure UARTs used for rs485 specify rs485-rts-delay Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König 2017-06-21 10:21 ` [PATCH 8/9] serial: imx: Use common rs485 device tree parsing function Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König 2017-06-21 10:21 ` [PATCH 9/9] of: document rs485 bindings for Atmel USART, Freescale UARTs and OMAP UART Uwe Kleine-König 2017-06-21 10:21 ` Uwe Kleine-König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170621102130.21024-6-u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.