All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 09/19] drm/i915: disable GTT cache for 2M/1G pages
Date: Wed, 21 Jun 2017 21:33:35 +0100	[thread overview]
Message-ID: <20170621203345.26320-10-matthew.auld@intel.com> (raw)
In-Reply-To: <20170621203345.26320-1-matthew.auld@intel.com>

When SW enables the use of 2M/1G pages, it must disable the GTT cache.

v2: don't disable for Cherryview which doesn't even support 48b PPGTT!

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_pm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index b5b7372fcddc..3939977dddb8 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -8307,10 +8307,10 @@ static void broadwell_init_clock_gating(struct drm_i915_private *dev_priv)
 
 	/*
 	 * WaGttCachingOffByDefault:bdw
-	 * GTT cache may not work with big pages, so if those
-	 * are ever enabled GTT cache may need to be disabled.
+	 * The GTT cache must be disabled if the system is planning to use
+	 * 2M/1G pages.
 	 */
-	I915_WRITE(HSW_GTT_CACHE_EN, GTT_CACHE_EN_ALL);
+	I915_WRITE(HSW_GTT_CACHE_EN, 0);
 
 	/* WaKVMNotificationOnConfigChange:bdw */
 	I915_WRITE(CHICKEN_PAR2_1, I915_READ(CHICKEN_PAR2_1)
-- 
2.9.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-06-21 20:33 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 20:33 [PATCH 00/19] huge gtt pages Matthew Auld
2017-06-21 20:33 ` [PATCH 01/19] drm/i915: introduce simple gemfs Matthew Auld
2017-06-21 21:19   ` Chris Wilson
2017-06-21 20:33 ` [PATCH 02/19] drm/i915/gemfs: enable THP Matthew Auld
2017-06-21 20:33 ` [PATCH 03/19] drm/i915: introduce page_size_mask to dev_info Matthew Auld
2017-06-21 20:33 ` [PATCH 04/19] drm/i915: introduce page_size members Matthew Auld
2017-06-21 21:26   ` Chris Wilson
2017-06-21 20:33 ` [PATCH 05/19] drm/i915: align the vma start to the largest gtt page size Matthew Auld
2017-06-21 21:35   ` Chris Wilson
2017-06-21 20:33 ` [PATCH 06/19] drm/i915: align 64K objects to 2M Matthew Auld
2017-06-21 21:37   ` Chris Wilson
2017-06-21 20:33 ` [PATCH 07/19] drm/i915: pass the vma to insert_entries Matthew Auld
2017-06-21 21:39   ` Chris Wilson
2017-06-21 20:33 ` [PATCH 08/19] drm/i915: enable IPS bit for 64K pages Matthew Auld
2017-06-21 20:33 ` Matthew Auld [this message]
2017-06-21 21:41   ` [PATCH 09/19] drm/i915: disable GTT cache for 2M/1G pages Chris Wilson
2017-06-21 20:33 ` [PATCH 10/19] drm/i915: support 1G pages for the 48b PPGTT Matthew Auld
2017-06-21 21:49   ` Chris Wilson
2017-06-21 22:51     ` Chris Wilson
2017-06-22 11:07       ` Matthew Auld
2017-06-22 11:38         ` Chris Wilson
2017-06-21 20:33 ` [PATCH 11/19] drm/i915: support 2M " Matthew Auld
2017-06-21 20:33 ` [PATCH 12/19] drm/i915: support 64K " Matthew Auld
2017-06-21 21:55   ` Chris Wilson
2017-06-22 11:27     ` Matthew Auld
2017-06-21 20:33 ` [PATCH 13/19] drm/i915: accurate page size tracking for the ppgtt Matthew Auld
2017-06-21 21:57   ` Chris Wilson
2017-06-21 20:33 ` [PATCH 14/19] drm/i915/debugfs: include some gtt page size metrics Matthew Auld
2017-06-21 20:33 ` [PATCH 15/19] drm/i915/selftests: basic huge page tests Matthew Auld
2017-06-22 14:17   ` Chris Wilson
2017-06-22 14:21   ` Chris Wilson
2017-06-21 20:33 ` [PATCH 16/19] drm/i915/selftests: mix huge pages Matthew Auld
2017-06-21 20:33 ` [PATCH 17/19] drm/i915: enable platform support for 64K pages Matthew Auld
2017-06-21 20:33 ` [PATCH 18/19] drm/i915: enable platform support for 2M pages Matthew Auld
2017-06-21 20:33 ` [PATCH 19/19] drm/i915: enable platform support for 1G pages Matthew Auld
2017-06-21 21:05 ` ✓ Fi.CI.BAT: success for huge gtt pages (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170621203345.26320-10-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.