From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: Marc Zyngier <marc.zyngier@arm.com>, Linus Walleij <linus.walleij@linaro.org>, Brian Norris <briannorris@chromium.org>, Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org, Julia Cartwright <julia@ni.com>, linux-gpio@vger.kernel.org, John Keeping <john@metanate.com>, Doug Anderson <dianders@chromium.org>, Tomasz Figa <tomasz.figa@gmail.com>, Krzysztof Kozlowski <krzk@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Kukjin Kim <kgene@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Date: Thu, 29 Jun 2017 23:33:35 +0200 [thread overview] Message-ID: <20170629214343.882576048@linutronix.de> (raw) In-Reply-To: 20170629213334.375848050@linutronix.de [-- Attachment #1: pinctrl--samsung--Remove-bogus-irqmask-unmask.patch --] [-- Type: text/plain, Size: 1454 bytes --] The irq chip callbacks irq_request/release_resources() have absolutely no business with masking and unmasking the irq. The core code unmasks the interrupt after complete setup and masks it before invoking irq_release_resources(). The unmask is actually harmful as it happens before the interrupt is completely initialized in __setup_irq(). Remove it. Fixes: f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs") Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Tomasz Figa <tomasz.figa@gmail.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Kukjin Kim <kgene@kernel.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/samsung/pinctrl-exynos.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -205,8 +205,6 @@ static int exynos_irq_request_resources( spin_unlock_irqrestore(&bank->slock, flags); - exynos_irq_unmask(irqd); - return 0; } @@ -226,8 +224,6 @@ static void exynos_irq_release_resources shift = irqd->hwirq * bank_type->fld_width[PINCFG_TYPE_FUNC]; mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1; - exynos_irq_mask(irqd); - spin_lock_irqsave(&bank->slock, flags); con = readl(bank->eint_base + reg_con);
WARNING: multiple messages have this Message-ID (diff)
From: tglx@linutronix.de (Thomas Gleixner) To: linux-arm-kernel@lists.infradead.org Subject: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Date: Thu, 29 Jun 2017 23:33:35 +0200 [thread overview] Message-ID: <20170629214343.882576048@linutronix.de> (raw) In-Reply-To: 20170629213334.375848050@linutronix.de The irq chip callbacks irq_request/release_resources() have absolutely no business with masking and unmasking the irq. The core code unmasks the interrupt after complete setup and masks it before invoking irq_release_resources(). The unmask is actually harmful as it happens before the interrupt is completely initialized in __setup_irq(). Remove it. Fixes: f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs") Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Tomasz Figa <tomasz.figa@gmail.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Kukjin Kim <kgene@kernel.org> Cc: linux-arm-kernel at lists.infradead.org Cc: linux-samsung-soc at vger.kernel.org Cc: linux-gpio at vger.kernel.org --- drivers/pinctrl/samsung/pinctrl-exynos.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -205,8 +205,6 @@ static int exynos_irq_request_resources( spin_unlock_irqrestore(&bank->slock, flags); - exynos_irq_unmask(irqd); - return 0; } @@ -226,8 +224,6 @@ static void exynos_irq_release_resources shift = irqd->hwirq * bank_type->fld_width[PINCFG_TYPE_FUNC]; mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1; - exynos_irq_mask(irqd); - spin_lock_irqsave(&bank->slock, flags); con = readl(bank->eint_base + reg_con);
next prev parent reply other threads:[~2017-06-29 21:33 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-29 21:33 [patch 0/5] genirq: Distangle irq_request/release_resources() from irq_desc->lock Thomas Gleixner 2017-06-29 21:33 ` Thomas Gleixner 2017-06-29 21:33 ` Thomas Gleixner [this message] 2017-06-29 21:33 ` [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Thomas Gleixner 2017-06-30 2:47 ` Tomasz Figa 2017-06-30 2:47 ` Tomasz Figa 2017-06-30 2:47 ` Tomasz Figa 2017-06-30 6:02 ` Krzysztof Kozlowski 2017-06-30 6:02 ` Krzysztof Kozlowski 2017-06-30 6:02 ` Krzysztof Kozlowski 2017-06-30 6:20 ` Tomasz Figa 2017-06-30 6:20 ` Tomasz Figa 2017-06-30 6:20 ` Tomasz Figa [not found] ` <20170629214343.882576048-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> 2017-06-30 12:12 ` Linus Walleij 2017-06-30 12:12 ` Linus Walleij 2017-06-30 12:12 ` Linus Walleij 2017-06-30 12:17 ` Thomas Gleixner 2017-06-30 12:17 ` Thomas Gleixner 2017-06-30 12:17 ` Thomas Gleixner 2017-06-30 13:53 ` Linus Walleij 2017-06-30 13:53 ` Linus Walleij 2017-06-30 13:53 ` Linus Walleij 2017-06-30 14:58 ` Krzysztof Kozlowski 2017-06-30 14:58 ` Krzysztof Kozlowski 2017-06-30 14:58 ` Krzysztof Kozlowski 2017-06-29 21:33 ` [patch 2/5] genirq: Move bus locking into __setup_irq() Thomas Gleixner 2017-07-04 10:48 ` [tip:irq/urgent] " tip-bot for Thomas Gleixner 2017-06-29 21:33 ` [patch 3/5] genirq: Add mutex to irq desc to serialize request/free_irq() Thomas Gleixner 2017-06-29 21:33 ` Thomas Gleixner 2017-07-04 10:48 ` [tip:irq/urgent] " tip-bot for Thomas Gleixner 2017-06-29 21:33 ` [patch 4/5] genirq: Move irq resource handling out of spinlocked region Thomas Gleixner 2017-07-04 10:49 ` [tip:irq/urgent] " tip-bot for Thomas Gleixner 2017-06-29 21:33 ` [patch 5/5] genirq/timings: Move free timings " Thomas Gleixner 2017-07-04 10:49 ` [tip:irq/urgent] " tip-bot for Thomas Gleixner 2017-06-30 13:49 ` [patch 0/5] genirq: Distangle irq_request/release_resources() from irq_desc->lock Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170629214343.882576048@linutronix.de \ --to=tglx@linutronix.de \ --cc=briannorris@chromium.org \ --cc=dianders@chromium.org \ --cc=heiko@sntech.de \ --cc=john@metanate.com \ --cc=julia@ni.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=s.nawrocki@samsung.com \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.