All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Tull <atull@kernel.org>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Alan Tull <atull@kernel.org>,
	linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org
Subject: [PATCH v3 12/16] fpga: region: add fpga-region.h header
Date: Thu,  6 Jul 2017 13:47:12 -0500	[thread overview]
Message-ID: <20170706184716.3179-13-atull@kernel.org> (raw)
In-Reply-To: <20170706184716.3179-1-atull@kernel.org>

* Create fpga-region.h.
* Export fpga_region_program_fpga.
* Move struct fpga_region and other things to the header.

This is a step in separating FPGA region common code
from Device Tree support.

Signed-off-by: Alan Tull <atull@kernel.org>
---
 drivers/fpga/fpga-region.c       | 24 ++++--------------------
 include/linux/fpga/fpga-region.h | 28 ++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+), 20 deletions(-)
 create mode 100644 include/linux/fpga/fpga-region.h

diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
index f43ce3f..bb10fb7 100644
--- a/drivers/fpga/fpga-region.c
+++ b/drivers/fpga/fpga-region.c
@@ -18,6 +18,7 @@
 
 #include <linux/fpga/fpga-bridge.h>
 #include <linux/fpga/fpga-mgr.h>
+#include <linux/fpga/fpga-region.h>
 #include <linux/idr.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
@@ -26,24 +27,6 @@
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 
-/**
- * struct fpga_region - FPGA Region structure
- * @dev: FPGA Region device
- * @mutex: enforces exclusive reference to region
- * @bridge_list: list of FPGA bridges specified in region
- * @mgr: FPGA manager
- * @info: fpga image specific information
- */
-struct fpga_region {
-	struct device dev;
-	struct mutex mutex; /* for exclusive reference to region */
-	struct list_head bridge_list;
-	struct fpga_manager *mgr;
-	struct fpga_image_info *info;
-};
-
-#define to_fpga_region(d) container_of(d, struct fpga_region, dev)
-
 static DEFINE_IDA(fpga_region_ida);
 static struct class *fpga_region_class;
 
@@ -226,7 +209,7 @@ static int fpga_region_get_bridges(struct fpga_region *region,
  * Program an FPGA using fpga image info (region->info).
  * Return 0 for success or negative error code.
  */
-static int fpga_region_program_fpga(struct fpga_region *region)
+int fpga_region_program_fpga(struct fpga_region *region)
 {
 	struct device *dev = &region->dev;
 	struct fpga_image_info *info = region->info;
@@ -282,6 +265,7 @@ static int fpga_region_program_fpga(struct fpga_region *region)
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(fpga_region_program_fpga);
 
 /**
  * child_regions_with_firmware
@@ -667,5 +651,5 @@ subsys_initcall(fpga_region_init);
 module_exit(fpga_region_exit);
 
 MODULE_DESCRIPTION("FPGA Region");
-MODULE_AUTHOR("Alan Tull <atull@opensource.altera.com>");
+MODULE_AUTHOR("Alan Tull <atull@kernel.org>");
 MODULE_LICENSE("GPL v2");
diff --git a/include/linux/fpga/fpga-region.h b/include/linux/fpga/fpga-region.h
new file mode 100644
index 0000000..f84a2e1
--- /dev/null
+++ b/include/linux/fpga/fpga-region.h
@@ -0,0 +1,28 @@
+#include <linux/device.h>
+#include <linux/fpga/fpga-mgr.h>
+#include <linux/fpga/fpga-bridge.h>
+
+#ifndef _FPGA_REGION_H
+#define _FPGA_REGION_H
+
+/**
+ * struct fpga_region - FPGA Region structure
+ * @dev: FPGA Region device
+ * @mutex: enforces exclusive reference to region
+ * @bridge_list: list of FPGA bridges specified in region
+ * @mgr: FPGA manager
+ * @info: FPGA image info
+ */
+struct fpga_region {
+	struct device dev;
+	struct mutex mutex; /* for exclusive reference to region */
+	struct list_head bridge_list;
+	struct fpga_manager *mgr;
+	struct fpga_image_info *info;
+};
+
+#define to_fpga_region(d) container_of(d, struct fpga_region, dev)
+
+int fpga_region_program_fpga(struct fpga_region *region);
+
+#endif /* _FPGA_REGION_H */
-- 
2.7.4

  parent reply	other threads:[~2017-07-06 18:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06 18:47 [PATCH v3 00/16] Enable upper layers using FPGA region w/o device tree Alan Tull
2017-07-06 18:47 ` [PATCH v3 01/16] doc: fpga: update documents for the FPGA API Alan Tull
2017-08-17 19:42   ` Moritz Fischer
2017-08-17 19:52     ` Alan Tull
2017-07-06 18:47 ` [PATCH v3 02/16] fpga: bridge: support getting bridge from device Alan Tull
2017-07-06 18:47 ` [PATCH v3 03/16] fpga: mgr: API change to replace fpga load functions with single function Alan Tull
2017-07-10 17:36   ` Moritz Fischer
2017-07-10 18:23     ` Alan Tull
2017-07-12 16:33     ` Alan Tull
2017-07-06 18:47 ` [PATCH v3 04/16] fpga: mgr: separate getting/locking FPGA manager Alan Tull
2017-07-06 18:47 ` [PATCH v3 05/16] fpga: region: use dev_err instead of pr_err Alan Tull
2017-07-06 18:47 ` [PATCH v3 06/16] fpga: region: remove unneeded of_node_get and put Alan Tull
2017-07-06 18:47 ` [PATCH v3 07/16] fpga: region: get mgr early on Alan Tull
2017-07-06 18:47 ` [PATCH v3 08/16] fpga: region: check for child regions before allocing image info Alan Tull
2017-07-06 18:47 ` [PATCH v3 09/16] fpga: region: fix slow warning with more than one overlay Alan Tull
2017-07-06 18:47 ` [PATCH v3 10/16] fpga: region: use image info as parameter for programming region Alan Tull
2017-07-06 18:47 ` [PATCH v3 11/16] fpga: region: separate out code that parses the overlay Alan Tull
2017-07-06 18:47 ` Alan Tull [this message]
2017-07-06 18:47 ` [PATCH v3 13/16] fpga: region: rename some functions prior to moving Alan Tull
2017-07-06 18:47 ` [PATCH v3 14/16] fpga: region: add register/unregister functions Alan Tull
2017-07-06 18:47 ` [PATCH v3 15/16] fpga: region: add fpga_region_class_find Alan Tull
2017-07-06 18:47 ` [PATCH v3 16/16] fpga: region: move device tree support to of-fpga-region.c Alan Tull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706184716.3179-13-atull@kernel.org \
    --to=atull@kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moritz.fischer@ettus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.