All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: aurelien@aurel32.net, laurent@vivier.eu, bruno@clisp.org,
	glaubitz@debian.org
Subject: [Qemu-devel] [PATCH v2 05/27] target/sh4: Adjust TB_FLAG_PENDING_MOVCA
Date: Thu,  6 Jul 2017 16:20:49 -1000	[thread overview]
Message-ID: <20170707022111.21836-6-rth@twiddle.net> (raw)
In-Reply-To: <20170707022111.21836-1-rth@twiddle.net>

Don't leave an unused bit after DELAY_SLOT_MASK.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target/sh4/cpu.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h
index 6d179a7..da31805 100644
--- a/target/sh4/cpu.h
+++ b/target/sh4/cpu.h
@@ -96,6 +96,8 @@
 #define DELAY_SLOT_CONDITIONAL (1 << 1)
 #define DELAY_SLOT_RTE         (1 << 2)
 
+#define TB_FLAG_PENDING_MOVCA  (1 << 3)
+
 #define TB_FLAG_ENVFLAGS_MASK  DELAY_SLOT_MASK
 
 typedef struct tlb_t {
@@ -369,8 +371,6 @@ static inline int cpu_ptel_pr (uint32_t ptel)
 #define PTEA_TC        (1 << 3)
 #define cpu_ptea_tc(ptea) (((ptea) & PTEA_TC) >> 3)
 
-#define TB_FLAG_PENDING_MOVCA  (1 << 4)
-
 static inline target_ulong cpu_read_sr(CPUSH4State *env)
 {
     return env->sr | (env->sr_m << SR_M) |
@@ -395,7 +395,7 @@ static inline void cpu_get_tb_cpu_state(CPUSH4State *env, target_ulong *pc,
             | (env->fpscr & (FPSCR_FR | FPSCR_SZ | FPSCR_PR))  /* Bits 19-21 */
             | (env->sr & ((1u << SR_MD) | (1u << SR_RB)))      /* Bits 29-30 */
             | (env->sr & (1u << SR_FD))                        /* Bit 15 */
-            | (env->movcal_backup ? TB_FLAG_PENDING_MOVCA : 0); /* Bit 4 */
+            | (env->movcal_backup ? TB_FLAG_PENDING_MOVCA : 0); /* Bit 3 */
 }
 
 #endif /* SH4_CPU_H */
-- 
2.9.4

  parent reply	other threads:[~2017-07-07  2:22 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07  2:20 [Qemu-devel] [PATCH v2 00/27] target/sh4 improvements Richard Henderson
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 01/27] target/sh4: Use cmpxchg for movco Richard Henderson
2017-07-15 23:22   ` Aurelien Jarno
2017-07-16 21:55     ` Aurelien Jarno
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 02/27] target/sh4: Consolidate end-of-TB tests Richard Henderson
2017-07-07 21:42   ` Aurelien Jarno
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 03/27] target/sh4: Introduce TB_FLAG_ENVFLAGS_MASK Richard Henderson
2017-07-07 21:42   ` Aurelien Jarno
2017-07-08 16:29   ` Philippe Mathieu-Daudé
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 04/27] target/sh4: Keep env->flags clean Richard Henderson
2017-07-07 21:42   ` Aurelien Jarno
2017-07-08 16:31   ` Philippe Mathieu-Daudé
2017-07-07  2:20 ` Richard Henderson [this message]
2017-07-07 21:42   ` [Qemu-devel] [PATCH v2 05/27] target/sh4: Adjust TB_FLAG_PENDING_MOVCA Aurelien Jarno
2017-07-08 16:31   ` Philippe Mathieu-Daudé
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 06/27] target/sh4: Handle user-space atomics Richard Henderson
2017-07-15 22:14   ` Aurelien Jarno
2017-07-15 22:16     ` John Paul Adrian Glaubitz
2017-07-16  2:30     ` Richard Henderson
2017-07-16 15:18       ` Aurelien Jarno
2017-07-16 19:35         ` Richard Henderson
2017-07-16 21:43           ` Aurelien Jarno
2017-07-16 21:59             ` Richard Henderson
2017-07-16 22:16               ` Aurelien Jarno
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 07/27] target/sh4: Recognize common gUSA sequences Richard Henderson
2017-07-17 14:10   ` Aurelien Jarno
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 08/27] linux-user/sh4: Notice gUSA regions during signal delivery Richard Henderson
2017-07-07  7:25   ` John Paul Adrian Glaubitz
2017-07-07  8:20     ` Richard Henderson
2017-07-07  8:30       ` John Paul Adrian Glaubitz
2017-07-07  8:35         ` John Paul Adrian Glaubitz
2017-07-07 16:22           ` Richard Henderson
2017-07-13  9:09             ` John Paul Adrian Glaubitz
2017-07-13 10:56               ` John Paul Adrian Glaubitz
2017-07-13 21:37                 ` Richard Henderson
2017-07-13 21:42                   ` John Paul Adrian Glaubitz
     [not found]           ` <20170707163826.22631-1-rth@twiddle.net>
2017-07-07 17:57             ` [Qemu-devel] Fwd: [PATCH v2.5] fixup! " Richard Henderson
2017-07-07 19:00               ` Richard Henderson
2017-07-17 14:15                 ` Aurelien Jarno
2017-07-07  9:05   ` [Qemu-devel] [PATCH v2 08/27] " Laurent Vivier
2017-07-07  9:09     ` Laurent Vivier
2017-07-07  9:13     ` John Paul Adrian Glaubitz
2017-07-15 22:52   ` Aurelien Jarno
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 09/27] linux-user/sh4: Clean env->flags on signal boundaries Richard Henderson
2017-07-15 22:59   ` Aurelien Jarno
2017-07-16  2:33     ` Richard Henderson
2017-07-16 15:18       ` Aurelien Jarno
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 10/27] target/sh4: Hoist register bank selection Richard Henderson
2017-07-07 21:48   ` Aurelien Jarno
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 11/27] target/sh4: Unify cpu_fregs into FREG Richard Henderson
2017-07-07 21:54   ` Aurelien Jarno
2017-07-08 16:54   ` Philippe Mathieu-Daudé
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 12/27] target/sh4: Pass DisasContext to fpr64 routines Richard Henderson
2017-07-07 21:55   ` Aurelien Jarno
2017-07-08 16:56   ` Philippe Mathieu-Daudé
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 13/27] target/sh4: Hoist fp register bank selection Richard Henderson
2017-07-07 21:57   ` Aurelien Jarno
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 14/27] target/sh4: Eliminate unused XREG macro Richard Henderson
2017-07-07 21:59   ` Aurelien Jarno
2017-07-07  2:20 ` [Qemu-devel] [PATCH v2 15/27] target/sh4: Merge DREG into fpr64 routines Richard Henderson
2017-07-07 22:06   ` Aurelien Jarno
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 16/27] target/sh4: Load/store Dr as 64-bit quantities Richard Henderson
2017-07-07 22:14   ` Aurelien Jarno
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 17/27] target/sh4: Simplify 64-bit fp reg-reg move Richard Henderson
2017-07-07 22:15   ` Aurelien Jarno
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 18/27] target/sh4: Unify code for CHECK_NOT_DELAY_SLOT Richard Henderson
2017-07-07 22:17   ` Aurelien Jarno
2017-07-08 16:59   ` Philippe Mathieu-Daudé
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 19/27] target/sh4: Unify code for CHECK_PRIVILEGED Richard Henderson
2017-07-07 22:17   ` Aurelien Jarno
2017-07-08 17:00   ` Philippe Mathieu-Daudé
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 20/27] target/sh4: Unify code for CHECK_FPU_ENABLED Richard Henderson
2017-07-07 22:18   ` Aurelien Jarno
2017-07-08 17:01   ` Philippe Mathieu-Daudé
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 21/27] target/sh4: Tidy misc illegal insn checks Richard Henderson
2017-07-07 22:18   ` Aurelien Jarno
2017-07-08 17:02   ` Philippe Mathieu-Daudé
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 22/27] target/sh4: Introduce CHECK_FPSCR_PR_* Richard Henderson
2017-07-07 22:20   ` Aurelien Jarno
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 23/27] target/sh4: Introduce CHECK_SH4A Richard Henderson
2017-07-07 22:21   ` Aurelien Jarno
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 24/27] target/sh4: Implement fpchg Richard Henderson
2017-07-07 22:23   ` Aurelien Jarno
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 25/27] target/sh4: Add missing FPSCR.PR == 0 checks Richard Henderson
2017-07-07 22:24   ` Aurelien Jarno
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 26/27] target/sh4: Implement fsrra Richard Henderson
2017-07-07 22:27   ` Aurelien Jarno
2017-07-07  2:21 ` [Qemu-devel] [PATCH v2 27/27] target/sh4: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2017-07-18  7:51 ` [Qemu-devel] [PATCH v2 00/27] target/sh4 improvements Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170707022111.21836-6-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=bruno@clisp.org \
    --cc=glaubitz@debian.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.