From: Malcolm Priestley <tvboxspy@gmail.com>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Malcolm Priestley <tvboxspy@gmail.com>
Subject: [PATCH RFC 1/2] app: kaffeine: Fix missing PCR on live streams.
Date: Sun, 9 Jul 2017 10:43:50 +0100 [thread overview]
Message-ID: <20170709094351.14642-1-tvboxspy@gmail.com> (raw)
The ISO/IEC standard 13818-1 or ITU-T Rec. H.222.0 standard allow transport
vendors to place PCR (Program Clock Reference) on a different PID.
If the PCR is unset the value is 0x1fff, most vendors appear to set it the
same as video pid in which case it need not be set.
The PCR PID is at an offset of 8 in pmtSection structure.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
src/dvb/dvbliveview.cpp | 8 ++++++++
src/dvb/dvbsi.h | 5 +++++
2 files changed, 13 insertions(+)
diff --git a/src/dvb/dvbliveview.cpp b/src/dvb/dvbliveview.cpp
index cfad892..3e92fa6 100644
--- a/src/dvb/dvbliveview.cpp
+++ b/src/dvb/dvbliveview.cpp
@@ -518,6 +518,7 @@ void DvbLiveView::updatePids(bool forcePatPmtUpdate)
DvbPmtSection pmtSection(internal->pmtSectionData);
DvbPmtParser pmtParser(pmtSection);
QSet<int> newPids;
+ int pcr_pid = pmtSection.pcr_pid();
bool updatePatPmt = forcePatPmtUpdate;
bool isTimeShifting = internal->timeShiftFile.isOpen();
@@ -543,6 +544,13 @@ void DvbLiveView::updatePids(bool forcePatPmtUpdate)
newPids.insert(pmtParser.teletextPid);
}
+ /* check PCR PID is set */
+ if (pcr_pid != 0x1fff) {
+ /* Check not already in list */
+ if (!newPids.contains(pcr_pid))
+ newPids.insert(pcr_pid);
+ }
+
for (int i = 0; i < pids.size(); ++i) {
int pid = pids.at(i);
diff --git a/src/dvb/dvbsi.h b/src/dvb/dvbsi.h
index 4d27252..9b4bbe0 100644
--- a/src/dvb/dvbsi.h
+++ b/src/dvb/dvbsi.h
@@ -1098,6 +1098,11 @@ public:
return (at(3) << 8) | at(4);
}
+ int pcr_pid() const
+ {
+ return ((at(8) & 0x1f) << 8) | at(9);
+ }
+
DvbDescriptor descriptors() const
{
return DvbDescriptor(getData() + 12, descriptorsLength);
--
2.13.2
next reply other threads:[~2017-07-09 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 9:43 Malcolm Priestley [this message]
2017-07-09 9:43 ` [PATCH RFC 2/2] app: kaffeine: Fix missing PCR on stream recordings Malcolm Priestley
2017-07-09 11:14 ` [PATCH RFC 1/2] app: kaffeine: Fix missing PCR on live streams Mauro Carvalho Chehab
2017-07-09 12:11 ` Malcolm Priestley
2017-07-10 12:38 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170709094351.14642-1-tvboxspy@gmail.com \
--to=tvboxspy@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.