All of lore.kernel.org
 help / color / mirror / Atom feed
From: Praveen Kumar <kpraveen.lkml@gmail.com>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
	George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
	tim@xen.org, kpraveen.lkml@gmail.com, jbeulich@suse.com
Subject: [PATCH v5 11/17] rbtree: coding style adjustments
Date: Fri, 14 Jul 2017 13:56:30 +0530	[thread overview]
Message-ID: <20170714082636.29511-12-kpraveen.lkml@gmail.com> (raw)
In-Reply-To: <20170714082636.29511-1-kpraveen.lkml@gmail.com>

From: Michel Lespinasse <walken@google.com>

Set comment and indentation style to be consistent with linux coding style
and the rest of the file, as suggested by Peter Zijlstra

Signed-off-by: Michel Lespinasse <walken@google.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Acked-by: David Woodhouse <David.Woodhouse@intel.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Daniel Santos <daniel.santos@pobox.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[Linux commit 7ce6ff9e5de99e7b72019c7de82fb438fe1dc5a0]

Ported to Xen.

Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
---
 xen/common/rbtree.c | 42 +++++++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/xen/common/rbtree.c b/xen/common/rbtree.c
index e58336bd26..215d4f3613 100644
--- a/xen/common/rbtree.c
+++ b/xen/common/rbtree.c
@@ -363,8 +363,7 @@ void rb_erase(struct rb_node *node, struct rb_root *root)
 		child = node->rb_right;
 	else if (!node->rb_right)
 		child = node->rb_left;
-	else
-	{
+	else {
 		struct rb_node *old = node, *left;
 
 		node = node->rb_right;
@@ -407,17 +406,15 @@ void rb_erase(struct rb_node *node, struct rb_root *root)
 
 	if (child)
 		rb_set_parent(child, parent);
-	if (parent)
-	{
+	if (parent) {
 		if (parent->rb_left == node)
 			parent->rb_left = child;
 		else
 			parent->rb_right = child;
-	}
-	else
+	} else
 		root->rb_node = child;
 
- color:
+color:
 	if (color == RB_BLACK)
 		__rb_erase_color(child, parent, root);
 }
@@ -459,8 +456,10 @@ struct rb_node *rb_next(const struct rb_node *node)
 	if (RB_EMPTY_NODE(node))
 		return NULL;
 
-	/* If we have a right-hand child, go down and then left as far
-	   as we can. */
+	/*
+	 * If we have a right-hand child, go down and then left as far
+	 * as we can.
+	 */
 	if (node->rb_right) {
 		node = node->rb_right;
 		while (node->rb_left)
@@ -468,12 +467,13 @@ struct rb_node *rb_next(const struct rb_node *node)
 		return (struct rb_node *)node;
 	}
 
-	/* No right-hand children.  Everything down and left is
-	   smaller than us, so any 'next' node must be in the general
-	   direction of our parent. Go up the tree; any time the
-	   ancestor is a right-hand child of its parent, keep going
-	   up. First time it's a left-hand child of its parent, said
-	   parent is our 'next' node. */
+	/*
+	 * No right-hand children. Everything down and left is smaller than us,
+	 * so any 'next' node must be in the general direction of our parent.
+	 * Go up the tree; any time the ancestor is a right-hand child of its
+	 * parent, keep going up. First time it's a left-hand child of its
+	 * parent, said parent is our 'next' node.
+	 */
 	while ((parent = rb_parent(node)) && node == parent->rb_right)
 		node = parent;
 
@@ -488,8 +488,10 @@ struct rb_node *rb_prev(const struct rb_node *node)
 	if (RB_EMPTY_NODE(node))
 		return NULL;
 
-	/* If we have a left-hand child, go down and then right as far
-	   as we can. */
+	/*
+	 * If we have a left-hand child, go down and then right as far
+	 * as we can.
+	 */
 	if (node->rb_left) {
 		node = node->rb_left;
 		while (node->rb_right)
@@ -497,8 +499,10 @@ struct rb_node *rb_prev(const struct rb_node *node)
 		return (struct rb_node *)node;
 	}
 
-	/* No left-hand children. Go up till we find an ancestor which
-	   is a right-hand child of its parent */
+	/*
+	 * No left-hand children. Go up till we find an ancestor which
+	 * is a right-hand child of its parent
+	 */
 	while ((parent = rb_parent(node)) && node == parent->rb_left)
 		node = parent;
 
-- 
2.12.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-07-14  8:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-14  8:26 [PATCH v5 00/17] xen: common: rbtree: ported updates from Linux tree Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 01/17] rbtree: changes to align the coding conventions with " Praveen Kumar
2017-07-14 12:28   ` Jan Beulich
2017-07-14 12:51     ` Praveen Kumar
2017-07-14 13:05       ` Jan Beulich
2017-08-03 10:37         ` Dario Faggioli
2017-08-04 16:59           ` Praveen Kumar
2017-08-04 17:04             ` Jan Beulich
2017-08-04 17:21               ` Praveen Kumar
2017-08-06  7:42                 ` Jan Beulich
2017-07-14  8:26 ` [PATCH v5 02/17] rbtree: remove redundant if()-condition in rb_erase() Praveen Kumar
2017-08-03 10:11   ` Jan Beulich
2017-07-14  8:26 ` [PATCH v5 03/17] rbtree: empty nodes have no color Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 04/17] rbtree: move some implementation details from rbtree.h to rbtree.c Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 05/17] rbtree: break out of rb_insert_color loop after tree rotation Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 06/17] rbtree: adjust root color in rb_insert_color() only when necessary Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 07/17] rbtree: low level optimizations in rb_insert_color() Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 08/17] rbtree: adjust node color in __rb_erase_color() only when necessary Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 09/17] rbtree: optimize case selection logic in __rb_erase_color() Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 10/17] rbtree: low level optimizations " Praveen Kumar
2017-07-14  8:26 ` Praveen Kumar [this message]
2017-07-14  8:26 ` [PATCH v5 12/17] rbtree: optimize fetching of sibling node Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 13/17] rbtree: add __rb_change_child() helper function Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 14/17] rbtree: place easiest case first in rb_erase() Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 15/17] rbtree: handle 1-child recoloring in rb_erase() instead of rb_erase_color() Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 16/17] rbtree: low level optimizations in rb_erase() Praveen Kumar
2017-07-14  8:26 ` [PATCH v5 17/17] rbtree: fix typo in comment of rb_insert_color Praveen Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170714082636.29511-12-kpraveen.lkml@gmail.com \
    --to=kpraveen.lkml@gmail.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.