From: Colin King <colin.king@canonical.com> To: Tudor Ambarus <tudor.ambarus@microchip.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S . Miller" <davem@davemloft.net>, linux-crypto@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Crypto: atmel-ecc: Make a couple of local functions static Date: Wed, 19 Jul 2017 10:24:15 +0100 [thread overview] Message-ID: <20170719092415.9553-1-colin.king@canonical.com> (raw) From: Colin Ian King <colin.king@canonical.com> Functions atmel_ecc_i2c_client_alloc and atmel_ecc_i2c_client_free are local to the source and no not need to be in the global scope. Make them static. Cleans up sparse warnings: symbol 'atmel_ecc_i2c_client_alloc' was not declared. Should it be static? symbol 'atmel_ecc_i2c_client_free' was not declared. Should it be static? Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/crypto/atmel-ecc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index 66ab1021eba5..c6e8de2b28dd 100644 --- a/drivers/crypto/atmel-ecc.c +++ b/drivers/crypto/atmel-ecc.c @@ -492,7 +492,7 @@ static int atmel_ecdh_compute_shared_secret(struct kpp_request *req) return ret; } -struct i2c_client *atmel_ecc_i2c_client_alloc(void) +static struct i2c_client *atmel_ecc_i2c_client_alloc(void) { struct atmel_ecc_i2c_client_priv *i2c_priv, *min_i2c_priv = NULL; struct i2c_client *client = ERR_PTR(-ENODEV); @@ -527,7 +527,7 @@ struct i2c_client *atmel_ecc_i2c_client_alloc(void) return client; } -void atmel_ecc_i2c_client_free(struct i2c_client *client) +static void atmel_ecc_i2c_client_free(struct i2c_client *client) { struct atmel_ecc_i2c_client_priv *i2c_priv = i2c_get_clientdata(client); -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Colin King <colin.king@canonical.com> To: Tudor Ambarus <tudor.ambarus@microchip.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S . Miller" <davem@davemloft.net>, linux-crypto@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Crypto: atmel-ecc: Make a couple of local functions static Date: Wed, 19 Jul 2017 09:24:15 +0000 [thread overview] Message-ID: <20170719092415.9553-1-colin.king@canonical.com> (raw) From: Colin Ian King <colin.king@canonical.com> Functions atmel_ecc_i2c_client_alloc and atmel_ecc_i2c_client_free are local to the source and no not need to be in the global scope. Make them static. Cleans up sparse warnings: symbol 'atmel_ecc_i2c_client_alloc' was not declared. Should it be static? symbol 'atmel_ecc_i2c_client_free' was not declared. Should it be static? Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/crypto/atmel-ecc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index 66ab1021eba5..c6e8de2b28dd 100644 --- a/drivers/crypto/atmel-ecc.c +++ b/drivers/crypto/atmel-ecc.c @@ -492,7 +492,7 @@ static int atmel_ecdh_compute_shared_secret(struct kpp_request *req) return ret; } -struct i2c_client *atmel_ecc_i2c_client_alloc(void) +static struct i2c_client *atmel_ecc_i2c_client_alloc(void) { struct atmel_ecc_i2c_client_priv *i2c_priv, *min_i2c_priv = NULL; struct i2c_client *client = ERR_PTR(-ENODEV); @@ -527,7 +527,7 @@ struct i2c_client *atmel_ecc_i2c_client_alloc(void) return client; } -void atmel_ecc_i2c_client_free(struct i2c_client *client) +static void atmel_ecc_i2c_client_free(struct i2c_client *client) { struct atmel_ecc_i2c_client_priv *i2c_priv = i2c_get_clientdata(client); -- 2.11.0
next reply other threads:[~2017-07-19 9:24 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-19 9:24 Colin King [this message] 2017-07-19 9:24 ` [PATCH] Crypto: atmel-ecc: Make a couple of local functions static Colin King 2017-07-20 7:05 ` Tudor Ambarus 2017-07-20 7:05 ` Tudor Ambarus 2017-08-03 6:22 ` Herbert Xu 2017-08-03 6:22 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170719092415.9553-1-colin.king@canonical.com \ --to=colin.king@canonical.com \ --cc=davem@davemloft.net \ --cc=herbert@gondor.apana.org.au \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tudor.ambarus@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.