All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: [PATCH 9/9] drm/i915: Drop unpin stall in atomic_prepare_commit
Date: Wed, 19 Jul 2017 14:55:02 +0200	[thread overview]
Message-ID: <20170719125502.25696-10-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20170719125502.25696-1-daniel.vetter@ffwll.ch>

The core already does this in setup_commit(). With this we can also
remove the unpin_work_count since it's the last user.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c | 13 +------------
 drivers/gpu/drm/i915/intel_drv.h     |  2 --
 2 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index e52a2adbaaa5..351208b7b1ad 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11825,18 +11825,7 @@ static int intel_atomic_check(struct drm_device *dev,
 static int intel_atomic_prepare_commit(struct drm_device *dev,
 				       struct drm_atomic_state *state)
 {
-	struct drm_i915_private *dev_priv = to_i915(dev);
-	struct drm_crtc_state *crtc_state;
-	struct drm_crtc *crtc;
-	int i, ret;
-
-	for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
-		if (state->legacy_cursor_update)
-			continue;
-
-		if (atomic_read(&to_intel_crtc(crtc)->unpin_work_count) >= 2)
-			flush_workqueue(dev_priv->wq);
-	}
+	int ret;
 
 	ret = mutex_lock_interruptible(&dev->struct_mutex);
 	if (ret)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 9cb7e781e863..96402c06e295 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -798,8 +798,6 @@ struct intel_crtc {
 	unsigned long long enabled_power_domains;
 	struct intel_overlay *overlay;
 
-	atomic_t unpin_work_count;
-
 	/* Display surface base address adjustement for pageflips. Note that on
 	 * gen4+ this only adjusts up to a tile, offsets within a tile are
 	 * handled in the hw itself (with the TILEOFF register). */
-- 
2.13.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-07-19 12:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19 12:54 [PATCH 0/9] gpu reset vs modeset fix, plus page_flip removal Daniel Vetter
2017-07-19 12:54 ` [PATCH 1/9] drm/i915: Nuke legacy flip queueing code Daniel Vetter
2017-07-19 12:54 ` [PATCH 2/9] drm/i915: Unbreak gpu reset vs. modeset locking Daniel Vetter
2017-07-19 12:54 ` [PATCH 3/9] drm/i915: Avoid the gpu reset vs. modeset deadlock Daniel Vetter
2017-07-19 13:32   ` Chris Wilson
2017-07-19 13:44     ` Daniel Vetter
2017-07-19 18:44       ` Daniel Vetter
2017-07-19 12:54 ` [PATCH 4/9] drm/i915: Push i915_sw_fence_wait into the nonblocking atomic commit Daniel Vetter
2017-07-19 13:04   ` Chris Wilson
2017-07-19 13:14     ` Daniel Vetter
2017-07-19 12:54 ` [PATCH 5/9] drm/i915: More surgically unbreak the modeset vs reset deadlock Daniel Vetter
2017-07-19 13:42   ` Chris Wilson
2017-07-19 14:05     ` Daniel Vetter
2017-07-19 14:11       ` Daniel Vetter
2017-07-19 12:54 ` [PATCH 6/9] drm/i915: Rip out legacy page_flip completion/irq handling Daniel Vetter
2017-07-19 12:55 ` [PATCH 7/9] drm/i915: adjust has_pending_fb_unpin to atomic Daniel Vetter
2017-07-19 13:06   ` Chris Wilson
2017-07-19 13:15     ` Daniel Vetter
2017-07-19 14:08       ` [Intel-gfx] " Chris Wilson
2017-07-19 12:55 ` [PATCH 8/9] drm/i915: Remove intel_flip_work infrastructure Daniel Vetter
2017-07-19 13:07   ` Chris Wilson
2017-07-19 13:24     ` [Intel-gfx] " Daniel Vetter
2017-07-19 14:16       ` Chris Wilson
2017-07-19 12:55 ` Daniel Vetter [this message]
2017-07-19 13:09   ` [PATCH 9/9] drm/i915: Drop unpin stall in atomic_prepare_commit Chris Wilson
2017-07-19 13:20     ` Daniel Vetter
2017-07-19 14:01   ` Maarten Lankhorst
2017-07-20  8:46     ` Daniel Vetter
2017-07-19 14:15 ` ✓ Fi.CI.BAT: success for gpu reset vs modeset fix, plus page_flip removal Patchwork
2017-07-19 14:46   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170719125502.25696-10-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.