All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: cota@braap.org, vilanova@ac.upc.edu
Subject: [Qemu-devel] [PATCH v15 17/32] target/arm: [tcg, a64] Port to init_disas_context
Date: Mon, 24 Jul 2017 13:27:13 -0700	[thread overview]
Message-ID: <20170724202728.25960-18-rth@twiddle.net> (raw)
In-Reply-To: <20170724202728.25960-1-rth@twiddle.net>

From: Lluís Vilanova <vilanova@ac.upc.edu>

Incrementally paves the way towards using the generic instruction translation
loop.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Alex Benneé <alex.benee@linaro.org>
Message-Id: <150002340430.22386.10889954302345646107.stgit@frigg.lan>
[rth: Adjust for max_insns interface change.]
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target/arm/translate-a64.c | 38 ++++++++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 14 deletions(-)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 7e2dee59ca..2919e5a636 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -11179,21 +11179,12 @@ static void disas_a64_insn(CPUARMState *env, DisasContext *s)
     free_tmp_a64(s);
 }
 
-void gen_intermediate_code_a64(DisasContextBase *dcbase, CPUState *cs,
-                               TranslationBlock *tb)
+static int aarch64_tr_init_disas_context(DisasContextBase *dcbase,
+                                         CPUState *cpu, int max_insns)
 {
-    CPUARMState *env = cs->env_ptr;
-    ARMCPU *cpu = arm_env_get_cpu(env);
     DisasContext *dc = container_of(dcbase, DisasContext, base);
-    target_ulong next_page_start;
-    int max_insns;
-
-    dc->base.tb = tb;
-    dc->base.pc_first = dc->base.tb->pc;
-    dc->base.pc_next = dc->base.pc_first;
-    dc->base.is_jmp = DISAS_NEXT;
-    dc->base.num_insns = 0;
-    dc->base.singlestep_enabled = cs->singlestep_enabled;
+    CPUARMState *env = cpu->env_ptr;
+    ARMCPU *arm_cpu = arm_env_get_cpu(env);
 
     dc->pc = dc->base.pc_first;
     dc->condjmp = 0;
@@ -11219,7 +11210,7 @@ void gen_intermediate_code_a64(DisasContextBase *dcbase, CPUState *cs,
     dc->fp_excp_el = ARM_TBFLAG_FPEXC_EL(dc->base.tb->flags);
     dc->vec_len = 0;
     dc->vec_stride = 0;
-    dc->cp_regs = cpu->cp_regs;
+    dc->cp_regs = arm_cpu->cp_regs;
     dc->features = env->features;
 
     /* Single step state. The code-generation logic here is:
@@ -11244,6 +11235,24 @@ void gen_intermediate_code_a64(DisasContextBase *dcbase, CPUState *cs,
 
     init_tmp_a64_array(dc);
 
+    return max_insns;
+}
+
+void gen_intermediate_code_a64(DisasContextBase *dcbase, CPUState *cs,
+                               TranslationBlock *tb)
+{
+    CPUARMState *env = cs->env_ptr;
+    DisasContext *dc = container_of(dcbase, DisasContext, base);
+    target_ulong next_page_start;
+    int max_insns;
+
+    dc->base.tb = tb;
+    dc->base.pc_first = dc->base.tb->pc;
+    dc->base.pc_next = dc->base.pc_first;
+    dc->base.is_jmp = DISAS_NEXT;
+    dc->base.num_insns = 0;
+    dc->base.singlestep_enabled = cs->singlestep_enabled;
+
     next_page_start = (dc->base.pc_first & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE;
     max_insns = dc->base.tb->cflags & CF_COUNT_MASK;
     if (max_insns == 0) {
@@ -11252,6 +11261,7 @@ void gen_intermediate_code_a64(DisasContextBase *dcbase, CPUState *cs,
     if (max_insns > TCG_MAX_INSNS) {
         max_insns = TCG_MAX_INSNS;
     }
+    max_insns = aarch64_tr_init_disas_context(&dc->base, cs, max_insns);
 
     gen_tb_start(tb);
 
-- 
2.13.3

  parent reply	other threads:[~2017-07-24 20:28 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 20:26 [Qemu-devel] [PATCH v15 00/32] Generic translation framework Richard Henderson
2017-07-24 20:26 ` [Qemu-devel] [PATCH v15 01/32] tcg: Add generic DISAS_NORETURN Richard Henderson
2017-07-24 20:26 ` [Qemu-devel] [PATCH v15 02/32] target/i386: Use generic DISAS_* enumerators Richard Henderson
2017-07-24 20:26 ` [Qemu-devel] [PATCH v15 03/32] target/arm: Use DISAS_NORETURN Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 04/32] target: [tcg] Use a generic enum for DISAS_ values Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 05/32] target/arm: Delay check for magic kernel page Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 06/32] tcg: Add generic translation framework Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 07/32] target/i386: [tcg] Port to DisasContextBase Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 08/32] target/i386: [tcg] Port to init_disas_context Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 09/32] target/i386: [tcg] Port to insn_start Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 10/32] target/i386: [tcg] Port to breakpoint_check Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 11/32] target/i386: [tcg] Port to translate_insn Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 12/32] target/i386: [tcg] Port to tb_stop Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 13/32] target/i386: [tcg] Port to disas_log Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 14/32] target/i386: [tcg] Port to generic translation framework Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 15/32] target/arm: [tcg] Port to DisasContextBase Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 16/32] target/arm: [tcg] Port to init_disas_context Richard Henderson
2017-07-24 20:27 ` Richard Henderson [this message]
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 18/32] target/arm: [tcg] Port to tb_start Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 19/32] target/arm: [tcg] Port to insn_start Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 20/32] target/arm: [tcg, a64] " Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 21/32] target/arm: [tcg, a64] Port to breakpoint_check Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 22/32] target/arm: [tcg] Port to translate_insn Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 23/32] target/arm: [tcg, a64] " Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 24/32] target/arm: [tcg] Port to tb_stop Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 25/32] target/arm: [tcg, a64] " Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 26/32] target/arm: [tcg] Port to disas_log Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 27/32] target/arm: [tcg, a64] " Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 28/32] target/arm: [tcg] Port to generic translation framework Richard Henderson
2017-07-24 21:00   ` Emilio G. Cota
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 29/32] target/arm: [a64] Move page and ss checks to init_disas_context Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 30/32] target/arm: Move ss check " Richard Henderson
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 31/32] target/arm: Split out thumb_tr_translate_insn Richard Henderson
2017-07-24 21:01   ` Emilio G. Cota
2017-07-24 20:27 ` [Qemu-devel] [PATCH v15 32/32] target/arm: Perform per-insn cross-page check only for Thumb Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724202728.25960-18-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=cota@braap.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.