From: Eric Anholt <eric@anholt.net> To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, noralf@tronnes.org, Eric Anholt <eric@anholt.net> Subject: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload. Date: Wed, 2 Aug 2017 13:32:41 -0700 [thread overview] Message-ID: <20170802203242.12815-2-eric@anholt.net> (raw) In-Reply-To: <20170802203242.12815-1-eric@anholt.net> The clocks are enabled/disabled at encoder enable/disable time, not at component load. Fixes a WARN_ON at boot if V3D fails to probe. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Eric Anholt <eric@anholt.net> --- drivers/gpu/drm/vc4/vc4_dsi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 629d372633e6..13481bb6322f 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers/gpu/drm/vc4/vc4_dsi.c @@ -1641,9 +1641,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master, mipi_dsi_host_unregister(&dsi->dsi_host); - clk_disable_unprepare(dsi->pll_phy_clock); - clk_disable_unprepare(dsi->escape_clock); - if (dsi->port == 1) vc4->dsi1 = NULL; } -- 2.13.3
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net> To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload. Date: Wed, 2 Aug 2017 13:32:41 -0700 [thread overview] Message-ID: <20170802203242.12815-2-eric@anholt.net> (raw) In-Reply-To: <20170802203242.12815-1-eric@anholt.net> The clocks are enabled/disabled at encoder enable/disable time, not at component load. Fixes a WARN_ON at boot if V3D fails to probe. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Eric Anholt <eric@anholt.net> --- drivers/gpu/drm/vc4/vc4_dsi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 629d372633e6..13481bb6322f 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers/gpu/drm/vc4/vc4_dsi.c @@ -1641,9 +1641,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master, mipi_dsi_host_unregister(&dsi->dsi_host); - clk_disable_unprepare(dsi->pll_phy_clock); - clk_disable_unprepare(dsi->escape_clock); - if (dsi->port == 1) vc4->dsi1 = NULL; } -- 2.13.3 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-08-02 20:33 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-02 20:32 [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown Eric Anholt 2017-08-02 20:32 ` Eric Anholt 2017-08-02 20:32 ` Eric Anholt [this message] 2017-08-02 20:32 ` [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload Eric Anholt 2017-08-03 13:37 ` Noralf Trønnes 2017-08-04 10:02 ` Boris Brezillon 2017-08-04 10:02 ` Boris Brezillon 2017-08-02 20:32 ` [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI Eric Anholt 2017-08-02 20:32 ` Eric Anholt 2017-08-03 13:37 ` Noralf Trønnes 2017-08-04 10:08 ` Boris Brezillon 2017-08-02 20:53 ` [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown Noralf Trønnes 2017-08-02 20:53 ` Noralf Trønnes 2017-08-04 10:01 ` Boris Brezillon 2017-08-04 10:01 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170802203242.12815-2-eric@anholt.net \ --to=eric@anholt.net \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=noralf@tronnes.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.