All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: broonie@kernel.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com,
	hsweeten@visionengravers.com
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v2 4/7] spi: spi-ep93xx: absorb the interrupt enable/disable helpers
Date: Fri,  4 Aug 2017 12:00:20 +1200	[thread overview]
Message-ID: <20170804000023.15624-5-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20170804000023.15624-1-chris.packham@alliedtelesis.co.nz>

From: H Hartley Sweeten <hsweeten@visionengravers.com>

These are each only called once. Just absorb them into the callers.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
[chris: use u32 instead of unsigned int]
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 drivers/spi/spi-ep93xx.c | 32 ++++++++++++--------------------
 1 file changed, 12 insertions(+), 20 deletions(-)

diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index ce6ec164f2f2..041842e0d028 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -111,24 +111,6 @@ struct ep93xx_spi {
 /* converts bits per word to CR0.DSS value */
 #define bits_per_word_to_dss(bpw)	((bpw) - 1)
 
-static void ep93xx_spi_enable_interrupts(const struct ep93xx_spi *espi)
-{
-	u32 val;
-
-	val = readl(espi->mmio + SSPCR1);
-	val |= (SSPCR1_RORIE | SSPCR1_TIE | SSPCR1_RIE);
-	writel(val, espi->mmio + SSPCR1);
-}
-
-static void ep93xx_spi_disable_interrupts(const struct ep93xx_spi *espi)
-{
-	u32 val;
-
-	val = readl(espi->mmio + SSPCR1);
-	val &= ~(SSPCR1_RORIE | SSPCR1_TIE | SSPCR1_RIE);
-	writel(val, espi->mmio + SSPCR1);
-}
-
 /**
  * ep93xx_spi_calc_divisors() - calculates SPI clock divisors
  * @espi: ep93xx SPI controller struct
@@ -282,7 +264,12 @@ static void ep93xx_spi_pio_transfer(struct ep93xx_spi *espi)
 	 * FIFO, enable interrupts, and wait for the transfer to complete.
 	 */
 	if (ep93xx_spi_read_write(espi)) {
-		ep93xx_spi_enable_interrupts(espi);
+		u32 val;
+
+		val = readl(espi->mmio + SSPCR1);
+		val |= (SSPCR1_RORIE | SSPCR1_TIE | SSPCR1_RIE);
+		writel(val, espi->mmio + SSPCR1);
+
 		wait_for_completion(&espi->wait);
 	}
 }
@@ -604,6 +591,7 @@ static int ep93xx_spi_transfer_one_message(struct spi_master *master,
 static irqreturn_t ep93xx_spi_interrupt(int irq, void *dev_id)
 {
 	struct ep93xx_spi *espi = dev_id;
+	u32 val;
 
 	/*
 	 * If we got ROR (receive overrun) interrupt we know that something is
@@ -635,8 +623,12 @@ static irqreturn_t ep93xx_spi_interrupt(int irq, void *dev_id)
 	 * any case we disable interrupts and notify the worker to handle
 	 * any post-processing of the message.
 	 */
-	ep93xx_spi_disable_interrupts(espi);
+	val = readl(espi->mmio + SSPCR1);
+	val &= ~(SSPCR1_RORIE | SSPCR1_TIE | SSPCR1_RIE);
+	writel(val, espi->mmio + SSPCR1);
+
 	complete(&espi->wait);
+
 	return IRQ_HANDLED;
 }
 
-- 
2.13.0

  parent reply	other threads:[~2017-08-04  0:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04  0:00 [PATCH v2 0/7] spi: spi-ep93xx: cleanup and update driver to modern API Chris Packham
2017-08-04  0:00 ` Chris Packham
2017-08-04  0:00 ` [PATCH v2 1/7] spi: spi-ep93xx: remove io wrappers Chris Packham
2017-08-04  0:00   ` Chris Packham
2017-08-08  9:42   ` Mark Brown
2017-08-08  9:42     ` Mark Brown
2017-08-08 20:43     ` Chris Packham
2017-08-08 20:43       ` Chris Packham
2017-08-04  0:00 ` [PATCH v2 2/7] spi: spi-ep93xx: use 32-bit read/write for all registers Chris Packham
2017-08-04  0:00   ` Chris Packham
2017-08-09 16:57   ` Applied "spi: spi-ep93xx: use 32-bit read/write for all registers" to the spi tree Mark Brown
2017-08-04  0:00 ` [PATCH v2 3/7] spi: spi-ep93xx: add spi master prepare_transfer_hardware() Chris Packham
2017-08-09 16:57   ` Applied "spi: spi-ep93xx: add spi master prepare_transfer_hardware()" to the spi tree Mark Brown
2017-08-04  0:00 ` Chris Packham [this message]
2017-08-09 16:57   ` Applied "spi: spi-ep93xx: absorb the interrupt enable/disable helpers" " Mark Brown
2017-08-04  0:00 ` [PATCH v2 5/7] spi: spi-ep93xx: pass the spi_master pointer around Chris Packham
2017-08-09 16:57   ` Applied "spi: spi-ep93xx: pass the spi_master pointer around" to the spi tree Mark Brown
2017-08-04  0:00 ` [PATCH v2 6/7] spi: spi-ep93xx: remove private data 'current_msg' Chris Packham
2017-08-04  0:00 ` [PATCH v2 7/7] spi: spi-ep93xx: use the default master transfer queueing mechanism Chris Packham
2017-08-09 16:56   ` Applied "spi: spi-ep93xx: use the default master transfer queueing mechanism" to the spi tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170804000023.15624-5-chris.packham@alliedtelesis.co.nz \
    --to=chris.packham@alliedtelesis.co.nz \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.