From: Bart Van Assche <bart.vanassche@wdc.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Bart Van Assche <bart.vanassche@wdc.com>,
dm-devel@redhat.com, Laurence Oberman <loberman@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH 5/7] dm-mpath: Complain about unsupported __multipath_map_bio() return values
Date: Wed, 9 Aug 2017 11:32:14 -0700 [thread overview]
Message-ID: <20170809183216.526-6-bart.vanassche@wdc.com> (raw)
In-Reply-To: <20170809183216.526-1-bart.vanassche@wdc.com>
The only behavior change introduced by this patch is that WARN_ON_ONCE()
is called if __multipath_map_bio() would return an unsupported return
value.
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Laurence Oberman <loberman@redhat.com>
---
drivers/md/dm-mpath.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 6e20deac4add..f2ffa20c69b9 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -632,6 +632,11 @@ static void process_queued_bios(struct work_struct *work)
case DM_MAPIO_REMAPPED:
generic_make_request(bio);
break;
+ case 0:
+ break;
+ default:
+ WARN_ONCE(true, "__multipath_map_bio() returned %d\n",
+ r);
}
}
blk_finish_plug(&plug);
--
2.13.3
next prev parent reply other threads:[~2017-08-09 18:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 18:32 [PATCH 0/7] Device mapper and dm-mpath fixes Bart Van Assche
2017-08-09 18:32 ` [PATCH 1/7] dm: Fix the second dec_pending() argument in __split_and_process_bio() Bart Van Assche
2017-08-10 9:28 ` Christoph Hellwig
2017-08-10 14:28 ` Laurence Oberman
2017-08-10 15:02 ` Bart Van Assche
2017-08-09 18:32 ` [PATCH 2/7] dm: Fix printk() rate limiting code Bart Van Assche
2017-08-09 18:32 ` [PATCH 3/7] dm-mpath: Do not lock up a CPU with requeuing activity Bart Van Assche
2017-08-09 18:32 ` Bart Van Assche
2017-08-10 9:29 ` Christoph Hellwig
2017-08-09 18:32 ` [PATCH 4/7] dm-mpath: Avoid that building with W=1 causes gcc 7 to complain about fall-through Bart Van Assche
2017-08-10 9:29 ` Christoph Hellwig
2017-08-09 18:32 ` Bart Van Assche [this message]
2017-08-10 9:29 ` [PATCH 5/7] dm-mpath: Complain about unsupported __multipath_map_bio() return values Christoph Hellwig
2017-08-09 18:32 ` [PATCH 6/7] dm-mpath: Retry BLK_STS_RESOURCE errors Bart Van Assche
2017-08-10 9:30 ` Christoph Hellwig
2017-08-09 18:32 ` [PATCH 7/7] dm-mpath: Make the dm-sq requeuing behavior consistent with the dm-mq behavior Bart Van Assche
2017-08-10 9:30 ` Christoph Hellwig
2017-08-09 21:49 ` [PATCH 0/7] Device mapper and dm-mpath fixes Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809183216.526-6-bart.vanassche@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=loberman@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.