From: Jeffy Chen <jeffy.chen@rock-chips.com> To: linux-kernel@vger.kernel.org, bhelgaas@google.com Cc: shawn.lin@rock-chips.com, briannorris@chromium.org, dianders@chromium.org, Jeffy Chen <jeffy.chen@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Date: Thu, 17 Aug 2017 20:04:29 +0800 [thread overview] Message-ID: <20170817120431.12398-2-jeffy.chen@rock-chips.com> (raw) In-Reply-To: <20170817120431.12398-1-jeffy.chen@rock-chips.com> Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris <briannorris@chromium.com> drivers/pci/host/pcie-rockchip.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index 7bb9870f6d8c..c2b973c738fe 100644 --- a/drivers/pci/host/pcie-rockchip.c +++ b/drivers/pci/host/pcie-rockchip.c @@ -36,6 +36,7 @@ #include <linux/pci_ids.h> #include <linux/phy/phy.h> #include <linux/platform_device.h> +#include <linux/pm_wakeirq.h> #include <linux/reset.h> #include <linux/regmap.h> @@ -853,7 +854,6 @@ static void rockchip_pcie_legacy_int_handler(struct irq_desc *desc) chained_irq_exit(chip, desc); } - /** * rockchip_pcie_parse_dt - Parse Device Tree * @rockchip: PCIe port information @@ -1018,6 +1018,14 @@ static int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip) return err; } + device_init_wakeup(dev, true); + irq = platform_get_irq_byname(pdev, "wake"); + if (irq >= 0) { + err = dev_pm_set_dedicated_wake_irq(dev, irq); + if (err) + dev_err(dev, "failed to setup PCIe wake IRQ\n"); + } + rockchip->vpcie3v3 = devm_regulator_get_optional(dev, "vpcie3v3"); if (IS_ERR(rockchip->vpcie3v3)) { if (PTR_ERR(rockchip->vpcie3v3) == -EPROBE_DEFER) @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct platform_device *pdev) struct device *dev = &pdev->dev; struct rockchip_pcie *rockchip = dev_get_drvdata(dev); + dev_pm_clear_wake_irq(dev); + device_init_wakeup(dev, false); + pci_stop_root_bus(rockchip->root_bus); pci_remove_root_bus(rockchip->root_bus); pci_unmap_iospace(rockchip->io); -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (Jeffy Chen) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Date: Thu, 17 Aug 2017 20:04:29 +0800 [thread overview] Message-ID: <20170817120431.12398-2-jeffy.chen@rock-chips.com> (raw) In-Reply-To: <20170817120431.12398-1-jeffy.chen@rock-chips.com> Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris <briannorris@chromium.com> drivers/pci/host/pcie-rockchip.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index 7bb9870f6d8c..c2b973c738fe 100644 --- a/drivers/pci/host/pcie-rockchip.c +++ b/drivers/pci/host/pcie-rockchip.c @@ -36,6 +36,7 @@ #include <linux/pci_ids.h> #include <linux/phy/phy.h> #include <linux/platform_device.h> +#include <linux/pm_wakeirq.h> #include <linux/reset.h> #include <linux/regmap.h> @@ -853,7 +854,6 @@ static void rockchip_pcie_legacy_int_handler(struct irq_desc *desc) chained_irq_exit(chip, desc); } - /** * rockchip_pcie_parse_dt - Parse Device Tree * @rockchip: PCIe port information @@ -1018,6 +1018,14 @@ static int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip) return err; } + device_init_wakeup(dev, true); + irq = platform_get_irq_byname(pdev, "wake"); + if (irq >= 0) { + err = dev_pm_set_dedicated_wake_irq(dev, irq); + if (err) + dev_err(dev, "failed to setup PCIe wake IRQ\n"); + } + rockchip->vpcie3v3 = devm_regulator_get_optional(dev, "vpcie3v3"); if (IS_ERR(rockchip->vpcie3v3)) { if (PTR_ERR(rockchip->vpcie3v3) == -EPROBE_DEFER) @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct platform_device *pdev) struct device *dev = &pdev->dev; struct rockchip_pcie *rockchip = dev_get_drvdata(dev); + dev_pm_clear_wake_irq(dev); + device_init_wakeup(dev, false); + pci_stop_root_bus(rockchip->root_bus); pci_remove_root_bus(rockchip->root_bus); pci_unmap_iospace(rockchip->io); -- 2.11.0
next prev parent reply other threads:[~2017-08-17 12:05 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-17 12:04 [RFC PATCH v2 0/3] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver Jeffy Chen 2017-08-17 12:04 ` Jeffy Chen 2017-08-17 12:04 ` Jeffy Chen 2017-08-17 12:04 ` Jeffy Chen [this message] 2017-08-17 12:04 ` [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Jeffy Chen 2017-08-18 7:23 ` Shawn Lin 2017-08-18 7:23 ` Shawn Lin 2017-08-18 7:23 ` Shawn Lin 2017-08-18 8:32 ` jeffy 2017-08-18 8:32 ` jeffy 2017-08-18 8:32 ` jeffy 2017-08-18 17:01 ` Brian Norris 2017-08-18 17:01 ` Brian Norris 2017-08-18 17:01 ` Brian Norris 2017-08-18 17:07 ` Brian Norris 2017-08-18 17:07 ` Brian Norris 2017-08-18 17:07 ` Brian Norris 2017-08-18 17:47 ` jeffy 2017-08-18 17:47 ` jeffy 2017-08-18 17:47 ` jeffy 2017-08-18 18:28 ` Tony Lindgren 2017-08-18 18:28 ` Tony Lindgren 2017-08-18 18:28 ` Tony Lindgren 2017-08-18 18:14 ` Tony Lindgren 2017-08-18 18:14 ` Tony Lindgren 2017-08-18 18:14 ` Tony Lindgren 2017-08-18 20:05 ` jeffy 2017-08-18 20:05 ` jeffy 2017-08-18 20:05 ` jeffy 2017-08-22 17:26 ` Tony Lindgren 2017-08-22 17:26 ` Tony Lindgren 2017-08-22 17:26 ` Tony Lindgren 2017-08-23 1:32 ` jeffy 2017-08-23 1:32 ` jeffy 2017-08-23 1:57 ` Brian Norris 2017-08-23 1:57 ` Brian Norris 2017-08-23 1:57 ` Brian Norris 2017-08-23 2:16 ` jeffy 2017-08-23 2:16 ` jeffy 2017-08-23 2:16 ` jeffy 2017-12-19 0:48 ` Brian Norris 2017-12-19 0:48 ` Brian Norris 2017-12-19 0:48 ` Brian Norris 2017-12-20 19:19 ` Tony Lindgren 2017-12-20 19:19 ` Tony Lindgren 2017-12-22 23:20 ` Brian Norris 2017-12-22 23:20 ` Brian Norris 2017-12-22 23:20 ` Brian Norris 2017-12-23 16:36 ` Tony Lindgren 2017-12-23 16:36 ` Tony Lindgren 2017-12-23 16:36 ` Tony Lindgren 2017-08-17 12:04 ` [RFC PATCH v2 2/3] dt-bindings: " Jeffy Chen 2017-08-17 12:04 ` Jeffy Chen 2017-08-17 12:04 ` [RFC PATCH v2 3/3] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru Jeffy Chen 2017-08-17 12:04 ` Jeffy Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170817120431.12398-2-jeffy.chen@rock-chips.com \ --to=jeffy.chen@rock-chips.com \ --cc=bhelgaas@google.com \ --cc=briannorris@chromium.org \ --cc=dianders@chromium.org \ --cc=heiko@sntech.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=shawn.lin@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.