All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Carlo Caione <carlo@caione.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 15/16] mmc: meson-gx: change default tx phase
Date: Mon, 21 Aug 2017 18:03:00 +0200	[thread overview]
Message-ID: <20170821160301.21899-16-jbrunet@baylibre.com> (raw)
In-Reply-To: <20170821160301.21899-1-jbrunet@baylibre.com>

Initial default tx phase was set to 0 while the datasheet recommends 270.
Some cards fails to initialize with this setting and eMMC mode DDR52 does
not work.

Changing this setting to 270 fixes these issues, without any regression
so far

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/mmc/host/meson-gx-mmc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 3167f561e1a6..290631d46a4b 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1158,8 +1158,14 @@ static int meson_mmc_probe(struct platform_device *pdev)
 	if (ret)
 		goto free_host;
 
+        /*
+	 * Set phases : These values are mostly the datasheet recommended ones
+	 * except for the Tx phase. Datasheet recommends 180 but some cards
+	 * fail at initialisation with it. 270 works just fine, it fixes these
+	 * initialisation issues and enable eMMC DDR52 mode.
+	 */
 	host->tp.core_phase = 180;
-	host->tp.tx_phase = 0;
+	host->tp.tx_phase = 270;
 	host->tp.rx_phase = 0;
 
 	ret = meson_mmc_clk_init(host);
-- 
2.9.5

WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 15/16] mmc: meson-gx: change default tx phase
Date: Mon, 21 Aug 2017 18:03:00 +0200	[thread overview]
Message-ID: <20170821160301.21899-16-jbrunet@baylibre.com> (raw)
In-Reply-To: <20170821160301.21899-1-jbrunet@baylibre.com>

Initial default tx phase was set to 0 while the datasheet recommends 270.
Some cards fails to initialize with this setting and eMMC mode DDR52 does
not work.

Changing this setting to 270 fixes these issues, without any regression
so far

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/mmc/host/meson-gx-mmc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 3167f561e1a6..290631d46a4b 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1158,8 +1158,14 @@ static int meson_mmc_probe(struct platform_device *pdev)
 	if (ret)
 		goto free_host;
 
+        /*
+	 * Set phases : These values are mostly the datasheet recommended ones
+	 * except for the Tx phase. Datasheet recommends 180 but some cards
+	 * fail at initialisation with it. 270 works just fine, it fixes these
+	 * initialisation issues and enable eMMC DDR52 mode.
+	 */
 	host->tp.core_phase = 180;
-	host->tp.tx_phase = 0;
+	host->tp.tx_phase = 270;
 	host->tp.rx_phase = 0;
 
 	ret = meson_mmc_clk_init(host);
-- 
2.9.5

WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 15/16] mmc: meson-gx: change default tx phase
Date: Mon, 21 Aug 2017 18:03:00 +0200	[thread overview]
Message-ID: <20170821160301.21899-16-jbrunet@baylibre.com> (raw)
In-Reply-To: <20170821160301.21899-1-jbrunet@baylibre.com>

Initial default tx phase was set to 0 while the datasheet recommends 270.
Some cards fails to initialize with this setting and eMMC mode DDR52 does
not work.

Changing this setting to 270 fixes these issues, without any regression
so far

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/mmc/host/meson-gx-mmc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 3167f561e1a6..290631d46a4b 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1158,8 +1158,14 @@ static int meson_mmc_probe(struct platform_device *pdev)
 	if (ret)
 		goto free_host;
 
+        /*
+	 * Set phases : These values are mostly the datasheet recommended ones
+	 * except for the Tx phase. Datasheet recommends 180 but some cards
+	 * fail at initialisation with it. 270 works just fine, it fixes these
+	 * initialisation issues and enable eMMC DDR52 mode.
+	 */
 	host->tp.core_phase = 180;
-	host->tp.tx_phase = 0;
+	host->tp.tx_phase = 270;
 	host->tp.rx_phase = 0;
 
 	ret = meson_mmc_clk_init(host);
-- 
2.9.5

  parent reply	other threads:[~2017-08-21 16:03 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21 16:02 [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades Jerome Brunet
2017-08-21 16:02 ` Jerome Brunet
2017-08-21 16:02 ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 01/16] mmc: meson-gx: fix mux mask definition Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 02/16] mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 03/16] mmc: meson-gx: clean up some constants Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 04/16] mmc: meson-gx: use _irqsave variant of spinlock Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-22 11:08   ` Ulf Hansson
2017-08-22 11:08     ` Ulf Hansson
2017-08-22 11:08     ` Ulf Hansson
2017-08-22 11:08     ` Ulf Hansson
2017-08-22 11:41     ` Jerome Brunet
2017-08-22 11:41       ` Jerome Brunet
2017-08-22 11:41       ` Jerome Brunet
2017-08-22 11:41       ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 05/16] mmc: meson-gx: cfg init overwrite values Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 06/16] mmc: meson-gx: rework set_ios function Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 07/16] mmc: meson-gx: rework clk_set function Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 08/16] mmc: meson-gx: rework clock init function Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 09/16] mmc: meson-gx: fix dual data rate mode frequencies Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 10/16] mmc: meson-gx: work around clk-stop issue Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 11/16] mmc: meson-gx: simplify interrupt handler Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 12/16] mmc: meson-gx: implement card_busy callback Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02 ` [PATCH v2 13/16] mmc: meson-gx: use CCF to handle the clock phases Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-25  0:04   ` Kevin Hilman
2017-08-25  0:04     ` Kevin Hilman
2017-08-25  0:04     ` Kevin Hilman
2017-08-21 16:02 ` [PATCH v2 14/16] mmc: meson-gx: implement voltage switch callback Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:02   ` Jerome Brunet
2017-08-21 16:03 ` Jerome Brunet [this message]
2017-08-21 16:03   ` [PATCH v2 15/16] mmc: meson-gx: change default tx phase Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-25  0:05   ` Kevin Hilman
2017-08-25  0:05     ` Kevin Hilman
2017-08-25  0:05     ` Kevin Hilman
2017-08-21 16:03 ` [PATCH v2 16/16] mmc: meson-gx: rework tuning function Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-21 16:03   ` Jerome Brunet
2017-08-22 11:15 ` [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades Ulf Hansson
2017-08-22 11:15   ` Ulf Hansson
2017-08-22 11:15   ` Ulf Hansson
2017-08-22 11:15   ` Ulf Hansson
2017-08-22 11:46   ` Jerome Brunet
2017-08-22 11:46     ` Jerome Brunet
2017-08-22 11:46     ` Jerome Brunet
2017-08-22 11:46     ` Jerome Brunet
2017-08-23 13:10     ` Ulf Hansson
2017-08-23 13:10       ` Ulf Hansson
2017-08-23 13:10       ` Ulf Hansson
2017-08-23 13:10       ` Ulf Hansson
2017-08-25  0:05       ` Kevin Hilman
2017-08-25  0:05         ` Kevin Hilman
2017-08-25  0:05         ` Kevin Hilman
2017-08-25  0:05         ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821160301.21899-16-jbrunet@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=carlo@caione.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.