All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: "Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 03/17] ARM: dts: Add missing properties for omap4 control modules
Date: Mon, 28 Aug 2017 14:19:04 -0700	[thread overview]
Message-ID: <20170828211918.11573-4-tony@atomide.com> (raw)
In-Reply-To: <20170828211918.11573-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>

On omap4, we are missing several ti,hwmods properties and IO
ranges for system control modules. These are needed by the SoC
interconnect code.

Note that this will only show up as a bug with "doesn't have
mpu register target base" boot errors when the legacy platform
data is removed.

In order to add these, we need to move omap4_pmx_wkup to be a
child of omap4_padconf_wkup.

On omap4 there are separate modules for control module and
control module pads. For control module core, we have this
already configured except for the missing ti,hwmods and reg
entries.

Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
---
 .../devicetree/bindings/arm/omap/ctrl.txt          |  2 ++
 arch/arm/boot/dts/omap4.dtsi                       | 39 ++++++++++++++++------
 2 files changed, 31 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/omap/ctrl.txt b/Documentation/devicetree/bindings/arm/omap/ctrl.txt
--- a/Documentation/devicetree/bindings/arm/omap/ctrl.txt
+++ b/Documentation/devicetree/bindings/arm/omap/ctrl.txt
@@ -21,6 +21,8 @@ Required properties:
 		"ti,omap3-scm"
 		"ti,omap4-scm-core"
 		"ti,omap4-scm-padconf-core"
+		"ti,omap4-scm-wkup"
+		"ti,omap4-scm-padconf-wkup"
 		"ti,omap5-scm-core"
 		"ti,omap5-scm-padconf-core"
 		"ti,dra7-scm-core"
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -174,6 +174,7 @@
 				#address-cells = <1>;
 				#size-cells = <1>;
 				ranges = <0 0x2000 0x1000>;
+				ti,hwmods = "ctrl_module_core";
 
 				scm_conf: scm_conf@0 {
 					compatible = "syscon";
@@ -186,9 +187,11 @@
 			omap4_padconf_core: scm@100000 {
 				compatible = "ti,omap4-scm-padconf-core",
 					     "simple-bus";
+				reg = <0x100000 0x1000>;
 				#address-cells = <1>;
 				#size-cells = <1>;
 				ranges = <0 0x100000 0x1000>;
+				ti,hwmods = "ctrl_module_pad_core";
 
 				omap4_pmx_core: pinmux@40 {
 					compatible = "ti,omap4-padconf",
@@ -263,17 +266,33 @@
 					};
 				};
 
-				omap4_pmx_wkup: pinmux@1e040 {
-					compatible = "ti,omap4-padconf",
-						     "pinctrl-single";
-					reg = <0x1e040 0x0038>;
+				omap4_scm_wkup: scm@c000 {
+					compatible = "ti,omap4-scm-wkup";
+					reg = <0xc000 0x1000>;
+					ti,hwmods = "ctrl_module_wkup";
+				};
+
+				omap4_padconf_wkup: padconf@1e000 {
+					compatible = "ti,omap4-scm-padconf-wkup",
+						     "simple-bus";
+					reg = <0x1e000 0x1000>;
 					#address-cells = <1>;
-					#size-cells = <0>;
-					#pinctrl-cells = <1>;
-					#interrupt-cells = <1>;
-					interrupt-controller;
-					pinctrl-single,register-width = <16>;
-					pinctrl-single,function-mask = <0x7fff>;
+					#size-cells = <1>;
+					ranges = <0 0x1e000 0x1000>;
+					ti,hwmods = "ctrl_module_pad_wkup";
+
+					omap4_pmx_wkup: pinmux@40 {
+						compatible = "ti,omap4-padconf",
+							     "pinctrl-single";
+						reg = <0x40 0x0038>;
+						#address-cells = <1>;
+						#size-cells = <0>;
+						#pinctrl-cells = <1>;
+						#interrupt-cells = <1>;
+						interrupt-controller;
+						pinctrl-single,register-width = <16>;
+						pinctrl-single,function-mask = <0x7fff>;
+					};
 				};
 			};
 		};
-- 
2.14.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-08-28 21:19 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 21:19 [PATCH 00/17] Fix missing device tree hwmods and IO ranges omap variants Tony Lindgren
     [not found] ` <20170828211918.11573-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-28 21:19   ` [PATCH 01/17] ARM: dts: Add missing dma hwmods property for omap3 Tony Lindgren
2017-08-28 21:19   ` [PATCH 02/17] ARM: dts: Configure pmu without interrupt for omap4430 Tony Lindgren
2017-08-28 21:19   ` Tony Lindgren [this message]
2017-08-28 21:19   ` [PATCH 04/17] ARM: dts: Add missing hwmods property for omap4 dma Tony Lindgren
2017-08-28 21:19   ` [PATCH 05/17] ARM: dts: Add missing smartreflex node and binding for omap4 Tony Lindgren
2017-08-28 21:19   ` [PATCH 06/17] ARM: dts: Add missing slimbus " Tony Lindgren
2017-08-28 21:19   ` [PATCH 07/17] ARM: dts: Add missing onewire node " Tony Lindgren
2017-08-28 21:19   ` [PATCH 08/17] ARM: dts: Add missing hsi " Tony Lindgren
     [not found]     ` <20170828211918.11573-9-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29  9:18       ` Sebastian Reichel
2017-08-29 14:20         ` Tony Lindgren
2017-08-28 21:19   ` [PATCH 09/17] ARM: dts: Add missing iss node and binding " Tony Lindgren
     [not found]     ` <20170828211918.11573-10-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 12:37       ` Laurent Pinchart
2017-08-29 14:22         ` Tony Lindgren
2017-08-28 21:19   ` [PATCH 10/17] ARM: dts: Add missing wdt3 node " Tony Lindgren
2017-08-28 21:19   ` [PATCH 11/17] ARM: dts: Add missing mcasp " Tony Lindgren
     [not found]     ` <20170828211918.11573-12-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-09-04  6:55       ` Peter Ujfalusi
2017-08-28 21:19   ` [PATCH 12/17] ARM: dts: Add missing aess node and binding " Tony Lindgren
2017-08-28 21:19   ` [PATCH 13/17] ARM: dts: Add missing fdif " Tony Lindgren
     [not found]     ` <20170828211918.11573-14-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 12:48       ` Laurent Pinchart
2017-08-29 14:29         ` Tony Lindgren
     [not found]           ` <20170829142941.GU6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 17:13             ` Laurent Pinchart
2017-08-29 19:01               ` Tony Lindgren
2017-08-28 21:19   ` [PATCH 14/17] ARM: dts: Add missing gpu " Tony Lindgren
     [not found]     ` <20170828211918.11573-15-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29  9:00       ` Sebastian Reichel
2017-08-29 11:35         ` Tomi Valkeinen
     [not found]           ` <201708291135.v7TBZCHH020827-mYkuYio3Bc71T2qfsofKZtBPR1lH4CV8@public.gmane.org>
2017-08-29 12:10             ` Sebastian Reichel
2017-08-29 12:24               ` Tomi Valkeinen
     [not found]                 ` <e0c6447f-5a0f-b43a-7087-5ee37af2a1c1-l0cyMroinI0@public.gmane.org>
2017-08-29 14:34                   ` Tony Lindgren
     [not found]                     ` <20170829143453.GV6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 15:57                       ` Tony Lindgren
     [not found]                         ` <20170829155738.GB6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 16:26                           ` Tony Lindgren
2017-08-29 12:27               ` Tomi Valkeinen
     [not found]                 ` <5efc9078-5886-5826-834e-facd67ddfbe5-l0cyMroinI0@public.gmane.org>
2017-08-29 14:37                   ` Tony Lindgren
2017-08-29 14:42         ` Tony Lindgren
     [not found]           ` <20170829144205.GX6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 15:31             ` Adam Ford
     [not found]               ` <CAHCN7xK7Vy8Hw1OV3AQb4vAo3n=6qfE_8xunL1MXQaTLY0Yy4w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-29 15:35                 ` Tony Lindgren
2017-08-28 21:19   ` [PATCH 15/17] ARM: dts: Add missing dma hwmod property for omap5 Tony Lindgren
2017-08-28 21:19   ` [PATCH 16/17] ARM: dts: Add missing hwmod related nodes for am33xx Tony Lindgren
2017-08-28 21:19   ` [PATCH 17/17] ARM: dts: Add missing hwmod related properties for dra7 Tony Lindgren
     [not found]     ` <20170828211918.11573-18-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-28 21:34       ` Nishanth Menon
     [not found]         ` <8c0ecbf6-26fb-1998-6bb5-0a74d9daa2ab-l0cyMroinI0@public.gmane.org>
2017-08-28 21:37           ` Tony Lindgren
     [not found]             ` <20170828213753.GP6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-28 21:52               ` Nishanth Menon
     [not found]                 ` <fd064c10-2051-1579-bde1-60c3fed2b4a0-l0cyMroinI0@public.gmane.org>
2017-08-28 22:27                   ` Tony Lindgren
2017-08-30 15:19 [PATCHv2 00/17] Fix missing device tree hwmods and IO ranges omap variants Tony Lindgren
     [not found] ` <20170830151953.30856-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-30 15:19   ` [PATCH 03/17] ARM: dts: Add missing properties for omap4 control modules Tony Lindgren
     [not found]     ` <20170830151953.30856-4-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-09-11 21:08       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828211918.11573-4-tony@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.