All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Cc: "Jason Cooper" <jason@lakedaemon.net>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Gregory Clement" <gregory.clement@free-electrons.com>,
	"Nadav Haklai" <nadavh@marvell.com>,
	"Hanna Hawa" <hannah@marvell.com>,
	"Yehuda Yitschak" <yehuday@marvell.com>,
	linux-arm-kernel@lists.infradead.org,
	"Antoine Tenart" <antoine.tenart@free-electrons.com>,
	"Miquèl Raynal" <miquel.raynal@free-electrons.com>,
	"Victor Gu" <xigu@marvell.com>,
	"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
Subject: [PATCH v2 5/7] PCI: aardvark: disable LOS state by default
Date: Thu, 28 Sep 2017 14:58:36 +0200	[thread overview]
Message-ID: <20170928125838.11887-6-thomas.petazzoni@free-electrons.com> (raw)
In-Reply-To: <20170928125838.11887-1-thomas.petazzoni@free-electrons.com>

From: Victor Gu <xigu@marvell.com>

Some PCIe devices do not support LOS, and will cause timeouts if the
root complex forces the LOS state. This patch disables the LOS state
by default.

This is part of fixing bug
https://bugzilla.kernel.org/show_bug.cgi?id=196339, this commit was
reported as the user to be important to get a Intel 7260 mini-PCIe
WiFi card working.

Fixes: 8c39d710363c1 ("PCI: aardvark: Add Aardvark PCI host controller driver")
Signed-off-by: Victor Gu <xigu@marvell.com>
Reviewed-by: Evan Wang <xswang@marvell.com>
Reviewed-by: Nadav Haklai <nadavh@marvell.com>
[Thomas: tweak commit log.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 drivers/pci/host/pci-aardvark.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
index 23e243135ebe..a173f31853df 100644
--- a/drivers/pci/host/pci-aardvark.c
+++ b/drivers/pci/host/pci-aardvark.c
@@ -368,8 +368,7 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie)
 
 	advk_pcie_wait_for_link(pcie);
 
-	reg = PCIE_CORE_LINK_L0S_ENTRY |
-		(1 << PCIE_CORE_LINK_WIDTH_SHIFT);
+	reg = (1 << PCIE_CORE_LINK_WIDTH_SHIFT);
 	advk_writel(pcie, reg, PCIE_CORE_LINK_CTRL_STAT_REG);
 
 	reg = advk_readl(pcie, PCIE_CORE_CMD_STATUS_REG);
-- 
2.13.5

WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/7] PCI: aardvark: disable LOS state by default
Date: Thu, 28 Sep 2017 14:58:36 +0200	[thread overview]
Message-ID: <20170928125838.11887-6-thomas.petazzoni@free-electrons.com> (raw)
In-Reply-To: <20170928125838.11887-1-thomas.petazzoni@free-electrons.com>

From: Victor Gu <xigu@marvell.com>

Some PCIe devices do not support LOS, and will cause timeouts if the
root complex forces the LOS state. This patch disables the LOS state
by default.

This is part of fixing bug
https://bugzilla.kernel.org/show_bug.cgi?id=196339, this commit was
reported as the user to be important to get a Intel 7260 mini-PCIe
WiFi card working.

Fixes: 8c39d710363c1 ("PCI: aardvark: Add Aardvark PCI host controller driver")
Signed-off-by: Victor Gu <xigu@marvell.com>
Reviewed-by: Evan Wang <xswang@marvell.com>
Reviewed-by: Nadav Haklai <nadavh@marvell.com>
[Thomas: tweak commit log.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 drivers/pci/host/pci-aardvark.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
index 23e243135ebe..a173f31853df 100644
--- a/drivers/pci/host/pci-aardvark.c
+++ b/drivers/pci/host/pci-aardvark.c
@@ -368,8 +368,7 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie)
 
 	advk_pcie_wait_for_link(pcie);
 
-	reg = PCIE_CORE_LINK_L0S_ENTRY |
-		(1 << PCIE_CORE_LINK_WIDTH_SHIFT);
+	reg = (1 << PCIE_CORE_LINK_WIDTH_SHIFT);
 	advk_writel(pcie, reg, PCIE_CORE_LINK_CTRL_STAT_REG);
 
 	reg = advk_readl(pcie, PCIE_CORE_CMD_STATUS_REG);
-- 
2.13.5

  parent reply	other threads:[~2017-09-28 12:58 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28 12:58 [PATCH v2 0/7] PCI: aardvark: improve compatibility with PCI devices Thomas Petazzoni
2017-09-28 12:58 ` Thomas Petazzoni
2017-09-28 12:58 ` [PATCH v2 1/7] PCI: aardvark: fix logic in PCI configuration read/write functions Thomas Petazzoni
2017-09-28 12:58   ` Thomas Petazzoni
2017-09-28 12:58   ` Thomas Petazzoni
2017-10-05 17:23   ` Bjorn Helgaas
2017-10-05 17:23     ` Bjorn Helgaas
2017-10-05 17:23     ` Bjorn Helgaas
2018-01-09 16:49     ` Thomas Petazzoni
2018-01-09 16:49       ` Thomas Petazzoni
2018-01-10  1:11       ` Bjorn Helgaas
2018-01-10  1:11         ` Bjorn Helgaas
2018-01-10  1:11         ` Bjorn Helgaas
2017-10-09  7:59   ` Mason
2017-09-28 12:58 ` [PATCH v2 2/7] PCI: aardvark: set PIO_ADDR_LS correctly in advk_pcie_rd_conf() Thomas Petazzoni
2017-09-28 12:58   ` Thomas Petazzoni
2017-09-28 12:58   ` Thomas Petazzoni
2017-10-05 17:25   ` Bjorn Helgaas
2017-10-05 17:25     ` Bjorn Helgaas
2018-01-09 16:10     ` Thomas Petazzoni
2018-01-09 16:10       ` Thomas Petazzoni
2017-09-28 12:58 ` [PATCH v2 3/7] PCI: aardvark: set host and device to the same MAX payload size Thomas Petazzoni
2017-09-28 12:58   ` Thomas Petazzoni
2017-10-05 17:31   ` Bjorn Helgaas
2017-10-05 17:31     ` Bjorn Helgaas
2018-01-09 15:39     ` Thomas Petazzoni
2018-01-09 15:39       ` Thomas Petazzoni
2018-01-09 22:14       ` Bjorn Helgaas
2018-01-09 22:14         ` Bjorn Helgaas
2018-01-12 10:14         ` Thomas Petazzoni
2018-01-12 10:14           ` Thomas Petazzoni
2018-01-12 14:40           ` Bjorn Helgaas
2018-01-12 14:40             ` Bjorn Helgaas
2018-01-12 15:46             ` Thomas Petazzoni
2018-01-12 15:46               ` Thomas Petazzoni
2018-01-12 19:39               ` Bjorn Helgaas
2018-01-12 19:39                 ` Bjorn Helgaas
2017-09-28 12:58 ` [PATCH v2 4/7] PCI: aardvark: use isr1 instead of isr0 interrupt in legacy irq mode Thomas Petazzoni
2017-09-28 12:58   ` Thomas Petazzoni
2017-09-28 12:58 ` Thomas Petazzoni [this message]
2017-09-28 12:58   ` [PATCH v2 5/7] PCI: aardvark: disable LOS state by default Thomas Petazzoni
2017-10-05 17:46   ` Bjorn Helgaas
2017-10-05 17:46     ` Bjorn Helgaas
2017-10-09  6:54     ` Thomas Petazzoni
2017-10-09  6:54       ` Thomas Petazzoni
2017-09-28 12:58 ` [PATCH v2 6/7] PCI: aardvark: fix PCIe max read request size setting Thomas Petazzoni
2017-09-28 12:58   ` Thomas Petazzoni
2017-09-28 12:58 ` [PATCH v2 7/7] PCI: aardvark: define IRQ related hooks in pci_host_bridge Thomas Petazzoni
2017-09-28 12:58   ` Thomas Petazzoni
2017-10-05 17:55   ` Bjorn Helgaas
2017-10-05 17:55     ` Bjorn Helgaas
2017-10-05 17:55     ` Bjorn Helgaas
2017-10-05 19:25     ` Thomas Petazzoni
2017-10-05 19:25       ` Thomas Petazzoni
2017-10-05 15:53 ` [PATCH v2 0/7] PCI: aardvark: improve compatibility with PCI devices Thomas Petazzoni
2017-10-05 15:53   ` Thomas Petazzoni
2017-10-05 18:16   ` Bjorn Helgaas
2017-10-05 18:16     ` Bjorn Helgaas
2017-10-05 19:35     ` Thomas Petazzoni
2017-10-05 19:35       ` Thomas Petazzoni
2017-10-06  8:47     ` Lorenzo Pieralisi
2017-10-06  8:47       ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170928125838.11887-6-thomas.petazzoni@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@free-electrons.com \
    --cc=bhelgaas@google.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=hannah@marvell.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=miquel.raynal@free-electrons.com \
    --cc=nadavh@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=xigu@marvell.com \
    --cc=yehuday@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.