From: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr> To: Peter Huewe <peterhuewe@gmx.de>, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Cc: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/18] tpm: use ARRAY_SIZE Date: Sun, 1 Oct 2017 15:30:51 -0400 [thread overview] Message-ID: <20171001193101.8898-14-jeremy.lefaure@lse.epita.fr> (raw) In-Reply-To: <20171001193101.8898-1-jeremy.lefaure@lse.epita.fr> Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/char/tpm/tpm_tis.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index ebd0e75a3e4d..e2d1055fb814 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -30,6 +30,7 @@ #include <linux/freezer.h> #include <linux/of.h> #include <linux/of_device.h> +#include <linux/kernel.h> #include "tpm.h" #include "tpm_tis_core.h" @@ -365,7 +366,7 @@ static struct pnp_driver tis_pnp_driver = { }, }; -#define TIS_HID_USR_IDX sizeof(tpm_pnp_tbl)/sizeof(struct pnp_device_id) -2 +#define TIS_HID_USR_IDX (ARRAY_SIZE(tpm_pnp_tbl) - 2) module_param_string(hid, tpm_pnp_tbl[TIS_HID_USR_IDX].id, sizeof(tpm_pnp_tbl[TIS_HID_USR_IDX].id), 0444); MODULE_PARM_DESC(hid, "Set additional specific HID for this driver to probe"); -- 2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr> To: Peter Huewe <peterhuewe@gmx.de>, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Cc: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/18] tpm: use ARRAY_SIZE Date: Sun, 1 Oct 2017 15:30:51 -0400 [thread overview] Message-ID: <20171001193101.8898-14-jeremy.lefaure@lse.epita.fr> (raw) In-Reply-To: <20171001193101.8898-1-jeremy.lefaure@lse.epita.fr> Using the ARRAY_SIZE macro improves the readability of the code. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p /sizeof(*E)) | (sizeof(E)@p /sizeof(E[...])) | (sizeof(E)@p /sizeof(T)) ) Signed-off-by: Jeremy Lefaure <jeremy.lefaure@lse.epita.fr> --- drivers/char/tpm/tpm_tis.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index ebd0e75a3e4d..e2d1055fb814 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -30,6 +30,7 @@ #include <linux/freezer.h> #include <linux/of.h> #include <linux/of_device.h> +#include <linux/kernel.h> #include "tpm.h" #include "tpm_tis_core.h" @@ -365,7 +366,7 @@ static struct pnp_driver tis_pnp_driver = { }, }; -#define TIS_HID_USR_IDX sizeof(tpm_pnp_tbl)/sizeof(struct pnp_device_id) -2 +#define TIS_HID_USR_IDX (ARRAY_SIZE(tpm_pnp_tbl) - 2) module_param_string(hid, tpm_pnp_tbl[TIS_HID_USR_IDX].id, sizeof(tpm_pnp_tbl[TIS_HID_USR_IDX].id), 0444); MODULE_PARM_DESC(hid, "Set additional specific HID for this driver to probe"); -- 2.14.1
next prev parent reply other threads:[~2017-10-01 19:32 UTC|newest] Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 01/18] sound: use ARRAY_SIZE Jérémy Lefaure 2017-10-02 4:16 ` Joe Perches 2017-10-03 1:12 ` Jérémy Lefaure 2017-10-03 1:12 ` Jérémy Lefaure 2017-10-03 7:03 ` Takashi Iwai 2017-10-03 7:03 ` Takashi Iwai 2017-10-01 19:30 ` [PATCH 02/18] tracing/filter: " Jérémy Lefaure 2017-10-04 1:05 ` Steven Rostedt 2017-10-01 19:30 ` [PATCH 03/18] media: " Jérémy Lefaure 2017-10-02 10:34 ` Michael Ira Krufky 2017-10-01 19:30 ` [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE Jérémy Lefaure [not found] ` <20171001193101.8898-5-jeremy.lefaure-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org> 2017-10-02 4:38 ` Leon Romanovsky 2017-10-02 4:38 ` Leon Romanovsky 2017-10-01 19:30 ` [PATCH 05/18] net: use ARRAY_SIZE Jérémy Lefaure 2017-10-01 19:30 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure 2017-10-02 13:07 ` Andy Shevchenko 2017-10-02 13:07 ` [Intel-wired-lan] " Andy Shevchenko 2017-10-02 13:07 ` Andy Shevchenko 2017-10-02 13:07 ` Andy Shevchenko 2017-10-03 1:22 ` Jérémy Lefaure 2017-10-03 1:22 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure 2017-10-03 1:22 ` Jérémy Lefaure 2017-10-03 1:22 ` Jérémy Lefaure 2017-10-03 8:09 ` Andy Shevchenko 2017-10-03 8:09 ` [Intel-wired-lan] " Andy Shevchenko 2017-10-03 8:09 ` Andy Shevchenko 2017-10-03 8:09 ` Andy Shevchenko 2017-10-02 13:46 ` Kalle Valo 2017-10-02 13:46 ` [Intel-wired-lan] " Kalle Valo 2017-10-02 13:46 ` Kalle Valo 2017-10-02 13:46 ` Kalle Valo 2017-10-03 1:23 ` Jérémy Lefaure 2017-10-03 1:23 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure 2017-10-03 1:23 ` Jérémy Lefaure 2017-11-14 3:19 ` [PATCH v2] wireless: " Jérémy Lefaure 2017-12-08 13:20 ` [v2] " Kalle Valo 2017-11-14 3:24 ` [PATCH v2] net: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 06/18] drm: " Jérémy Lefaure 2017-10-02 7:43 ` Jani Nikula 2017-10-02 7:43 ` Jani Nikula 2017-10-02 8:27 ` Thierry Reding 2017-10-02 8:27 ` Thierry Reding 2017-10-01 19:30 ` [PATCH 07/18] scsi: bfa: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 08/18] ecryptfs: " Jérémy Lefaure 2017-10-14 1:31 ` Tyler Hicks 2017-10-01 19:30 ` [PATCH 09/18] nfsd: " Jérémy Lefaure 2017-10-02 11:03 ` Jeff Layton 2017-10-01 19:30 ` [PATCH 10/18] orangefs: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 11/18] dm space map metadata: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 12/18] x86: " Jérémy Lefaure 2017-10-19 14:18 ` [tip:x86/cleanups] x86: Use ARRAY_SIZE tip-bot for Jérémy Lefaure 2017-10-01 19:30 ` Jérémy Lefaure [this message] 2017-10-01 19:30 ` [PATCH 13/18] tpm: use ARRAY_SIZE Jérémy Lefaure 2017-10-04 12:14 ` Jarkko Sakkinen 2017-10-04 12:14 ` Jarkko Sakkinen 2017-10-10 20:30 ` Jérémy Lefaure 2017-10-10 20:30 ` Jérémy Lefaure 2017-10-11 11:48 ` Jarkko Sakkinen 2017-10-11 11:48 ` Jarkko Sakkinen 2017-10-01 19:30 ` [PATCH 14/18] ipmi: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 15/18] acpi: " Jérémy Lefaure 2017-10-02 12:27 ` Rafael J. Wysocki 2017-10-02 12:27 ` [Devel] " Rafael J. Wysocki 2017-10-03 1:16 ` Jérémy Lefaure 2017-10-03 11:39 ` Rafael J. Wysocki 2017-10-03 11:39 ` [Devel] " Rafael J. Wysocki 2017-10-03 12:34 ` Colin Ian King 2017-10-03 12:34 ` Colin Ian King 2017-10-03 16:04 ` Rafael J. Wysocki 2017-10-03 16:04 ` Rafael J. Wysocki 2017-10-03 16:38 ` Moore, Robert 2017-10-03 16:38 ` Moore, Robert 2017-10-01 19:30 ` [PATCH 16/18] media: staging: atomisp: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 17/18] staging: rtl8723bs: " Jérémy Lefaure 2017-10-01 19:30 ` [PATCH 18/18] staging: rtlwifi: " Jérémy Lefaure 2017-10-01 22:01 ` [PATCH 00/18] use ARRAY_SIZE macro Tobin C. Harding 2017-10-01 22:01 ` [Intel-wired-lan] " Tobin C. Harding 2017-10-01 22:01 ` Tobin C. Harding 2017-10-01 22:01 ` Tobin C. Harding 2017-10-02 0:52 ` Jérémy Lefaure 2017-10-02 0:52 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure 2017-10-02 0:52 ` Jérémy Lefaure 2017-10-02 0:52 ` Jérémy Lefaure 2017-10-02 0:52 ` Jérémy Lefaure 2017-10-02 5:35 ` Greg KH 2017-10-02 5:35 ` [Intel-wired-lan] " Greg KH 2017-10-02 5:35 ` Greg KH 2017-10-02 5:35 ` Greg KH 2017-10-02 19:22 ` J. Bruce Fields 2017-10-02 19:22 ` [Intel-wired-lan] " J. Bruce Fields 2017-10-02 19:22 ` J. Bruce Fields 2017-10-02 19:22 ` J. Bruce Fields 2017-10-03 1:33 ` Jérémy Lefaure 2017-10-03 1:33 ` Jérémy Lefaure 2017-10-03 1:33 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure 2017-10-03 1:33 ` Jérémy Lefaure 2017-10-03 1:33 ` Jérémy Lefaure 2017-10-03 1:33 ` Jérémy Lefaure 2017-10-05 17:57 ` J. Bruce Fields 2017-10-05 17:57 ` [Intel-wired-lan] " J. Bruce Fields 2017-10-05 17:57 ` J. Bruce Fields 2017-10-05 17:57 ` J. Bruce Fields 2017-10-02 16:37 ` Mauro Carvalho Chehab 2017-10-02 16:37 ` [Intel-wired-lan] " Mauro Carvalho Chehab 2017-10-02 16:37 ` Mauro Carvalho Chehab 2017-10-02 16:37 ` Mauro Carvalho Chehab 2017-10-02 17:05 ` Zhi Wang 2017-10-02 17:05 ` [Intel-wired-lan] [Intel-gfx] " Zhi Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171001193101.8898-14-jeremy.lefaure@lse.epita.fr \ --to=jeremy.lefaure@lse.epita.fr \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=jgunthorpe@obsidianresearch.com \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=peterhuewe@gmx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.