[PATCH 02/11] x86: make dma_cache_sync a no-op

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Christoph Hellwig <hch@lst.de>
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: Chris Zankel <chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org>,
	Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>,
	linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
	linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-xtensa-PjhNF2WwrV/0Sa2dR60CXw@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Max Filippov <jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Guan Xuetao <gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org>
Subject: [PATCH 02/11] x86: make dma_cache_sync a no-op
Date: Tue, 03 Oct 2017 10:43:02 +0000	[thread overview]
Message-ID: <20171003104311.10058-3-hch@lst.de> (raw)
In-Reply-To: <20171003104311.10058-1-hch-jcswGhMUV9g@public.gmane.org>

x86 does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't
make any sense to do any work in dma_cache_sync given that it must be a
no-op when dma_alloc_attrs returns coherent memory.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/include/asm/dma-mapping.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
index 1387dafdba2d..c6d3367be916 100644
--- a/arch/x86/include/asm/dma-mapping.h
+++ b/arch/x86/include/asm/dma-mapping.h
@@ -71,7 +71,6 @@ static inline void
 dma_cache_sync(struct device *dev, void *vaddr, size_t size,
 	enum dma_data_direction dir)
 {
-	flush_write_buffers();
 }
 
 static inline unsigned long dma_alloc_coherent_mask(struct device *dev,
-- 
2.14.1

WARNING: multiple messages have this Message-ID (diff)

From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Michal Simek <monstr@monstr.eu>,
	David Howells <dhowells@redhat.com>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,
	x86@kernel.org, linux-mips@linux-mips.org,
	linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 02/11] x86: make dma_cache_sync a no-op
Date: Tue,  3 Oct 2017 12:43:02 +0200	[thread overview]
Message-ID: <20171003104311.10058-3-hch@lst.de> (raw)
In-Reply-To: <20171003104311.10058-1-hch@lst.de>

x86 does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't
make any sense to do any work in dma_cache_sync given that it must be a
no-op when dma_alloc_attrs returns coherent memory.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/include/asm/dma-mapping.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
index 1387dafdba2d..c6d3367be916 100644
--- a/arch/x86/include/asm/dma-mapping.h
+++ b/arch/x86/include/asm/dma-mapping.h
@@ -71,7 +71,6 @@ static inline void
 dma_cache_sync(struct device *dev, void *vaddr, size_t size,
 	enum dma_data_direction dir)
 {
-	flush_write_buffers();
 }
 
 static inline unsigned long dma_alloc_coherent_mask(struct device *dev,
-- 
2.14.1

WARNING: multiple messages have this Message-ID (diff)

From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: Chris Zankel <chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org>,
	Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>,
	linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
	linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-xtensa-PjhNF2WwrV/0Sa2dR60CXw@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Max Filippov <jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Guan Xuetao <gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org>
Subject: [PATCH 02/11] x86: make dma_cache_sync a no-op
Date: Tue,  3 Oct 2017 12:43:02 +0200	[thread overview]
Message-ID: <20171003104311.10058-3-hch@lst.de> (raw)
In-Reply-To: <20171003104311.10058-1-hch-jcswGhMUV9g@public.gmane.org>

x86 does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't
make any sense to do any work in dma_cache_sync given that it must be a
no-op when dma_alloc_attrs returns coherent memory.

Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Reviewed-by: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
---
 arch/x86/include/asm/dma-mapping.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
index 1387dafdba2d..c6d3367be916 100644
--- a/arch/x86/include/asm/dma-mapping.h
+++ b/arch/x86/include/asm/dma-mapping.h
@@ -71,7 +71,6 @@ static inline void
 dma_cache_sync(struct device *dev, void *vaddr, size_t size,
 	enum dma_data_direction dir)
 {
-	flush_write_buffers();
 }
 
 static inline unsigned long dma_alloc_coherent_mask(struct device *dev,
-- 
2.14.1

next prev parent reply	other threads:[~2017-10-03 10:43 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 10:43 refactor dma_cache_sync V2 Christoph Hellwig
2017-10-03 10:43 ` Christoph Hellwig
2017-10-03 10:43 ` Christoph Hellwig
     [not found] ` <20171003104311.10058-1-hch-jcswGhMUV9g@public.gmane.org>
2017-10-03 10:43   ` [PATCH 01/11] floppy: consolidate the dummy fd_cacheflush definition Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43   ` Christoph Hellwig [this message]
2017-10-03 10:43     ` [PATCH 02/11] x86: make dma_cache_sync a no-op Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 16:02     ` David Laight
2017-10-03 16:02       ` David Laight
     [not found]       ` <063D6719AE5E284EB5DD2968C1650D6DD0088B73-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2017-10-03 20:27         ` Thomas Gleixner
2017-10-03 20:27           ` Thomas Gleixner
2017-10-03 20:27           ` Thomas Gleixner
2017-10-03 10:43   ` [PATCH 03/11] frv: " Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43   ` [PATCH 04/11] ia64: " Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
     [not found]     ` <20171003104311.10058-5-hch-jcswGhMUV9g@public.gmane.org>
2017-10-04  8:59       ` David Laight
2017-10-04  8:59         ` David Laight
2017-10-04  8:59         ` David Laight
2017-10-04  8:59         ` David Laight
     [not found]         ` <063D6719AE5E284EB5DD2968C1650D6DD0089626-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2017-10-04  9:06           ` 'Christoph Hellwig'
2017-10-04  9:06             ` 'Christoph Hellwig'
2017-10-04  9:06             ` 'Christoph Hellwig'
2017-10-03 10:43   ` [PATCH 05/11] microblaze: " Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43   ` [PATCH 06/11] mn10300: " Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43   ` [PATCH 08/11] unicore32: " Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43   ` [PATCH 09/11] xtensa: " Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43     ` Christoph Hellwig
2017-10-03 10:43 ` [PATCH 07/11] powerpc: " Christoph Hellwig
2017-10-03 10:43   ` Christoph Hellwig
2017-10-03 11:24   ` Christophe LEROY
2017-10-03 11:24     ` Christophe LEROY
2017-10-03 11:43     ` Robin Murphy
2017-10-03 11:43       ` Robin Murphy
2017-10-03 11:43     ` Christoph Hellwig
2017-10-03 11:43       ` Christoph Hellwig
2017-10-04  8:29       ` Christophe LEROY
2017-10-04  8:29         ` Christophe LEROY
2017-10-03 10:43 ` [PATCH 10/11] sh: " Christoph Hellwig
2017-10-03 10:43   ` Christoph Hellwig
2017-10-03 10:43 ` [PATCH 11/11] dma-mapping: turn dma_cache_sync into a dma_map_ops method Christoph Hellwig
2017-10-03 10:43   ` Christoph Hellwig
2017-10-03 11:49 ` refactor dma_cache_sync V2 Robin Murphy
2017-10-03 11:49   ` Robin Murphy
2017-10-16 12:44   ` Christoph Hellwig
2017-10-16 12:44     ` Christoph Hellwig
     [not found]     ` <20171016124442.GB2177-jcswGhMUV9g@public.gmane.org>
2017-10-19 15:02       ` Christoph Hellwig
2017-10-19 15:02         ` Christoph Hellwig
2017-10-19 15:02         ` Christoph Hellwig

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:1387dafdba2 dfblob:1387dafdba2 dfblob:1387dafdba2
dfblob:c6d3367be91 dfblob:c6d3367be91 dfblob:c6d3367be91
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171003104311.10058-3-hch@lst.de \
    --to=hch@lst.de \
    --cc=chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org \
    --cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
    --cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-xtensa-PjhNF2WwrV/0Sa2dR60CXw@public.gmane.org \
    --cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.