All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ronnie Sahlberg <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-cifs <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 05/12] cifs: initialize rsp_iov in SMB2_flush
Date: Wed, 11 Oct 2017 12:59:20 +1100	[thread overview]
Message-ID: <20171011015927.7669-6-lsahlber@redhat.com> (raw)
In-Reply-To: <20171011015927.7669-1-lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Or else we might call free_rsp_buf() on an uninitialized pointer if
SendReceive2() failed

Signed-off-by: Ronnie Sahlberg <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 fs/cifs/smb2pdu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 97dc913b8dd7..ca861ee4ac0a 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -2406,7 +2406,7 @@ SMB2_flush(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid,
 	struct smb2_flush_req *req;
 	struct cifs_ses *ses = tcon->ses;
 	struct kvec iov[1];
-	struct kvec rsp_iov;
+	struct kvec rsp_iov = { NULL, 0 };
 	int resp_buftype;
 	int rc = 0;
 	int flags = 0;
-- 
2.13.3

  parent reply	other threads:[~2017-10-11  1:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11  1:59 [PATCH 00/12] cifs: various fixes for NULL pointers Ronnie Sahlberg
     [not found] ` <20171011015927.7669-1-lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-11  1:59   ` [PATCH 01/12] cifs: initialize rsp_iov in SMB2_negotiate Ronnie Sahlberg
2017-10-11  1:59   ` [PATCH 02/12] cifs: initialize rsp_iov in SMB2_ioctl and check for NULL before deref Ronnie Sahlberg
2017-10-11  1:59   ` [PATCH 03/12] cifs: initialize rsp_iov in SMB2_close Ronnie Sahlberg
2017-10-11  1:59   ` [PATCH 04/12] cifs: initialize rsp_iov in SMB2_query_info Ronnie Sahlberg
2017-10-11  1:59   ` Ronnie Sahlberg [this message]
2017-10-11  1:59   ` [PATCH 06/12] cifs: initialize rsp_iov in SMB2_read and add check for NULL Ronnie Sahlberg
2017-10-11  1:59   ` [PATCH 07/12] cifs: initialize rsp_iov in SMB2_write Ronnie Sahlberg
2017-10-11  1:59   ` [PATCH 08/12] cifs: initialize rsp_iov in SMB2_query_directory Ronnie Sahlberg
2017-10-11  1:59   ` [PATCH 09/12] cifs: initialize rsp_iov in send_set_info Ronnie Sahlberg
2017-10-11  1:59   ` [PATCH 10/12] cifs: initialize rsp_iov in SMB2_QFS_info Ronnie Sahlberg
2017-10-11  1:59   ` [PATCH 11/12] cifs: initialize rsp_iov in SMB2_QFS_attr Ronnie Sahlberg
2017-10-11  1:59   ` [PATCH 12/12] cifs: initialize rsp_iov in smb2_lockv and fix a memory leak Ronnie Sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011015927.7669-6-lsahlber@redhat.com \
    --to=lsahlber-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.