All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, adech.fo@gmail.com,
	aryabinin@virtuozzo.com, catalin.marinas@arm.com,
	christoffer.dall@linaro.org, dvyukov@google.com,
	linux-kbuild@vger.kernel.org, mark.rutland@arm.com,
	mark.zyngier@arm.com, mmarek@suse.com, will.deacon@arm.com,
	yamada.masahiro@socionext.com
Subject: [PATCH 4/4] arm64: vdso: remove pointless gcov option
Date: Mon, 16 Oct 2017 14:24:40 +0100	[thread overview]
Message-ID: <20171016132440.38098-5-mark.rutland@arm.com> (raw)
In-Reply-To: <20171016132440.38098-1-mark.rutland@arm.com>

The arm64 VDSO Makefile explicitly disables gcov; a practice we seem to
have inherited from other VDSO Makefiles.

The arm64 VDSO is written entirely in assembly, so this is not
necessary. Further, if the VDSO were written in C it would be necessary
to disable all other instrumentation, and this alone would not be
sufficient.

This patch remosves the redundant GCOV option for now.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Reported-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
---
 arch/arm64/kernel/vdso/Makefile | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile
index 62c84f7cb01b..350190b749dd 100644
--- a/arch/arm64/kernel/vdso/Makefile
+++ b/arch/arm64/kernel/vdso/Makefile
@@ -15,9 +15,6 @@ ccflags-y := -shared -fno-common -fno-builtin
 ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
 		$(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
 
-# Disable gcov profiling for VDSO code
-GCOV_PROFILE := n
-
 # Workaround for bare-metal (ELF) toolchains that neglect to pass -shared
 # down to collect2, resulting in silent corruption of the vDSO image.
 ccflags-y += -Wl,-shared
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] arm64: vdso: remove pointless gcov option
Date: Mon, 16 Oct 2017 14:24:40 +0100	[thread overview]
Message-ID: <20171016132440.38098-5-mark.rutland@arm.com> (raw)
In-Reply-To: <20171016132440.38098-1-mark.rutland@arm.com>

The arm64 VDSO Makefile explicitly disables gcov; a practice we seem to
have inherited from other VDSO Makefiles.

The arm64 VDSO is written entirely in assembly, so this is not
necessary. Further, if the VDSO were written in C it would be necessary
to disable all other instrumentation, and this alone would not be
sufficient.

This patch remosves the redundant GCOV option for now.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Reported-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
---
 arch/arm64/kernel/vdso/Makefile | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile
index 62c84f7cb01b..350190b749dd 100644
--- a/arch/arm64/kernel/vdso/Makefile
+++ b/arch/arm64/kernel/vdso/Makefile
@@ -15,9 +15,6 @@ ccflags-y := -shared -fno-common -fno-builtin
 ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
 		$(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
 
-# Disable gcov profiling for VDSO code
-GCOV_PROFILE := n
-
 # Workaround for bare-metal (ELF) toolchains that neglect to pass -shared
 # down to collect2, resulting in silent corruption of the vDSO image.
 ccflags-y += -Wl,-shared
-- 
2.11.0

  parent reply	other threads:[~2017-10-16 13:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 13:24 [PATCH 0/4] Cleanup instrumentation avoidance Mark Rutland
2017-10-16 13:24 ` Mark Rutland
2017-10-16 13:24 ` [PATCH 1/4] kbuild: allow global override of CC instrumentation Mark Rutland
2017-10-16 13:24   ` Mark Rutland
2017-10-17 10:37   ` Will Deacon
2017-10-17 10:37     ` Will Deacon
2017-10-16 13:24 ` [PATCH 2/4] arm64: prevent instrumentation of LL/SC atomics Mark Rutland
2017-10-16 13:24   ` Mark Rutland
2017-10-17 10:03   ` Will Deacon
2017-10-17 10:03     ` Will Deacon
2017-10-17 10:54     ` Mark Rutland
2017-10-17 10:54       ` Mark Rutland
2017-10-17 10:58       ` Will Deacon
2017-10-17 10:58         ` Will Deacon
2017-10-17 11:10         ` Mark Rutland
2017-10-17 11:10           ` Mark Rutland
2017-10-17 11:38           ` Will Deacon
2017-10-17 11:38             ` Will Deacon
2017-10-17 12:55             ` Mark Rutland
2017-10-17 12:55               ` Mark Rutland
2017-10-18 14:16               ` Will Deacon
2017-10-18 14:16                 ` Will Deacon
2017-10-16 13:24 ` [PATCH 3/4] kvm/arm64: simplify CC instrumentation opt-out Mark Rutland
2017-10-16 13:24   ` Mark Rutland
2017-10-17 14:50   ` Christoffer Dall
2017-10-17 14:50     ` Christoffer Dall
2017-10-16 13:24 ` Mark Rutland [this message]
2017-10-16 13:24   ` [PATCH 4/4] arm64: vdso: remove pointless gcov option Mark Rutland
2017-10-17 13:56   ` Mark Rutland
2017-10-17 13:56     ` Mark Rutland
2017-10-16 13:35 ` [PATCH 0/4] Cleanup instrumentation avoidance Mark Rutland
2017-10-16 13:35   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016132440.38098-5-mark.rutland@arm.com \
    --to=mark.rutland@arm.com \
    --cc=adech.fo@gmail.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=dvyukov@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.zyngier@arm.com \
    --cc=mmarek@suse.com \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.