All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	linux-integrity@vger.kernel.org,
	David Howells <dhowells@redhat.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	linux-security-module@vger.kernel.org,
	"open list:KEYS-TRUSTED" <keyrings@vger.kernel.org>,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
	<linux-crypto@vger.kernel.org>,
	James Morris <james.l.morris@oracle.com>,
	Matt Mackall <mpm@selenic.com>,
	David Safford <safford@us.ibm.com>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH] tpm: Move Linux RNG connection to hwrng
Date: Tue, 24 Oct 2017 15:34:49 -0600	[thread overview]
Message-ID: <20171024213449.GA21662@obsidianresearch.com> (raw)
In-Reply-To: <20171024184235.GC1806@obsidianresearch.com>

On Tue, Oct 24, 2017 at 12:42:35PM -0600, Jason Gunthorpe wrote:

> This is compile tested only.

0day says the kconfig has a problem when randomized, here is the fix I
will roll into a v2 in a few days:

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index a95725fa77789e..ca89da3e4b2ae9 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -27,16 +27,13 @@ menuconfig TCG_TPM
 if TCG_TPM
 
 config HW_RANDOM_TPM
-       tristate "TPM HW Random Number Generator support"
-       depends on TCG_TPM && HW_RANDOM
-       default HW_RANDOM
+       bool "TPM HW Random Number Generator support"
+       depends on TCG_TPM && HW_RANDOM && !(TCG_TPM=y && HW_RANDOM=m)
+       default y
        ---help---
          This driver provides kernel-side support for the Random Number
          Generator in the Trusted Platform Module
 
-         To compile this driver as a module, choose M here: the
-         module will be called tpm-rng.
-
          If unsure, say Y.
 
 config TCG_TIS_CORE

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	linux-integrity@vger.kernel.org,
	David Howells <dhowells@redhat.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	linux-security-module@vger.kernel.org,
	"open list:KEYS-TRUSTED" <keyrings@vger.kernel.org>,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
	<linux-crypto@vger.kernel.org>,
	James Morris <james.l.morris@oracle.com>,
	Matt Mackall <mpm@selenic.com>,
	David Safford <safford@us.ibm.com>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH] tpm: Move Linux RNG connection to hwrng
Date: Tue, 24 Oct 2017 21:34:49 +0000	[thread overview]
Message-ID: <20171024213449.GA21662@obsidianresearch.com> (raw)
In-Reply-To: <20171024184235.GC1806@obsidianresearch.com>

On Tue, Oct 24, 2017 at 12:42:35PM -0600, Jason Gunthorpe wrote:

> This is compile tested only.

0day says the kconfig has a problem when randomized, here is the fix I
will roll into a v2 in a few days:

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index a95725fa77789e..ca89da3e4b2ae9 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -27,16 +27,13 @@ menuconfig TCG_TPM
 if TCG_TPM
 
 config HW_RANDOM_TPM
-       tristate "TPM HW Random Number Generator support"
-       depends on TCG_TPM && HW_RANDOM
-       default HW_RANDOM
+       bool "TPM HW Random Number Generator support"
+       depends on TCG_TPM && HW_RANDOM && !(TCG_TPM=y && HW_RANDOM=m)
+       default y
        ---help---
          This driver provides kernel-side support for the Random Number
          Generator in the Trusted Platform Module
 
-         To compile this driver as a module, choose M here: the
-         module will be called tpm-rng.
-
          If unsure, say Y.
 
 config TCG_TIS_CORE

WARNING: multiple messages have this Message-ID (diff)
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] tpm: Move Linux RNG connection to hwrng
Date: Tue, 24 Oct 2017 15:34:49 -0600	[thread overview]
Message-ID: <20171024213449.GA21662@obsidianresearch.com> (raw)
In-Reply-To: <20171024184235.GC1806@obsidianresearch.com>

On Tue, Oct 24, 2017 at 12:42:35PM -0600, Jason Gunthorpe wrote:

> This is compile tested only.

0day says the kconfig has a problem when randomized, here is the fix I
will roll into a v2 in a few days:

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index a95725fa77789e..ca89da3e4b2ae9 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -27,16 +27,13 @@ menuconfig TCG_TPM
 if TCG_TPM
 
 config HW_RANDOM_TPM
-       tristate "TPM HW Random Number Generator support"
-       depends on TCG_TPM && HW_RANDOM
-       default HW_RANDOM
+       bool "TPM HW Random Number Generator support"
+       depends on TCG_TPM && HW_RANDOM && !(TCG_TPM=y && HW_RANDOM=m)
+       default y
        ---help---
          This driver provides kernel-side support for the Random Number
          Generator in the Trusted Platform Module
 
-         To compile this driver as a module, choose M here: the
-         module will be called tpm-rng.
-
          If unsure, say Y.
 
 config TCG_TIS_CORE
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-10-24 21:34 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 18:42 [PATCH] tpm: Move Linux RNG connection to hwrng Jason Gunthorpe
2017-10-24 18:42 ` Jason Gunthorpe
2017-10-24 18:42 ` Jason Gunthorpe
2017-10-24 18:42 ` Jason Gunthorpe
2017-10-24 21:34 ` Jason Gunthorpe [this message]
2017-10-24 21:34   ` Jason Gunthorpe
2017-10-24 21:34   ` Jason Gunthorpe
2017-10-24 21:34   ` Jason Gunthorpe
2017-10-24 22:29   ` Jarkko Sakkinen
2017-10-24 22:29     ` Jarkko Sakkinen
2017-10-24 22:29     ` Jarkko Sakkinen
2017-10-24 22:29     ` Jarkko Sakkinen
2017-10-25 14:45 ` PrasannaKumar Muralidharan
2017-10-25 14:57   ` PrasannaKumar Muralidharan
2017-10-25 14:45   ` PrasannaKumar Muralidharan
2017-10-25 14:45   ` PrasannaKumar Muralidharan
2017-10-25 15:18   ` Jason Gunthorpe
2017-10-25 15:18     ` Jason Gunthorpe
2017-10-25 15:18     ` Jason Gunthorpe
2017-10-25 15:18     ` Jason Gunthorpe
2017-10-25 15:25     ` PrasannaKumar Muralidharan
2017-10-25 15:37       ` PrasannaKumar Muralidharan
2017-10-25 15:25       ` PrasannaKumar Muralidharan
2017-10-25 15:25       ` PrasannaKumar Muralidharan
2017-10-25 18:58   ` Jarkko Sakkinen
2017-10-25 18:58     ` Jarkko Sakkinen
2017-10-25 18:58     ` Jarkko Sakkinen
2017-10-25 18:58     ` Jarkko Sakkinen
2017-10-25 19:37     ` Jason Gunthorpe
2017-10-25 19:37       ` Jason Gunthorpe
2017-10-25 19:37       ` Jason Gunthorpe
2017-10-25 19:37       ` Jason Gunthorpe
2017-10-25 20:00       ` Jarkko Sakkinen
2017-10-25 20:00         ` Jarkko Sakkinen
2017-10-25 20:00         ` Jarkko Sakkinen
2017-10-25 20:00         ` Jarkko Sakkinen
2017-10-25 20:04         ` Jason Gunthorpe
2017-10-25 20:04           ` Jason Gunthorpe
2017-10-25 20:04           ` Jason Gunthorpe
2017-10-25 20:04           ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024213449.GA21662@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=dhowells@redhat.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=james.l.morris@oracle.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=prasannatsmkumar@gmail.com \
    --cc=safford@us.ibm.com \
    --cc=serge@hallyn.com \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.