All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: <linux-kbuild@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <yamada.masahiro@socionext.com>, <michal.lkml@markovi.net>
Subject: [PATCH v2] kbuild: comments correction & update on Makefile.host
Date: Wed, 1 Nov 2017 09:43:14 +0800	[thread overview]
Message-ID: <20171101014314.4575-1-caoj.fnst@cn.fujitsu.com> (raw)

host-cmulti means the composite host program that is compiled/linked
from several .c file, not .o file, because .o file could also be
compiled from .cpp file.

Bonus: update the stale comment.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
 scripts/Makefile.host | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/Makefile.host b/scripts/Makefile.host
index 9cfd5c84d76f..8181df66d764 100644
--- a/scripts/Makefile.host
+++ b/scripts/Makefile.host
@@ -25,11 +25,11 @@ host-cshlib := $(sort $(hostlibs-y) $(hostlibs-m))
 host-cxxshlib := $(sort $(hostcxxlibs-y) $(hostcxxlibs-m))
 
 # C code
-# Executables compiled from a single .c file
+# C Executables compiled from a single .c file
 host-csingle	:= $(foreach m,$(__hostprogs), \
 			$(if $($(m)-objs)$($(m)-cxxobjs),,$(m)))
 
-# C executables linked based on several .o files
+# C executables compiled from several .c files, and only .c files
 host-cmulti	:= $(foreach m,$(__hostprogs),\
 		   $(if $($(m)-cxxobjs),,$(if $($(m)-objs),$(m))))
 
@@ -50,7 +50,7 @@ host-cxxshobjs	:= $(sort $(foreach m,$(host-cxxshlib),$($(m:.so=-objs))))
 
 # output directory for programs/.o files
 # hostprogs-y := tools/build may have been specified.
-# Retrieve also directory of .o files from prog-objs or prog-cxxobjs notation
+# Retrieve also directory of .o files from host-cobjs and host-cxxobjs notation
 host-objdirs := $(dir $(__hostprogs) $(host-cobjs) $(host-cxxobjs))
 
 host-objdirs := $(strip $(sort $(filter-out ./,$(host-objdirs))))
-- 
2.13.6

WARNING: multiple messages have this Message-ID (diff)
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: yamada.masahiro@socionext.com, michal.lkml@markovi.net
Subject: [PATCH v2] kbuild: comments correction & update on Makefile.host
Date: Wed, 1 Nov 2017 09:43:14 +0800	[thread overview]
Message-ID: <20171101014314.4575-1-caoj.fnst@cn.fujitsu.com> (raw)

host-cmulti means the composite host program that is compiled/linked
from several .c file, not .o file, because .o file could also be
compiled from .cpp file.

Bonus: update the stale comment.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
 scripts/Makefile.host | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/Makefile.host b/scripts/Makefile.host
index 9cfd5c84d76f..8181df66d764 100644
--- a/scripts/Makefile.host
+++ b/scripts/Makefile.host
@@ -25,11 +25,11 @@ host-cshlib := $(sort $(hostlibs-y) $(hostlibs-m))
 host-cxxshlib := $(sort $(hostcxxlibs-y) $(hostcxxlibs-m))
 
 # C code
-# Executables compiled from a single .c file
+# C Executables compiled from a single .c file
 host-csingle	:= $(foreach m,$(__hostprogs), \
 			$(if $($(m)-objs)$($(m)-cxxobjs),,$(m)))
 
-# C executables linked based on several .o files
+# C executables compiled from several .c files, and only .c files
 host-cmulti	:= $(foreach m,$(__hostprogs),\
 		   $(if $($(m)-cxxobjs),,$(if $($(m)-objs),$(m))))
 
@@ -50,7 +50,7 @@ host-cxxshobjs	:= $(sort $(foreach m,$(host-cxxshlib),$($(m:.so=-objs))))
 
 # output directory for programs/.o files
 # hostprogs-y := tools/build may have been specified.
-# Retrieve also directory of .o files from prog-objs or prog-cxxobjs notation
+# Retrieve also directory of .o files from host-cobjs and host-cxxobjs notation
 host-objdirs := $(dir $(__hostprogs) $(host-cobjs) $(host-cxxobjs))
 
 host-objdirs := $(strip $(sort $(filter-out ./,$(host-objdirs))))
-- 
2.13.6




             reply	other threads:[~2017-11-01  1:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01  1:43 Cao jin [this message]
2017-11-01  1:43 ` [PATCH v2] kbuild: comments correction & update on Makefile.host Cao jin
2017-11-13 10:50 ` Cao jin
2017-11-13 10:50   ` Cao jin
2017-11-14 10:31 ` Masahiro Yamada
2017-11-14 11:53   ` Cao jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171101014314.4575-1-caoj.fnst@cn.fujitsu.com \
    --to=caoj.fnst@cn.fujitsu.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.